All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Gordan Markuš" <gordan.markus@pelagicore.com>
To: Martin Jansa <martin.jansa@gmail.com>
Cc: openembedded-devel@lists.openembedded.org
Subject: Re: [meta-qt5][PATCH] gdb: Fix QA Warning
Date: Fri, 02 Dec 2016 14:19:52 +0100	[thread overview]
Message-ID: <1480684792.22967.5.camel@pelagicore.com> (raw)
In-Reply-To: <20161202103105.GE3721@jama>

On Fri, 2016-12-02 at 11:31 +0100, Martin Jansa wrote:
> On Fri, Dec 02, 2016 at 11:21:13AM +0100, Gordan Markuš wrote:
> > On Fri, 2016-12-02 at 10:54 +0100, Martin Jansa wrote:
> > > On Fri, Dec 02, 2016 at 10:20:11AM +0100, Gordan Markuš wrote:
> > > > WARNING: QA Issue: gdb: invalid PACKAGECONFIG: readline
> > > > [invalid-
> > > > packageconfig]
> > > > 
> > > > Signed-off-by: Gordan Markuš <gordan.markus@pelagicore.com>
> > > > ---
> > > >  recipes-devtools/gdb/gdb_%.bbappend | 2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > > 
> > > > diff --git a/recipes-devtools/gdb/gdb_%.bbappend b/recipes-
> > > > devtools/gdb/gdb_%.bbappend
> > > > index 3e663e7..41592c4 100644
> > > > --- a/recipes-devtools/gdb/gdb_%.bbappend
> > > > +++ b/recipes-devtools/gdb/gdb_%.bbappend
> > > > @@ -1 +1 @@
> > > > -PACKAGECONFIG ??= "readline python"
> > > > +PACKAGECONFIG ??= "python"
> > > 
> > > What gdb are you using? The version in oe-core has readline
> > > PACKAGECONFIG
> > > 
> > > meta/recipes-devtools/gdb/gdb-common.inc:PACKAGECONFIG ??=
> > > "readline"
> > > meta/recipes-devtools/gdb/gdb-common.inc:# Use --without-system-
> > > readline to compile with readline 5.
> > > meta/recipes-devtools/gdb/gdb-common.inc:PACKAGECONFIG[readline]
> > > = "-
> > > -with-system-readline,--without-system-readline,readline"
> > > 
> > 
> > We are using the gdb from poky and it's a similar case there.
> > Though, 
> > the gdb itself doesn't have the readline PACKAGECONFIG. It is
> > enabled
> > by default in the *.inc files. 
> 
> No, it isn't, read:
> https://patchwork.openembedded.org/patch/116843/
> discussion.
In that case the patch can be discarded.
Thank you for sharing this Martin!
> 
> > gdb-cross-canadian.inc:PACKAGECONFIG ??= "python readline"
> > gdb-cross-canadian.inc:PACKAGECONFIG[readline] = "--with-system-
> > readline,--without-system-readline,nativesdk-readline"
> > gdb-common.inc:PACKAGECONFIG ??= "readline"
> > gdb-common.inc:PACKAGECONFIG[readline] = "--with-system-readline,
> > --without-system-readline,readline"
> > gdb-cross.inc:PACKAGECONFIG ??= "python readline"
> > gdb-cross.inc:PACKAGECONFIG[readline] = "--with-system-readline,
> > --without-system-readline,readline-native"
> > 
> > > > -- 
> > > > 2.9.3
> > > > 
> > > > -- 
> > > > _______________________________________________
> > > > Openembedded-devel mailing list
> > > > Openembedded-devel@lists.openembedded.org
> > > > http://lists.openembedded.org/mailman/listinfo/openembedded-dev
> > > > el
> > > 
> > > 
> 
> 


      reply	other threads:[~2016-12-02 13:19 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-02  9:20 [meta-qt5][PATCH] gdb: Fix QA Warning Gordan Markuš
2016-12-02  9:45 ` Burton, Ross
2016-12-02  9:54 ` Martin Jansa
2016-12-02 10:21   ` Gordan Markuš
2016-12-02 10:31     ` Martin Jansa
2016-12-02 13:19       ` Gordan Markuš [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1480684792.22967.5.camel@pelagicore.com \
    --to=gordan.markus@pelagicore.com \
    --cc=martin.jansa@gmail.com \
    --cc=openembedded-devel@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.