From: Chinmay VS <cvs268@gmail.com>
To: gregkh@linuxfoundation.org, elder@kernel.org, johan@kernel.org,
pure.logic@nexus-software.ie
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
ChinmayVS <cvs268@gmail.com>
Subject: [PATCH] staging: greybus: Fix macro definition
Date: Sat, 3 Dec 2016 15:41:19 +0530 [thread overview]
Message-ID: <1480759879-9646-1-git-send-email-cvs@nvidia.com> (raw)
From: ChinmayVS <cvs268@gmail.com>
Macros with multiple statements should be enclosed in a do - while loop
Signed-off-by: ChinmayVS <cvs268@gmail.com>
---
drivers/staging/greybus/loopback.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/greybus/loopback.c b/drivers/staging/greybus/loopback.c
index 7882306..39f0a25 100644
--- a/drivers/staging/greybus/loopback.c
+++ b/drivers/staging/greybus/loopback.c
@@ -177,9 +177,11 @@ static ssize_t name##_avg_show(struct device *dev, \
static DEVICE_ATTR_RO(name##_avg)
#define gb_loopback_stats_attrs(field) \
+do { \
gb_loopback_ro_stats_attr(field, min, u); \
gb_loopback_ro_stats_attr(field, max, u); \
- gb_loopback_ro_avg_attr(field)
+ gb_loopback_ro_avg_attr(field) \
+} while (0)
#define gb_loopback_attr(field, type) \
static ssize_t field##_show(struct device *dev, \
--
2.7.4
next reply other threads:[~2016-12-03 10:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-03 10:11 Chinmay VS [this message]
2016-12-03 10:22 ` [PATCH] staging: greybus: Fix macro definition Greg KH
2016-12-03 10:47 ` Chinmay V S
2016-12-03 20:24 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1480759879-9646-1-git-send-email-cvs@nvidia.com \
--to=cvs268@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=elder@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pure.logic@nexus-software.ie \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.