From: ChinmayVS <cvs268@gmail.com>
To: gregkh@linuxfoundation.org
Cc: linux-kernel@vger.kernel.org, ChinmayVS <cvs268@gmail.com>
Subject: [PATCH] uio: uio_cif: Fix style issues
Date: Sat, 3 Dec 2016 19:39:44 +0530 [thread overview]
Message-ID: <1480774184-4655-1-git-send-email-cvs268@gmail.com> (raw)
- Update header-file inclusion path.
- Fix indentation of switch and case.
- Remove extra space in function calls.
Signed-off-by: ChinmayVS <cvs268@gmail.com>
---
drivers/uio/uio_cif.c | 26 +++++++++++++++-----------
1 file changed, 15 insertions(+), 11 deletions(-)
diff --git a/drivers/uio/uio_cif.c b/drivers/uio/uio_cif.c
index 30f533c..4acad98 100644
--- a/drivers/uio/uio_cif.c
+++ b/drivers/uio/uio_cif.c
@@ -14,7 +14,7 @@
#include <linux/slab.h>
#include <linux/uio_driver.h>
-#include <asm/io.h>
+#include <linux/io.h>
#define PLX9030_INTCSR 0x4C
#define INTSCR_INT1_ENABLE 0x01
@@ -67,16 +67,20 @@ static int hilscher_pci_probe(struct pci_dev *dev,
info->mem[1].addr = pci_resource_start(dev, 2);
info->mem[1].size = pci_resource_len(dev, 2);
info->mem[1].memtype = UIO_MEM_PHYS;
+
switch (id->subdevice) {
- case CIF_SUBDEVICE_PROFIBUS:
- info->name = "CIF_Profibus";
- break;
- case CIF_SUBDEVICE_DEVICENET:
- info->name = "CIF_Devicenet";
- break;
- default:
- info->name = "CIF_???";
+ case CIF_SUBDEVICE_PROFIBUS:
+ info->name = "CIF_Profibus";
+ break;
+
+ case CIF_SUBDEVICE_DEVICENET:
+ info->name = "CIF_Devicenet";
+ break;
+
+ default:
+ info->name = "CIF_???";
}
+
info->version = "0.0.1";
info->irq = dev->irq;
info->irq_flags = IRQF_SHARED;
@@ -95,7 +99,7 @@ static int hilscher_pci_probe(struct pci_dev *dev,
out_disable:
pci_disable_device(dev);
out_free:
- kfree (info);
+ kfree(info);
return -ENODEV;
}
@@ -108,7 +112,7 @@ static void hilscher_pci_remove(struct pci_dev *dev)
pci_disable_device(dev);
iounmap(info->mem[0].internal_addr);
- kfree (info);
+ kfree(info);
}
static struct pci_device_id hilscher_pci_ids[] = {
--
2.7.4
next reply other threads:[~2016-12-03 14:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-03 14:09 ChinmayVS [this message]
2016-12-03 17:15 ` [PATCH] uio: uio_cif: Fix style issues Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1480774184-4655-1-git-send-email-cvs268@gmail.com \
--to=cvs268@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.