From: Oliver Neukum <oneukum@suse.com>
To: Pan Bian <bianpan201603@163.com>
Cc: Jiri Kosina <jikos@kernel.org>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
linux-input@vger.kernel.org, linux-usb@vger.kernel.org,
Pan Bian <bianpan2016@163.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] input: usbhid: fix improper check
Date: Mon, 05 Dec 2016 10:07:43 +0100 [thread overview]
Message-ID: <1480928863.2206.1.camel@suse.com> (raw)
In-Reply-To: <1480828209-4131-1-git-send-email-bianpan201603@163.com>
On Sun, 2016-12-04 at 13:10 +0800, Pan Bian wrote:
> From: Pan Bian <bianpan2016@163.com>
>
> Function hid_post_reset() returns 0 on success, or 1 on failures.
It seems like hid_post_reset() is buggy in not returning
a proper error code in the failure case. So your diagnosis
is right, but the fix is at the wrong place.
Regards
Oliver
prev parent reply other threads:[~2016-12-05 9:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-04 5:10 [PATCH 1/1] input: usbhid: fix improper check Pan Bian
2016-12-05 9:07 ` Oliver Neukum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1480928863.2206.1.camel@suse.com \
--to=oneukum@suse.com \
--cc=benjamin.tissoires@redhat.com \
--cc=bianpan201603@163.com \
--cc=bianpan2016@163.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.