From: Johannes Berg <johannes@sipsolutions.net>
To: greearb@candelatech.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH 2/2] mac80211: put upper bound on txqi queue length.
Date: Mon, 05 Dec 2016 14:56:28 +0100 [thread overview]
Message-ID: <1480946188.31788.6.camel@sipsolutions.net> (raw)
In-Reply-To: <1480442753-6830-2-git-send-email-greearb@candelatech.com> (sfid-20161129_190601_774406_10D2EEDF)
On Tue, 2016-11-29 at 10:05 -0800, greearb@candelatech.com wrote:
> From: Ben Greear <greearb@candelatech.com>
>
> This fixes OOM when using pktgen to drive a wifi station at more than
> the station can transmit. pktgen uses ndo_start_xmit instead of
> going
> through the queue layer, so it will not back off when the queues are
> stopped, and would thus cause packets to be added to the txqi->queue
> until the system goes OOM and crashes.
>
> Signed-off-by: Ben Greear <greearb@candelatech.com>
> ---
>
> This is against 4.7.10+, not sure if it is actually needed in latest
> kernel.
One would hope that fq_tin_enqueue() does something like that, but
anyway the patch doesn't apply so I'm dropping it.
johannes
next prev parent reply other threads:[~2016-12-05 13:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-29 18:05 [PATCH 1/2] mac80211: Show pending txqlen in debugfs greearb
2016-11-29 18:05 ` [PATCH 2/2] mac80211: put upper bound on txqi queue length greearb
2016-12-05 13:56 ` Johannes Berg [this message]
2016-12-05 14:05 ` Michal Kazior
2016-12-05 13:59 ` [PATCH 1/2] mac80211: Show pending txqlen in debugfs Johannes Berg
2016-12-05 14:47 ` Ben Greear
2016-12-05 14:54 ` Johannes Berg
2016-12-05 14:58 ` Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1480946188.31788.6.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.