From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from s3.sipsolutions.net ([5.9.151.49] helo=sipsolutions.net) by bombadil.infradead.org with esmtps (Exim 4.85_2 #1 (Red Hat Linux)) id 1cDuaL-00036j-By for ath10k@lists.infradead.org; Mon, 05 Dec 2016 14:49:42 +0000 Message-ID: <1480949353.31788.27.camel@sipsolutions.net> Subject: Re: [PATCH 2/4] cfg80211: Add new NL80211_CMD_SET_BTCOEX_PRIORITY to support BTCOEX From: Johannes Berg Date: Mon, 05 Dec 2016 15:49:13 +0100 In-Reply-To: <1478610932-21954-3-git-send-email-c_traja@qti.qualcomm.com> References: <1478610932-21954-1-git-send-email-c_traja@qti.qualcomm.com> <1478610932-21954-3-git-send-email-c_traja@qti.qualcomm.com> Mime-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: c_traja@qti.qualcomm.com, linux-wireless@vger.kernel.org Cc: tamizhchelvam@codeaurora.org, ath10k@lists.infradead.org T24gVHVlLCAyMDE2LTExLTA4IGF0IDE4OjQ1ICswNTMwLCBjX3RyYWphQHF0aS5xdWFsY29tbS5j b20gd3JvdGU6Cj7CoAo+ICsgKiBzdHJ1Y3QgY2ZnODAyMTFfYnRjb2V4X3ByaW9yaXR5IC0gQlRD T0VYIHN1cHBvcnQgZnJhbWUgdHlwZQo+ICsgKgo+ICsgKiBUaGlzIHN0cnVjdHVyZSBkZWZpbmVz IHRoZSBkcml2ZXIgc3VwcG9ydGluZyBmcmFtZSB0eXBlcyBmb3IKPiBCVENPRVgKPiArICoKPiAr ICogQHdsYW5fYmVfcHJlZmVycmVkOiBiZXN0IGVmZm9ydCBmcmFtZXMgcHJlZmVycmVkIG92ZXIg YnQgdHJhZmZpYwo+ICsgKiBAd2xhbl9ia19wcmVmZXJyZWQ6IGJhY2tncm91bmQgZnJhbWVzIHBy ZWZlcnJlZCBvdmVyIGJ0IHRyYWZmaWMKPiArICogQHdsYW5fdmlfcHJlZmVycmVkOiB2aWRlbyBm cmFtZXMgcHJlZmVycmVkIG92ZXIgYnQgdHJhZmZpYwo+ICsgKiBAd2xhbl92b19wcmVmZXJyZWQ6 IHZvaWNlIGZyYW1lcyBwcmVmZXJyZWQgb3ZlciBidCB0cmFmZmljCj4gKyAqIEB3bGFuX2JlYWNv bl9wcmVmZXJyZWQ6IGJlYWNvbiBwcmVmZXJyZWQgb3ZlciBidCB0cmFmZmljCj4gKyAqIEB3bGFu X21nbXRfcHJlZmVycmVkOiBtYW5hZ2VtZW50IGZyYW1lcyBwcmVmZXJyZWQgb3ZldCBidCB0cmFm ZmljCgp0eXBvOiBvdmVyCgo+IMKgCj4gwqAvKioKPiArICogd2lwaHlfYnRjb2V4X3N1cHBvcnRf ZmxhZ3MKPiArICoJVGhpcyBlbnVtIGhhcyB0aGUgZHJpdmVyIHN1cHBvcnRlZCBmcmFtZSB0eXBl cyBmb3IgQlRDT0VYLgo+ICsgKiBAV0lQSFlfV0xBTl9CRV9QUkVGRVJSRUQgLSBTdXBwb3J0cyBC ZXN0IEVmZm9ydCBmcmFtZSBmb3IgQlRDT0VYCj4gKyAqIEBXSVBIWV9XTEFOX0JLX1BSRUZFUlJF RCAtIHN1cHBvcnRzIEJhY2tncm91bmQgZnJhbWUgZm9yIEJUQ09FWAo+ICsgKiBAV0lQSFlfV0xB Tl9WSV9QUkVGRVJSRUQgLSBzdXBwb3J0cyBWaWRlbyBmcmFtZSBmb3IgQlRDT0VYCj4gKyAqIEBX SVBIWV9XTEFOX1ZPX1BSRUZFUlJFRCAtIHN1cHBvcnRzIFZvaWNlIGZyYW1lIGZvciBCVENPRVgK PiArICogQFdJUEhZX1dMQU5fQkVBQ09OX1BSRUZFUlJFRCAtIHN1cHBvcnRzIEJlYWNvbiBmcmFt ZSBmb3IgQlRDT0VYCj4gKyAqIEBXSVBIWV9XTEFOX01HTVRfUFJFRkVSUkVEIC0gc3VwcG9ydHMg TWFuYWdlbWVudCBmcmFtZXMgZm9yCj4gQlRDT0VYLgo+ICsgKi8KClRoYXQncyBub3QgbWFraW5n IG11Y2ggc2Vuc2UgdG8gbWU/Cgo+ICsvKioKPiArICogZW51bSB3aXBoeV9idGNvZXhfcHJpb3Jp dHkgLSBCVENPRVggcHJpb3JpdHkgbGV2ZWwKPiArICoJVGhpcyBlbnVtIGRlZmluZXMgcHJpb3Jp dHkgbGV2ZWwgZm9yIEJUQ09FWAo+ICsgKiBXSVBIWV9XTEFOX1BSRUZFUlJFRF9MT1cgLSBsb3cg cHJpb3JpdHkgZnJhbWVzIG92ZXIgQlQgdHJhZmZpYwo+ICsgKiBXSVBIWV9XTEFOX1BSRUZFUlJF RF9ISUdIIC0gaGlnaCBwcmlvcml0eSBmcmFtZXMgb3ZlciBCVCB0cmFmZmljCj4gKyAqLwo+ICsK PiArZW51bSB3aXBoeV9idGNvZXhfcHJpb3JpdHkgewo+ICsJV0lQSFlfV0xBTl9QUkVGRVJSRURf TE9XID0gZmFsc2UsCj4gKwlXSVBIWV9XTEFOX1BSRUZFUlJFRF9ISUdIID0gdHJ1ZSwKPiArfTsK ClRoYXQgZmFsc2UvdHJ1ZSBzZWVtcyBqdXN0IHN0cmFuZ2UuCgo+ICsgKiBAYnRjb2V4X3N1cHBv cnRfZmxhZ3M6IFRoaXMgd2lsbCBoYXZlIHRoZSBkcml2ZXIgc3VwcG9ydGVkCj4gKyAqCWZyYW1l IHR5cGVzIGZvciBCVENPRVguIFRoaXMgdmFsdWUgZmlsbGVkIGJ5IHVzaW5nCj4gKyAqCSVlbnVt IHdpcGh5X2J0Y29leF9zdXBwb3J0X2ZsYWdzIHdoaWxlIGRyaXZlcgo+ICsgKglpbml0aWFsaXph dGlvbi4KClRoZSB3aG9sZSAid2lsbCBoYXZlIiBpc24ndCByZWFsbHkgY2xlYXIuCgo+ICsgKiBA Tkw4MDIxMV9BVFRSX1NFVF9CVENPRVhfUFJJT1JJVFk6IG5lc3RlZCBhdHRyaWJ1dGUgZm9yIGRy aXZlcgo+IHN1cHBvcnRpbmcKPiArICoJdGhlIEJUQ09FWC4gV2hlbiB1c2VkIHdpdGgKPiAlTkw4 MDIxMV9DTURfU0VUX0JUQ09FWF9QUklPUklUWSBpdCBjb250YWlucwo+ICsgKglhdHRyaWJ1dGVz IGFjY29yZGluZyAmZW51bSBubDgwMjExX2J0Y29leF9wcmlvcml0eSB0bwo+IGluZGljYXRlCj4g KyAqCXdoaWNoIGZyYW1lIGhhcyBoaWdoIHByaW9yaXR5IG92ZXIgQlQuCgpUaGVyZSBzaG91bGQg YmUgbm8gIlNFVCIgaW4gdGhlcmUuCgo+IMKgLyoqCj4gKyAqIGVudW0gbmw4MDIxMV9idGNvZXhf cHJpb3JpdHkgLSBCVENPRVggcGFyYW1ldGVyIGF0dHJpYnV0ZXMKPiArICoJVGhpcyBzdHJjdXR1 cmUgaGFzIGVudW0gdmFsdWVzIGZvciBkcml2ZXIgc3VwcG9ydGVkIHdsYW4KPiArICoJZnJhbWUg dHlwZSBmb3IgQlRDT0VYLgo+ICsgKiBATkw4MDIxMV9XTEFOX0JFX1BSRUZFUlJFRCAtIEJlc3Qg RWZmb3J0IGZyYW1lCj4gKyAqIEBOTDgwMjExX1dMQU5fQktfUFJFRkVSUkVEIC0gQmFja2dyb3Vu ZCBmcmFtZQo+ICsgKiBATkw4MDIxMV9XTEFOX1ZJX1BSRUZFUlJFRCAtIFZpZGVvIGZyYW1lCj4g KyAqIEBOTDgwMjExX1dMQU5fVk9fUFJFRkVSUkVEIC0gVm9pY2UgZnJhbWUKPiArICogQE5MODAy MTFfV0xBTl9CRUFDT05fUFJFRkVSUkVEIC0gQkVBQ09OIGZyYW1lCj4gKyAqIEBOTDgwMjExX1dM QU5fTUdNVF9QUkVGRVJSRUQgLSBNR01UIGZyYW1lCj4gKyAqLwo+ICsKPiArZW51bSBubDgwMjEx X2J0Y29leF9wcmlvcml0eSB7Cj4gKwlfX05MODAyMTFfV0xBTl9QUkVGRVJSRURfSU5WQUxJRCwK PiArCU5MODAyMTFfV0xBTl9CRV9QUkVGRVJSRUQsCj4gKwlOTDgwMjExX1dMQU5fQktfUFJFRkVS UkVELAo+ICsJTkw4MDIxMV9XTEFOX1ZJX1BSRUZFUlJFRCwKPiArCU5MODAyMTFfV0xBTl9WT19Q UkVGRVJSRUQsCj4gKwlOTDgwMjExX1dMQU5fQkVBQ09OX1BSRUZFUlJFRCwKPiArCU5MODAyMTFf V0xBTl9NR01UX1BSRUZFUlJFRCwKPiArCV9fTkw4MDIxMV9XTEFOX1BSRUZFUlJFRF9MQVNULAo+ ICsJTkw4MDIxMV9XTEFOX1BSRUZFUlJFRF9NQVggPQo+ICsJCQlfX05MODAyMTFfV0xBTl9QUkVG RVJSRURfTEFTVCAtIDEsCj4gK307CgpXb3VsZG4ndCBhIGJpdG1hcCBiZSBlYXNpZXI/Cgpqb2hh bm5lcwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KYXRo MTBrIG1haWxpbmcgbGlzdAphdGgxMGtAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMu aW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2F0aDEwawo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from s3.sipsolutions.net ([5.9.151.49]:43374 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751168AbcLEOtS (ORCPT ); Mon, 5 Dec 2016 09:49:18 -0500 Message-ID: <1480949353.31788.27.camel@sipsolutions.net> (sfid-20161205_154934_689693_20238DA8) Subject: Re: [PATCH 2/4] cfg80211: Add new NL80211_CMD_SET_BTCOEX_PRIORITY to support BTCOEX From: Johannes Berg To: c_traja@qti.qualcomm.com, linux-wireless@vger.kernel.org Cc: ath10k@lists.infradead.org, tamizhchelvam@codeaurora.org Date: Mon, 05 Dec 2016 15:49:13 +0100 In-Reply-To: <1478610932-21954-3-git-send-email-c_traja@qti.qualcomm.com> References: <1478610932-21954-1-git-send-email-c_traja@qti.qualcomm.com> <1478610932-21954-3-git-send-email-c_traja@qti.qualcomm.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Tue, 2016-11-08 at 18:45 +0530, c_traja@qti.qualcomm.com wrote: >  > + * struct cfg80211_btcoex_priority - BTCOEX support frame type > + * > + * This structure defines the driver supporting frame types for > BTCOEX > + * > + * @wlan_be_preferred: best effort frames preferred over bt traffic > + * @wlan_bk_preferred: background frames preferred over bt traffic > + * @wlan_vi_preferred: video frames preferred over bt traffic > + * @wlan_vo_preferred: voice frames preferred over bt traffic > + * @wlan_beacon_preferred: beacon preferred over bt traffic > + * @wlan_mgmt_preferred: management frames preferred ovet bt traffic typo: over >   >  /** > + * wiphy_btcoex_support_flags > + * This enum has the driver supported frame types for BTCOEX. > + * @WIPHY_WLAN_BE_PREFERRED - Supports Best Effort frame for BTCOEX > + * @WIPHY_WLAN_BK_PREFERRED - supports Background frame for BTCOEX > + * @WIPHY_WLAN_VI_PREFERRED - supports Video frame for BTCOEX > + * @WIPHY_WLAN_VO_PREFERRED - supports Voice frame for BTCOEX > + * @WIPHY_WLAN_BEACON_PREFERRED - supports Beacon frame for BTCOEX > + * @WIPHY_WLAN_MGMT_PREFERRED - supports Management frames for > BTCOEX. > + */ That's not making much sense to me? > +/** > + * enum wiphy_btcoex_priority - BTCOEX priority level > + * This enum defines priority level for BTCOEX > + * WIPHY_WLAN_PREFERRED_LOW - low priority frames over BT traffic > + * WIPHY_WLAN_PREFERRED_HIGH - high priority frames over BT traffic > + */ > + > +enum wiphy_btcoex_priority { > + WIPHY_WLAN_PREFERRED_LOW = false, > + WIPHY_WLAN_PREFERRED_HIGH = true, > +}; That false/true seems just strange. > + * @btcoex_support_flags: This will have the driver supported > + * frame types for BTCOEX. This value filled by using > + * %enum wiphy_btcoex_support_flags while driver > + * initialization. The whole "will have" isn't really clear. > + * @NL80211_ATTR_SET_BTCOEX_PRIORITY: nested attribute for driver > supporting > + * the BTCOEX. When used with > %NL80211_CMD_SET_BTCOEX_PRIORITY it contains > + * attributes according &enum nl80211_btcoex_priority to > indicate > + * which frame has high priority over BT. There should be no "SET" in there. >  /** > + * enum nl80211_btcoex_priority - BTCOEX parameter attributes > + * This strcuture has enum values for driver supported wlan > + * frame type for BTCOEX. > + * @NL80211_WLAN_BE_PREFERRED - Best Effort frame > + * @NL80211_WLAN_BK_PREFERRED - Background frame > + * @NL80211_WLAN_VI_PREFERRED - Video frame > + * @NL80211_WLAN_VO_PREFERRED - Voice frame > + * @NL80211_WLAN_BEACON_PREFERRED - BEACON frame > + * @NL80211_WLAN_MGMT_PREFERRED - MGMT frame > + */ > + > +enum nl80211_btcoex_priority { > + __NL80211_WLAN_PREFERRED_INVALID, > + NL80211_WLAN_BE_PREFERRED, > + NL80211_WLAN_BK_PREFERRED, > + NL80211_WLAN_VI_PREFERRED, > + NL80211_WLAN_VO_PREFERRED, > + NL80211_WLAN_BEACON_PREFERRED, > + NL80211_WLAN_MGMT_PREFERRED, > + __NL80211_WLAN_PREFERRED_LAST, > + NL80211_WLAN_PREFERRED_MAX = > + __NL80211_WLAN_PREFERRED_LAST - 1, > +}; Wouldn't a bitmap be easier? johannes