From: Johannes Berg <johannes@sipsolutions.net>
To: Ben Greear <greearb@candelatech.com>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: Return avg sig, rx, tx values in ethtool stats.
Date: Mon, 05 Dec 2016 15:53:20 +0100 [thread overview]
Message-ID: <1480949600.31788.29.camel@sipsolutions.net> (raw)
In-Reply-To: <58457D63.2010605@candelatech.com>
> Unless I screwed up, this patch also returns an average.
Oops, sorry. I missed the whole mac_div() indirection thing.
I'm not super convinced anyway though - all of this data already is
available in a much more reliable fashion, even trackable when stations
are removed (all data gets sent in the DEL_STATION notification), so
adding a crippled way to get the same data seems a bit strange?
In any case I'd want you to resend with the /* pr_..*/ stuff removed.
johannes
next prev parent reply other threads:[~2016-12-05 14:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-29 18:07 [PATCH] mac80211: Return avg sig, rx, tx values in ethtool stats greearb
2016-12-05 14:08 ` Johannes Berg
2016-12-05 14:44 ` Ben Greear
2016-12-05 14:53 ` Johannes Berg [this message]
2016-12-05 15:01 ` Ben Greear
2016-12-05 17:28 ` Felix Fietkau
2016-12-05 18:05 ` Ben Greear
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1480949600.31788.29.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.