From mboxrd@z Thu Jan 1 00:00:00 1970 From: Johannes Berg Subject: Re: [PATCH 10/10] virtio: enable endian checks for sparse builds Date: Wed, 07 Dec 2016 07:25:51 +0100 Message-ID: <1481091951.4092.12.camel@sipsolutions.net> References: <1481038106-24899-1-git-send-email-mst@redhat.com> <1481038106-24899-11-git-send-email-mst@redhat.com> (sfid-20161206_164156_647850_329465D7) Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: kvm@vger.kernel.org, Neil Armstrong , David Airlie , linux-remoteproc@vger.kernel.org, dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org, linux-s390@vger.kernel.org, "James E.J. Bottomley" , Herbert Xu , linux-scsi@vger.kernel.org, v9fs-developer@lists.sourceforge.net, Asias He , Arnd Bergmann , linux-kbuild@vger.kernel.org, Jens Axboe , Michal Marek , Stefan Hajnoczi , Matt Mackall , Greg Kroah-Hartman , linux-crypto@vger.kernel.org, netdev@vger.kernel.org, "David S. Miller" To: "Michael S. Tsirkin" , linux-kernel@vger.kernel.org Return-path: In-Reply-To: <1481038106-24899-11-git-send-email-mst@redhat.com> (sfid-20161206_164156_647850_329465D7) List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: virtualization-bounces@lists.linux-foundation.org Errors-To: virtualization-bounces@lists.linux-foundation.org List-Id: linux-crypto.vger.kernel.org T24gVHVlLCAyMDE2LTEyLTA2IGF0IDE3OjQxICswMjAwLCBNaWNoYWVsIFMuIFRzaXJraW4gd3Jv dGU6Cgo+IEl0IHNlZW1zIHRoYXQgdGhlcmUgc2hvdWxkIGJlIGEgYmV0dGVyIHdheSB0byBkbyBp dCwKPiBidXQgdGhpcyB3b3JrcyB0b28uCgpJbiBzb21lIGNhc2VzIHRoZXJlIG1pZ2h0IGJlOgoK PiAtLS0gYS9kcml2ZXJzL3MzOTAvdmlydGlvL01ha2VmaWxlCj4gKysrIGIvZHJpdmVycy9zMzkw L3ZpcnRpby9NYWtlZmlsZQo+IEBAIC02LDYgKzYsOCBAQAo+IMKgIyBpdCB1bmRlciB0aGUgdGVy bXMgb2YgdGhlIEdOVSBHZW5lcmFsIFB1YmxpYyBMaWNlbnNlICh2ZXJzaW9uIDIKPiBvbmx5KQo+ IMKgIyBhcyBwdWJsaXNoZWQgYnkgdGhlIEZyZWUgU29mdHdhcmUgRm91bmRhdGlvbi4KPiDCoAo+ ICtDRkxBR1NfdmlydGlvX2Njdy5vICs9IC1EX19DSEVDS19FTkRJQU5fXwo+ICtDRkxBR1Nfa3Zt X3ZpcnRpby5vICs9IC1EX19DSEVDS19FTkRJQU5fXwo+IMKgczM5MC12aXJ0aW8tb2JqcyA6PSB2 aXJ0aW9fY2N3Lm8KPiDCoGlmZGVmIENPTkZJR19TMzkwX0dVRVNUX09MRF9UUkFOU1BPUlQKPiDC oHMzOTAtdmlydGlvLW9ianMgKz0ga3ZtX3ZpcnRpby5vCgpIZXJlIHlvdSBjb3VsZCB1c2UKCmNj ZmxhZ3MteSArPSAtRF9fQ0hFQ0tfRU5ESUFOX18KCmZvciBleGFtcGxlLCBvciBldmVuCgpzdWJk aXItY2NmbGFncy15ICs9IC1EX19DSEVDS19FTkRJQU5fXwoKKGluIGNhc2UgYW55IHN1YmRpcnMg ZXZlciBnZXQgYWRkZWQgaGVyZSkKCj4gLS0tIGEvZHJpdmVycy92aG9zdC9NYWtlZmlsZQo+ICsr KyBiL2RyaXZlcnMvdmhvc3QvTWFrZWZpbGUKPiBAQCAtMSwzICsxLDQgQEAKPiArY2NmbGFncy15 IDo9IC1EX19DSEVDS19FTkRJQU5fXwoKTG9va3MgbGlrZSB5b3UgZGlkIHRoYXQgaGVyZSBhbmQg aW4gc29tZSBvdGhlciBwbGFjZXMgdGhvdWdoIC0gc28KcGVyaGFwcyB0aGUgczM5MCBvbmUgd2Fz IGludGVudGlvbmFsbHkgZGlmZmVyZW50PwoKPiAtLS0gYS9uZXQvcGFja2V0L01ha2VmaWxlCj4g KysrIGIvbmV0L3BhY2tldC9NYWtlZmlsZQo+IEBAIC0yLDYgKzIsNyBAQAo+IMKgIyBNYWtlZmls ZSBmb3IgdGhlIHBhY2tldCBBRi4KPiDCoCMKPiDCoAo+ICtjY2ZsYWdzLXkgOj0gLURfX0NIRUNL X0VORElBTl9fCgpUZWNobmljYWxseSB0aGlzIGlzIHNsaWdodGx5IG1vcmUgdGhhbiBhZHZlcnRp c2VkLCBidXQgSSBndWVzcyB0aGF0CnN0aWxsIG1ha2VzIHNlbnNlIGlmIGl0J3MgY2xlYW4gbm93 LgoKam9oYW5uZXMKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fClZpcnR1YWxpemF0aW9uIG1haWxpbmcgbGlzdApWaXJ0dWFsaXphdGlvbkBsaXN0cy5saW51 eC1mb3VuZGF0aW9uLm9yZwpodHRwczovL2xpc3RzLmxpbnV4Zm91bmRhdGlvbi5vcmcvbWFpbG1h bi9saXN0aW5mby92aXJ0dWFsaXphdGlvbg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from s3.sipsolutions.net ([5.9.151.49]:33268 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751225AbcLGG0i (ORCPT ); Wed, 7 Dec 2016 01:26:38 -0500 Message-ID: <1481091951.4092.12.camel@sipsolutions.net> Subject: Re: [PATCH 10/10] virtio: enable endian checks for sparse builds From: Johannes Berg Date: Wed, 07 Dec 2016 07:25:51 +0100 In-Reply-To: <1481038106-24899-11-git-send-email-mst@redhat.com> (sfid-20161206_164156_647850_329465D7) References: <1481038106-24899-1-git-send-email-mst@redhat.com> <1481038106-24899-11-git-send-email-mst@redhat.com> (sfid-20161206_164156_647850_329465D7) Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kbuild-owner@vger.kernel.org List-ID: To: "Michael S. Tsirkin" , linux-kernel@vger.kernel.org Cc: Jason Wang , linux-kbuild@vger.kernel.org, Michal Marek , Arnd Bergmann , Greg Kroah-Hartman , Matt Mackall , Herbert Xu , David Airlie , Gerd Hoffmann , Ohad Ben-Cohen , Christian Borntraeger , Cornelia Huck , "James E.J. Bottomley" , "David S. Miller" , Jens Axboe , Neil Armstrong , Stefan Hajnoczi , Asias He , linux-crypto@vger.kernel.org, dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-s390@vger.kernel.org, kvm@vger.kernel.org, linux-scsi@vger.kernel.org, v9fs-developer@lists.sourceforge.net On Tue, 2016-12-06 at 17:41 +0200, Michael S. Tsirkin wrote: > It seems that there should be a better way to do it, > but this works too. In some cases there might be: > --- a/drivers/s390/virtio/Makefile > +++ b/drivers/s390/virtio/Makefile > @@ -6,6 +6,8 @@ >  # it under the terms of the GNU General Public License (version 2 > only) >  # as published by the Free Software Foundation. >   > +CFLAGS_virtio_ccw.o += -D__CHECK_ENDIAN__ > +CFLAGS_kvm_virtio.o += -D__CHECK_ENDIAN__ >  s390-virtio-objs := virtio_ccw.o >  ifdef CONFIG_S390_GUEST_OLD_TRANSPORT >  s390-virtio-objs += kvm_virtio.o Here you could use ccflags-y += -D__CHECK_ENDIAN__ for example, or even subdir-ccflags-y += -D__CHECK_ENDIAN__ (in case any subdirs ever get added here) > --- a/drivers/vhost/Makefile > +++ b/drivers/vhost/Makefile > @@ -1,3 +1,4 @@ > +ccflags-y := -D__CHECK_ENDIAN__ Looks like you did that here and in some other places though - so perhaps the s390 one was intentionally different? > --- a/net/packet/Makefile > +++ b/net/packet/Makefile > @@ -2,6 +2,7 @@ >  # Makefile for the packet AF. >  # >   > +ccflags-y := -D__CHECK_ENDIAN__ Technically this is slightly more than advertised, but I guess that still makes sense if it's clean now. johannes