Re: [PATCH] libxl: QED disks support

[Cedric Bosdonnat <cbosdonnat@suse.com>]

On Wed, 2016-12-07 at 11:25 +0000, Wei Liu wrote:
> On Mon, Nov 14, 2016 at 03:57:00PM +0100, Cédric Bosdonnat wrote:
> > Qdisk supports qcow and qcow2, extend it to also support qed disk
> > format.
> > 
> > Signed-off-by: Cédric Bosdonnat <cbosdonnat@suse.com>
> > ---
> >  tools/libxl/libxl_device.c  |    1 +
> >  tools/libxl/libxl_dm.c      |    1 +
> >  tools/libxl/libxl_types.idl |    1 +
> >  tools/libxl/libxl_utils.c   |    2 +
> >  tools/libxl/libxlu_disk_l.c | 1018 ++++++++++++++++++++++---------------------
> >  tools/libxl/libxlu_disk_l.h |   53 +--
> >  tools/libxl/libxlu_disk_l.l |    3 +-
> 
> You would also need to patch docs/misc/xl-disk-configuration.txt and
> possibly xl manpage.

Oh indeed, I forgot about those.

> You would also need to add a LIBXL_HAVE macro in libxl.h -- there are
> quite a lot of examples there.

I pondered this too, but I managed to write a configure detection code detecting
if the format is managed without it (just by trying to build a small sample of code
using the new enum value). Do we really want to have a LIBXL_HAVE macro for every
single disk format support we add?

> Other than the things mentioned above, most code changes look rather
> mechanical to me.
> 
> But what is not very satisfying (not your fault) is that we seem to need
> to add every single disk format we want to support by hand. That's
> rather repetitive. I wonder if there should be some sort of notation in
> libxl for "all formats that QEMU supports".

Should I then check the docs for such a statement? Or should I try adding more
qemu-supported disk formats?

--
Cedric

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel