From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: Intel graphics driver community testing & development
<intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH v2] drm/i915: Catch non-existent registers in find_fw_domain
Date: Thu, 08 Dec 2016 09:53:34 +0200 [thread overview]
Message-ID: <1481183614.2952.1.camel@linux.intel.com> (raw)
In-Reply-To: <20161207182807.GF4815@nuc-i3427.alporthouse.com>
On ke, 2016-12-07 at 18:28 +0000, Chris Wilson wrote:
> On Wed, Dec 07, 2016 at 06:18:02PM +0000, Tvrtko Ursulin wrote:
> >
> > Only slight issues I can spot is that for some platforms, should it
> > trigger, it would trigger twice since
> > intel_uncore_forcewake_for_read/write functions have the same WARN.
>
> I don't think that's too much of an issue whilst both are WARN() - we
> are likely to get a flood of hits if we get any.
Yep, and they have slightly differing calling paths. Merged the patch,
thanks for the review.
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-12-08 7:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-07 13:49 [PATCH] drm/i915: Catch non-existent registers in find_fw_domain Joonas Lahtinen
2016-12-07 14:01 ` Chris Wilson
2016-12-07 14:08 ` Joonas Lahtinen
2016-12-07 14:22 ` [PATCH v2] " Joonas Lahtinen
2016-12-07 14:40 ` Chris Wilson
2016-12-07 18:18 ` Tvrtko Ursulin
2016-12-07 18:28 ` Chris Wilson
2016-12-08 7:53 ` Joonas Lahtinen [this message]
2016-12-07 17:45 ` ✓ Fi.CI.BAT: success for drm/i915: Catch non-existent registers in find_fw_domain (rev2) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1481183614.2952.1.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=tvrtko.ursulin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.