From: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
To: Jani Nikula <jani.nikula@intel.com>,
Tvrtko Ursulin <tursulin@ursulin.net>,
Intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/3] drm/i915: Introduct i915_platforms.h
Date: Thu, 08 Dec 2016 15:16:12 +0200 [thread overview]
Message-ID: <1481202972.2952.7.camel@linux.intel.com> (raw)
In-Reply-To: <87lgvqwvnn.fsf@intel.com>
On to, 2016-12-08 at 12:41 +0200, Jani Nikula wrote:
> > On Thu, 08 Dec 2016, Tvrtko Ursulin <tursulin@ursulin.net> wrote:
> >
> > From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> >
> > Inspired by the same approach used by Chris Wilson in the self
> > test patches.
> >
> > We add a separate header file containing the list of our
> > platforms and then use the pre-processor to generate all
> > other places which use that list. This avoids having to
> > list them multiple times and avoids the maintenance
> > burden.
> >
> > Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> > Cc: Chris Wilson <chris@chris-wilson.co.uk>
> > Cc: Jani Nikula <jani.nikula@intel.com>
> > Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
<SNIP>
> I was thinking we could improve the printed names here, for example:
>
> [INTEL_I965G] = "I965G/Broadwater"
> [INTEL_VALLEYVIEW] = "Valleyview/Baytrail"
>
+1 on this idea!
Regards, Joonas
--
Joonas Lahtinen
Open Source Technology Center
Intel Corporation
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-12-08 13:16 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-08 9:49 [PATCH 0/3] Claw back the IS_<platform> optimisation Tvrtko Ursulin
2016-12-08 9:49 ` [PATCH 1/3] drm/i915: Introduct i915_platforms.h Tvrtko Ursulin
2016-12-08 10:41 ` Jani Nikula
2016-12-08 13:16 ` Joonas Lahtinen [this message]
2016-12-08 13:21 ` Tvrtko Ursulin
2016-12-08 9:49 ` [PATCH 2/3] drm/i915: Generate all IS_<platform> macros Tvrtko Ursulin
2016-12-08 10:46 ` Jani Nikula
2016-12-08 13:26 ` Tvrtko Ursulin
2016-12-08 13:37 ` Jani Nikula
2016-12-08 13:40 ` Jani Nikula
2016-12-08 13:42 ` Tvrtko Ursulin
2016-12-08 14:00 ` Jani Nikula
2016-12-08 14:10 ` Tvrtko Ursulin
2016-12-08 9:49 ` [PATCH 3/3] drm/i915: Number the platform enum strategically Tvrtko Ursulin
2016-12-08 10:04 ` Chris Wilson
2016-12-08 13:38 ` [PATCH v2] " Tvrtko Ursulin
2016-12-08 11:54 ` ✓ Fi.CI.BAT: success for Claw back the IS_<platform> optimisation Patchwork
2016-12-08 15:15 ` ✗ Fi.CI.BAT: warning for Claw back the IS_<platform> optimisation (rev2) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1481202972.2952.7.camel@linux.intel.com \
--to=joonas.lahtinen@linux.intel.com \
--cc=Intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=tursulin@ursulin.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.