From: Patrick Ohly <patrick.ohly@intel.com>
To: Andreas Oberritter <obi@opendreambox.org>
Cc: openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 01/11] buildstats: add system state sampling
Date: Fri, 09 Dec 2016 08:57:05 +0100 [thread overview]
Message-ID: <1481270225.17535.133.camel@intel.com> (raw)
In-Reply-To: <5dbe9bcf-935d-dd2c-1a8e-2a62c569aab8@opendreambox.org>
On Fri, 2016-12-09 at 01:29 +0100, Andreas Oberritter wrote:
> Hi Patrick,
>
> On 28.11.2016 16:33, Patrick Ohly wrote:
> > + def sample(self, force):
> > + now = time.time()
> > + if (now - self.last > self.min_seconds) or force:
> > + for filename, output in self.proc_files:
> > + with open(os.path.join('/proc', filename), 'rb') as input:
> ^
> this fails with a backtrace if /proc/diskstats is not available, which
> may be the case in virtualized environments, e.g. Linux-VServer.
Thanks for pointing that out, I'll send a fix.
--
Best Regards, Patrick Ohly
The content of this message is my personal opinion only and although
I am an employee of Intel, the statements I make here in no way
represent Intel's position on the issue, nor am I authorized to speak
on behalf of Intel on this matter.
next prev parent reply other threads:[~2016-12-09 7:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-28 15:33 [PATCH 00/11] system statistics sampling Patrick Ohly
2016-11-28 15:33 ` [PATCH 01/11] buildstats: add system state sampling Patrick Ohly
2016-12-09 0:29 ` Andreas Oberritter
2016-12-09 7:55 ` Patrick Ohly
2016-12-09 7:57 ` Patrick Ohly [this message]
2016-11-28 15:33 ` [PATCH 02/11] pybootchartgui/draw.py: allow moving process chart up and down Patrick Ohly
2016-11-28 15:33 ` [PATCH 03/11] pybootchartgui/draw.py: fix drawing of samples not starting at zero Patrick Ohly
2016-11-28 15:33 ` [PATCH 04/11] pybootchartgui: show system utilization Patrick Ohly
2016-11-28 15:33 ` [PATCH 05/11] pybootchartgui/draw.py: skip empty CPU and disk usage charts Patrick Ohly
2016-11-28 15:33 ` [PATCH 06/11] buildstats: record disk space usage Patrick Ohly
2016-11-28 15:33 ` [PATCH 07/11] pybootchartgui/parsing.py: fix error handling in meminfo parser Patrick Ohly
2016-11-28 15:33 ` [PATCH 08/11] pybootchartgui: render disk space usage Patrick Ohly
2016-11-28 15:33 ` [PATCH 09/11] pybootchartgui: simplify drawing of memory usage Patrick Ohly
2016-11-28 15:33 ` [PATCH 10/11] buildstats: reduce amount of data stored for system utilization Patrick Ohly
2016-11-28 15:33 ` [PATCH 11/11] pybootchartgui: support reading reduced /proc logs Patrick Ohly
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1481270225.17535.133.camel@intel.com \
--to=patrick.ohly@intel.com \
--cc=obi@opendreambox.org \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.