From: James Bottomley <jejb@linux.vnet.ibm.com>
To: Wei Fang <fangwei1@huawei.com>, martin.petersen@oracle.com
Cc: linux-scsi@vger.kernel.org, bart.vanassche@sandisk.com,
emilne@redhat.com
Subject: Re: [PATCH v2] scsi: avoid a permanent stop of the scsi device's request queue
Date: Fri, 09 Dec 2016 07:24:52 -0800 [thread overview]
Message-ID: <1481297092.2403.2.camel@linux.vnet.ibm.com> (raw)
In-Reply-To: <1481276138-570-1-git-send-email-fangwei1@huawei.com>
On Fri, 2016-12-09 at 17:35 +0800, Wei Fang wrote:
> diff --git a/include/scsi/scsi_device.h b/include/scsi/scsi_device.h
> index 8990e58..5c53cf5 100644
> --- a/include/scsi/scsi_device.h
> +++ b/include/scsi/scsi_device.h
> @@ -31,7 +31,7 @@ struct scsi_mode_data {
> enum scsi_device_state {
> SDEV_CREATED = 1, /* device created but not added to
> sysfs
> * Only internal commands allowed
> (for inq) */
> - SDEV_RUNNING, /* device properly configured
> + SDEV_RUNNING, /* device properly initialized
> * All commands allowed */
> SDEV_CANCEL, /* beginning to delete device
> * Only error handler commands
> allowed */
This hunk is still pointless. What even is the difference between
initialized and configured to someone reading the comments?
The reason for not having pointless changes is to make this as clean as
possible for a backport to stable.
James
next prev parent reply other threads:[~2016-12-09 15:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-09 9:35 [PATCH v2] scsi: avoid a permanent stop of the scsi device's request queue Wei Fang
2016-12-09 15:24 ` James Bottomley [this message]
2016-12-09 16:02 ` James Bottomley
2016-12-12 1:54 ` Wei Fang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1481297092.2403.2.camel@linux.vnet.ibm.com \
--to=jejb@linux.vnet.ibm.com \
--cc=bart.vanassche@sandisk.com \
--cc=emilne@redhat.com \
--cc=fangwei1@huawei.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.