From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: Re: [PATCH v2 3/5] i2c: designware-baytrail: Only check iosf_mbi_available() for shared hosts Date: Sat, 10 Dec 2016 16:54:20 +0200 Message-ID: <1481381660.7188.7.camel@linux.intel.com> References: <20161210141908.16470-1-hdegoede@redhat.com> <20161210141908.16470-3-hdegoede@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Return-path: Received: from mga14.intel.com ([192.55.52.115]:58556 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751494AbcLJOyX (ORCPT ); Sat, 10 Dec 2016 09:54:23 -0500 In-Reply-To: <20161210141908.16470-3-hdegoede@redhat.com> Sender: linux-i2c-owner@vger.kernel.org List-Id: linux-i2c@vger.kernel.org To: Hans de Goede , Jarkko Nikula , Wolfram Sang Cc: Mika Westerberg , Takashi Iwai , "russianneuromancer @ ya . ru" , Vincent Gerris , linux-i2c@vger.kernel.org On Sat, 2016-12-10 at 15:19 +0100, Hans de Goede wrote: > There is no need to delay the probe if iosf_mbi_available() returns > false when an i2c bus is not using the punit semaphore. > --- a/drivers/i2c/busses/i2c-designware-baytrail.c > +++ b/drivers/i2c/busses/i2c-designware-baytrail.c > @@ -139,14 +139,14 @@ int i2c_dw_eval_lock_support(struct dw_i2c_dev > *dev) >   return 0; >   >   if (shared_host) { > + if (!iosf_mbi_available()) > + return -EPROBE_DEFER; > + Looking to the implementation of i2c_dw_eval_lock_support() I would rewrite this like if (!shared_host) return 0; >   dev_info(dev->dev, "I2C bus managed by PUNIT\n"); >   dev->acquire_lock = baytrail_i2c_acquire; >   dev->release_lock = baytrail_i2c_release; >   dev->pm_runtime_disabled = true; >   } >   > - if (!iosf_mbi_available()) > - return -EPROBE_DEFER; > - >   return 0; >  } -- Andy Shevchenko Intel Finland Oy