diff for duplicates of <1481558130.1764.21.camel@perches.com> diff --git a/a/1.txt b/N1/1.txt index d64bcba..c0904d8 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,29 +1,29 @@ -On Mon, 2016-12-12 at 16:47 +0100, Julia Lawall wrote: +On Mon, 2016-12-12@16:47 +0100, Julia Lawall wrote: > > On Mon, 12 Dec 2016, Dan Carpenter wrote: > -> > On Sat, Dec 10, 2016 at 02:24:22PM -0800, Joe Perches wrote: -> > > On Sun, 2016-12-11 at 00:07 +0300, Dan Carpenter wrote: -> > > > On Sat, Dec 10, 2016 at 12:54:50PM -0800, Joe Perches wrote: +> > On Sat, Dec 10, 2016@02:24:22PM -0800, Joe Perches wrote: +> > > On Sun, 2016-12-11@00:07 +0300, Dan Carpenter wrote: +> > > > On Sat, Dec 10, 2016@12:54:50PM -0800, Joe Perches wrote: > > > > > diff -u -p drivers//dma/pxa_dma.c /tmp/nothing//dma/pxa_dma.c > > > > > --- drivers//dma/pxa_dma.c > > > > > +++ /tmp/nothing//dma/pxa_dma.c > > > > > @@ -640,9 +640,6 @@ static unsigned int clear_chan_irq(struc -> > > > > dcsr = phy_readl_relaxed(phy, DCSR); -> > > > > phy_writel(phy, dcsr, DCSR); -> > > > > if ((dcsr & PXA_DCSR_BUSERR) && (phy->vchan)) -> > > > > - dev_warn(&phy->vchan->vc.chan.dev->device, -> > > > > - "%s(chan=%p): PXA_DCSR_BUSERR\n", -> > > > > - __func__, &phy->vchan); +> > > > >?????????dcsr = phy_readl_relaxed(phy, DCSR); +> > > > >?????????phy_writel(phy, dcsr, DCSR); +> > > > >?????????if ((dcsr & PXA_DCSR_BUSERR) && (phy->vchan)) +> > > > > -???????????????dev_warn(&phy->vchan->vc.chan.dev->device, +> > > > > -??????????????????????? "%s(chan=%p): PXA_DCSR_BUSERR\n", +> > > > > -??????????????????????? __func__, &phy->vchan); > > > > -> > > > That's not a defect. We're getting the address of vchan. I don't get +> > > > That's not a defect.? We're getting the address of vchan.? I don't get > > > > it? > > > > > > $ git grep -n -w vchan drivers/dma/pxa* -> > > drivers/dma/pxa_dma.c:103: struct pxad_chan *vchan; +> > > drivers/dma/pxa_dma.c:103:????? struct pxad_chan??????? *vchan; > > -> > I'm not sure what you're saying here still. This code works as -> > intended. We're not printing a stack address. +> > I'm not sure what you're saying here still.? This code works as +> > intended.? We're not printing a stack address. > > I guess that the point is that one would like to print the channel, not > the address of the channel? @@ -31,7 +31,3 @@ On Mon, 2016-12-12 at 16:47 +0100, Julia Lawall wrote: Generally, printing the address of a pointer _can_ be useful, but it's likely a defect with a low false positive rate. --- -To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in -the body of a message to majordomo@vger.kernel.org -More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/a/content_digest b/N1/content_digest index 8064389..70bedc9 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -7,48 +7,43 @@ "ref\01481408662.1764.3.camel@perches.com\0" "ref\020161212093352.GB8176@mwanda\0" "ref\0alpine.DEB.2.10.1612121646460.3156@hadrien\0" - "From\0Joe Perches <joe@perches.com>\0" - "Subject\0Re: [patch] nvme-fabrics: correct some printk information\0" - "Date\0Mon, 12 Dec 2016 15:55:30 +0000\0" - "To\0kernel-janitors@vger.kernel.org\0" + "From\0joe@perches.com (Joe Perches)\0" + "Subject\0[patch] nvme-fabrics: correct some printk information\0" + "Date\0Mon, 12 Dec 2016 07:55:30 -0800\0" "\00:1\0" "b\0" - "On Mon, 2016-12-12 at 16:47 +0100, Julia Lawall wrote:\n" + "On Mon, 2016-12-12@16:47 +0100, Julia Lawall wrote:\n" "> \n" "> On Mon, 12 Dec 2016, Dan Carpenter wrote:\n" "> \n" - "> > On Sat, Dec 10, 2016 at 02:24:22PM -0800, Joe Perches wrote:\n" - "> > > On Sun, 2016-12-11 at 00:07 +0300, Dan Carpenter wrote:\n" - "> > > > On Sat, Dec 10, 2016 at 12:54:50PM -0800, Joe Perches wrote:\n" + "> > On Sat, Dec 10, 2016@02:24:22PM -0800, Joe Perches wrote:\n" + "> > > On Sun, 2016-12-11@00:07 +0300, Dan Carpenter wrote:\n" + "> > > > On Sat, Dec 10, 2016@12:54:50PM -0800, Joe Perches wrote:\n" "> > > > > diff -u -p drivers//dma/pxa_dma.c /tmp/nothing//dma/pxa_dma.c\n" "> > > > > --- drivers//dma/pxa_dma.c\n" "> > > > > +++ /tmp/nothing//dma/pxa_dma.c\n" "> > > > > @@ -640,9 +640,6 @@ static unsigned int clear_chan_irq(struc\n" - "> > > > >\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240dcsr = phy_readl_relaxed(phy, DCSR);\n" - "> > > > >\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240phy_writel(phy, dcsr, DCSR);\n" - "> > > > >\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240if ((dcsr & PXA_DCSR_BUSERR) && (phy->vchan))\n" - "> > > > > -\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240dev_warn(&phy->vchan->vc.chan.dev->device,\n" - "> > > > > -\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240 \"%s(chan=%p): PXA_DCSR_BUSERR\\n\",\n" - "> > > > > -\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240 __func__, &phy->vchan);\n" + "> > > > >?????????dcsr = phy_readl_relaxed(phy, DCSR);\n" + "> > > > >?????????phy_writel(phy, dcsr, DCSR);\n" + "> > > > >?????????if ((dcsr & PXA_DCSR_BUSERR) && (phy->vchan))\n" + "> > > > > -???????????????dev_warn(&phy->vchan->vc.chan.dev->device,\n" + "> > > > > -??????????????????????? \"%s(chan=%p): PXA_DCSR_BUSERR\\n\",\n" + "> > > > > -??????????????????????? __func__, &phy->vchan);\n" "> > > >\n" - "> > > > That's not a defect.\302\240 We're getting the address of vchan.\302\240 I don't get\n" + "> > > > That's not a defect.? We're getting the address of vchan.? I don't get\n" "> > > > it?\n" "> > >\n" "> > > $ git grep -n -w vchan drivers/dma/pxa*\n" - "> > > drivers/dma/pxa_dma.c:103:\302\240\302\240\302\240\302\240\302\240 struct pxad_chan\302\240\302\240\302\240\302\240\302\240\302\240\302\240 *vchan;\n" + "> > > drivers/dma/pxa_dma.c:103:????? struct pxad_chan??????? *vchan;\n" "> >\n" - "> > I'm not sure what you're saying here still.\302\240 This code works as\n" - "> > intended.\302\240 We're not printing a stack address.\n" + "> > I'm not sure what you're saying here still.? This code works as\n" + "> > intended.? We're not printing a stack address.\n" "> \n" "> I guess that the point is that one would like to print the channel, not\n" "> the address of the channel?\n" "\n" "Generally, printing the address of a pointer\n" "_can_ be useful, but it's likely a defect with\n" - "a low false positive rate.\n" - "--\n" - "To unsubscribe from this list: send the line \"unsubscribe kernel-janitors\" in\n" - "the body of a message to majordomo@vger.kernel.org\n" - More majordomo info at http://vger.kernel.org/majordomo-info.html + a low false positive rate. -117c551b070874d1cad9b7b5bc27071f7ea69101fbd278a276f94b0af4c663d5 +b0cf7cc15aa5d50c59ae923d1c2be5e3c7ae63a1647bb5668186d4bf018cbbac
diff --git a/a/1.txt b/N2/1.txt index d64bcba..15bae74 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -31,7 +31,3 @@ On Mon, 2016-12-12 at 16:47 +0100, Julia Lawall wrote: Generally, printing the address of a pointer _can_ be useful, but it's likely a defect with a low false positive rate. --- -To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in -the body of a message to majordomo@vger.kernel.org -More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/a/content_digest b/N2/content_digest index 8064389..3825cd2 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -9,8 +9,15 @@ "ref\0alpine.DEB.2.10.1612121646460.3156@hadrien\0" "From\0Joe Perches <joe@perches.com>\0" "Subject\0Re: [patch] nvme-fabrics: correct some printk information\0" - "Date\0Mon, 12 Dec 2016 15:55:30 +0000\0" - "To\0kernel-janitors@vger.kernel.org\0" + "Date\0Mon, 12 Dec 2016 07:55:30 -0800\0" + "To\0Julia Lawall <julia.lawall@lip6.fr>" + " Dan Carpenter <dan.carpenter@oracle.com>\0" + "Cc\0James Smart <james.smart@broadcom.com>" + Keith Busch <keith.busch@intel.com> + Jens Axboe <axboe@fb.com> + linux-nvme@lists.infradead.org + linux-kernel@vger.kernel.org + " kernel-janitors@vger.kernel.org\0" "\00:1\0" "b\0" "On Mon, 2016-12-12 at 16:47 +0100, Julia Lawall wrote:\n" @@ -45,10 +52,6 @@ "\n" "Generally, printing the address of a pointer\n" "_can_ be useful, but it's likely a defect with\n" - "a low false positive rate.\n" - "--\n" - "To unsubscribe from this list: send the line \"unsubscribe kernel-janitors\" in\n" - "the body of a message to majordomo@vger.kernel.org\n" - More majordomo info at http://vger.kernel.org/majordomo-info.html + a low false positive rate. -117c551b070874d1cad9b7b5bc27071f7ea69101fbd278a276f94b0af4c663d5 +b643bc81a90817128bacaba621565f372dee69d1144c4f1d41dd14e08fd422ff
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.