Re: [PATCH] x86/platform/intel-mid: Constify mid_pci_platform_pm

[Andy Shevchenko <andriy.shevchenko@linux.intel.com>]

On Mon, 2016-12-12 at 10:01 -0600, Bjorn Helgaas wrote:
> On Mon, Dec 12, 2016 at 08:27:33AM +0100, Ingo Molnar wrote:

> I can't remember why we decided to put pci-mid.c in drivers/pci.

In the first place there were no such comments like below.

>   The
> obviously reason is that it uses pci_platform_pm_ops, which isn't
> visible outside drivers/pci, but pci-mid.c is clearly platform-
> specific, and even the name "pci_platform_pm_ops" sounds like
> something that should be implemented in the arch directories, so maybe
> pci_platform_pm_ops should be moved to include/linux/pci.h.

You are repeating yourself here. Last time I have referred to another
user of that struct which doesn't belong to arch, but to drivers/acpi.
And my opinion here is to keep things for now, until some common
solution would be developed.

> I have strange sense of déjà vu writing this, so sorry if I'm
> repeating something.

Yes, that's right.

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy