From: Joe Perches <joe@perches.com>
To: Mika Westerberg <mika.westerberg@linux.intel.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Tin Huynh <tnhuynh@apm.com>,
Jarkko Nikula <jarkko.nikula@linux.intel.com>,
Wolfram Sang <wsa@the-dreams.de>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-acpi@vger.kernel.org, Loc Ho <lho@apm.com>,
Thang Nguyen <tqnguyen@apm.com>, Phong Vo <pvo@apm.com>,
patches@apm.com
Subject: Re: [PATCH V3] i2c: designware: fix wrong tx/rx fifo for ACPI
Date: Mon, 12 Dec 2016 11:35:19 -0800 [thread overview]
Message-ID: <1481571319.1764.32.camel@perches.com> (raw)
In-Reply-To: <20161212192113.GA1460@lahna.fi.intel.com>
On Mon, 2016-12-12 at 21:21 +0200, Mika Westerberg wrote:
> On Mon, Dec 12, 2016 at 09:02:53PM +0200, Andy Shevchenko wrote:
> > > + tx_fifo_depth = ((param1 >> 16) & 0xff) + 1;
> > > + rx_fifo_depth = ((param1 >> 8) & 0xff) + 1;
> > > + if (!dev->tx_fifo_depth) {
> > > + dev->tx_fifo_depth = tx_fifo_depth;
> > > + dev->rx_fifo_depth = rx_fifo_depth;
> > > + } else if (tx_fifo_depth) {
> > > + dev->tx_fifo_depth = min_t(u32, dev->tx_fifo_depth,
> > > + tx_fifo_depth);
> > > + dev->rx_fifo_depth = min_t(u32, dev->rx_fifo_depth,
> > > + rx_fifo_depth);
> > > + }
> >
> > So, let's clarify here:
> > Is it possible to have an IP without parameter block enabled? I mean to
> > read something arbitrary (or zeroes, or all-ones) from param1.
>
> Yes and it is Intel IP. Haswell IIRC and it returned zeroes.
The "+ 1" in the first set of tx_fifo_depth
makes the "else if" check unnecessary.
next prev parent reply other threads:[~2016-12-12 19:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-12 8:36 [PATCH V3] i2c: designware: fix wrong tx/rx fifo for ACPI Tin Huynh
2016-12-12 19:02 ` Andy Shevchenko
2016-12-12 19:21 ` Mika Westerberg
2016-12-12 19:35 ` Joe Perches [this message]
2016-12-13 10:19 ` Mika Westerberg
2016-12-12 19:46 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1481571319.1764.32.camel@perches.com \
--to=joe@perches.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=lho@apm.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=patches@apm.com \
--cc=pvo@apm.com \
--cc=tnhuynh@apm.com \
--cc=tqnguyen@apm.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.