From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from s3.sipsolutions.net ([5.9.151.49] helo=sipsolutions.net) by bombadil.infradead.org with esmtps (Exim 4.85_2 #1 (Red Hat Linux)) id 1cGpe8-0006UM-J7 for ath10k@lists.infradead.org; Tue, 13 Dec 2016 16:09:42 +0000 Message-ID: <1481645351.20412.34.camel@sipsolutions.net> Subject: Re: [PATCH 2/4] cfg80211: Add new NL80211_CMD_SET_BTCOEX_PRIORITY to support BTCOEX From: Johannes Berg Date: Tue, 13 Dec 2016 17:09:11 +0100 In-Reply-To: <5e5e8971c96293a81e7cb37bcdfbd593@codeaurora.org> References: <1478610932-21954-1-git-send-email-c_traja@qti.qualcomm.com> <1478610932-21954-3-git-send-email-c_traja@qti.qualcomm.com> <1480949353.31788.27.camel@sipsolutions.net> <5e5e8971c96293a81e7cb37bcdfbd593@codeaurora.org> Mime-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Tamizh chelvam Cc: c_traja@qti.qualcomm.com, linux-wireless@vger.kernel.org, ath10k@lists.infradead.org Cj4gPiA+IMKgLyoqCj4gPiA+ICsgKiB3aXBoeV9idGNvZXhfc3VwcG9ydF9mbGFncwo+ID4gPiAr ICoJVGhpcyBlbnVtIGhhcyB0aGUgZHJpdmVyIHN1cHBvcnRlZCBmcmFtZSB0eXBlcyBmb3IKPiA+ ID4gQlRDT0VYLgo+ID4gPiArICogQFdJUEhZX1dMQU5fQkVfUFJFRkVSUkVEIC0gU3VwcG9ydHMg QmVzdCBFZmZvcnQgZnJhbWUgZm9yCj4gPiA+IEJUQ09FWAo+ID4gPiArICogQFdJUEhZX1dMQU5f QktfUFJFRkVSUkVEIC0gc3VwcG9ydHMgQmFja2dyb3VuZCBmcmFtZSBmb3IKPiA+ID4gQlRDT0VY Cj4gPiA+ICsgKiBAV0lQSFlfV0xBTl9WSV9QUkVGRVJSRUQgLSBzdXBwb3J0cyBWaWRlbyBmcmFt ZSBmb3IgQlRDT0VYCj4gPiA+ICsgKiBAV0lQSFlfV0xBTl9WT19QUkVGRVJSRUQgLSBzdXBwb3J0 cyBWb2ljZSBmcmFtZSBmb3IgQlRDT0VYCj4gPiA+ICsgKiBAV0lQSFlfV0xBTl9CRUFDT05fUFJF RkVSUkVEIC0gc3VwcG9ydHMgQmVhY29uIGZyYW1lIGZvcgo+ID4gPiBCVENPRVgKPiA+ID4gKyAq IEBXSVBIWV9XTEFOX01HTVRfUFJFRkVSUkVEIC0gc3VwcG9ydHMgTWFuYWdlbWVudCBmcmFtZXMg Zm9yCj4gPiA+IEJUQ09FWC4KPiA+ID4gKyAqLwo+ID4gCj4gPiBUaGF0J3Mgbm90IG1ha2luZyBt dWNoIHNlbnNlIHRvIG1lPwo+ID4gCj4gCj4gaXMgaXQgZmluZSB0byBoYXZlIGFzIFdJUEhZX0JU Q09FWF9CRV9QUkVGRVJSRUQgPwoKSXQncyBub3QgcmVhbGx5IGNsZWFyIHRvIG1lIHdoYXQgeW91 IGludGVuZCB0byBkbyB0aGlzIC0gaWYgaXQncyByZWFsbHkKc3VwcG9ydCBmbGFncyB0aGVuIHlv dSByZWFsbHkgc2hvdWxkIG5hbWUgdGhvc2UgYmV0dGVyLgoKPiA+ID4gKy8qKgo+ID4gPiArICog ZW51bSB3aXBoeV9idGNvZXhfcHJpb3JpdHkgLSBCVENPRVggcHJpb3JpdHkgbGV2ZWwKPiA+ID4g KyAqCVRoaXMgZW51bSBkZWZpbmVzIHByaW9yaXR5IGxldmVsIGZvciBCVENPRVgKPiA+ID4gKyAq IFdJUEhZX1dMQU5fUFJFRkVSUkVEX0xPVyAtIGxvdyBwcmlvcml0eSBmcmFtZXMgb3ZlciBCVAo+ ID4gPiB0cmFmZmljCj4gPiA+ICsgKiBXSVBIWV9XTEFOX1BSRUZFUlJFRF9ISUdIIC0gaGlnaCBw cmlvcml0eSBmcmFtZXMgb3ZlciBCVAo+ID4gPiB0cmFmZmljCj4gPiA+ICsgKi8KPiA+ID4gKwo+ ID4gPiArZW51bSB3aXBoeV9idGNvZXhfcHJpb3JpdHkgewo+ID4gPiArCVdJUEhZX1dMQU5fUFJF RkVSUkVEX0xPVyA9IGZhbHNlLAo+ID4gPiArCVdJUEhZX1dMQU5fUFJFRkVSUkVEX0hJR0ggPSB0 cnVlLAo+ID4gPiArfTsKPiA+IAo+ID4gVGhhdCBmYWxzZS90cnVlIHNlZW1zIGp1c3Qgc3RyYW5n ZS4KPiA+IAo+IAo+IEkgd2lsbCBqdXN0IHVzZSBhcyBhIGVudW0gd2l0aG91dCBhc3NpZ25pbmcg ZmFsc2UvdHJ1ZS4KCldoYXQgZG8geW91IGV2ZW4gbmVlZCB0aGlzIGVudW0gZm9yIHRob3VnaD8K Cj4gPiA+ICtlbnVtIG5sODAyMTFfYnRjb2V4X3ByaW9yaXR5IHsKPiA+ID4gKwlfX05MODAyMTFf V0xBTl9QUkVGRVJSRURfSU5WQUxJRCwKPiA+ID4gKwlOTDgwMjExX1dMQU5fQkVfUFJFRkVSUkVE LAo+ID4gPiArCU5MODAyMTFfV0xBTl9CS19QUkVGRVJSRUQsCj4gPiA+ICsJTkw4MDIxMV9XTEFO X1ZJX1BSRUZFUlJFRCwKPiA+ID4gKwlOTDgwMjExX1dMQU5fVk9fUFJFRkVSUkVELAo+ID4gPiAr CU5MODAyMTFfV0xBTl9CRUFDT05fUFJFRkVSUkVELAo+ID4gPiArCU5MODAyMTFfV0xBTl9NR01U X1BSRUZFUlJFRCwKPiA+ID4gKwlfX05MODAyMTFfV0xBTl9QUkVGRVJSRURfTEFTVCwKPiA+ID4g KwlOTDgwMjExX1dMQU5fUFJFRkVSUkVEX01BWCA9Cj4gPiA+ICsJCQlfX05MODAyMTFfV0xBTl9Q UkVGRVJSRURfTEFTVCAtIDEsCj4gPiA+ICt9Owo+ID4gCj4gPiBXb3VsZG4ndCBhIGJpdG1hcCBi ZSBlYXNpZXI/Cj4gPiAKPiBzaW5jZSB0aGlzIGlzIHRvIGRpc3Rpbmd1aXNoIGJldHdlZW4gZGlm ZmVyZW50IGJ0Y29leCBwcmlvcml0aWVzIGFuZAo+IHdlwqAKPiBhcmUgbm90IGdvaW5nIHRvIGRv IGFueSBtYW5pcHVsYXRpb25zIG9uIHRoZXNlIHBhcmFtZXRlcnMuCj4gSXQgaXMganVzdCB1c2Vk IGFzIGZsYWcgYXR0cmlidXRlLgoKQnV0IHdoeSB0aGUgKHBhcnNpbmcpIGNvbXBsZXhpdHksIHdo ZW4gYSBzaW5nbGUgYml0bWFwIHdvdWxkIGRvPwoKam9oYW5uZXMKCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmF0aDEwayBtYWlsaW5nIGxpc3QKYXRoMTBr QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9s aXN0aW5mby9hdGgxMGsK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from s3.sipsolutions.net ([5.9.151.49]:50474 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933726AbcLMQJQ (ORCPT ); Tue, 13 Dec 2016 11:09:16 -0500 Message-ID: <1481645351.20412.34.camel@sipsolutions.net> (sfid-20161213_171012_140266_DC3F2D22) Subject: Re: [PATCH 2/4] cfg80211: Add new NL80211_CMD_SET_BTCOEX_PRIORITY to support BTCOEX From: Johannes Berg To: Tamizh chelvam Cc: c_traja@qti.qualcomm.com, linux-wireless@vger.kernel.org, ath10k@lists.infradead.org Date: Tue, 13 Dec 2016 17:09:11 +0100 In-Reply-To: <5e5e8971c96293a81e7cb37bcdfbd593@codeaurora.org> References: <1478610932-21954-1-git-send-email-c_traja@qti.qualcomm.com> <1478610932-21954-3-git-send-email-c_traja@qti.qualcomm.com> <1480949353.31788.27.camel@sipsolutions.net> <5e5e8971c96293a81e7cb37bcdfbd593@codeaurora.org> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: > > >  /** > > > + * wiphy_btcoex_support_flags > > > + * This enum has the driver supported frame types for > > > BTCOEX. > > > + * @WIPHY_WLAN_BE_PREFERRED - Supports Best Effort frame for > > > BTCOEX > > > + * @WIPHY_WLAN_BK_PREFERRED - supports Background frame for > > > BTCOEX > > > + * @WIPHY_WLAN_VI_PREFERRED - supports Video frame for BTCOEX > > > + * @WIPHY_WLAN_VO_PREFERRED - supports Voice frame for BTCOEX > > > + * @WIPHY_WLAN_BEACON_PREFERRED - supports Beacon frame for > > > BTCOEX > > > + * @WIPHY_WLAN_MGMT_PREFERRED - supports Management frames for > > > BTCOEX. > > > + */ > > > > That's not making much sense to me? > > > > is it fine to have as WIPHY_BTCOEX_BE_PREFERRED ? It's not really clear to me what you intend to do this - if it's really support flags then you really should name those better. > > > +/** > > > + * enum wiphy_btcoex_priority - BTCOEX priority level > > > + * This enum defines priority level for BTCOEX > > > + * WIPHY_WLAN_PREFERRED_LOW - low priority frames over BT > > > traffic > > > + * WIPHY_WLAN_PREFERRED_HIGH - high priority frames over BT > > > traffic > > > + */ > > > + > > > +enum wiphy_btcoex_priority { > > > + WIPHY_WLAN_PREFERRED_LOW = false, > > > + WIPHY_WLAN_PREFERRED_HIGH = true, > > > +}; > > > > That false/true seems just strange. > > > > I will just use as a enum without assigning false/true. What do you even need this enum for though? > > > +enum nl80211_btcoex_priority { > > > + __NL80211_WLAN_PREFERRED_INVALID, > > > + NL80211_WLAN_BE_PREFERRED, > > > + NL80211_WLAN_BK_PREFERRED, > > > + NL80211_WLAN_VI_PREFERRED, > > > + NL80211_WLAN_VO_PREFERRED, > > > + NL80211_WLAN_BEACON_PREFERRED, > > > + NL80211_WLAN_MGMT_PREFERRED, > > > + __NL80211_WLAN_PREFERRED_LAST, > > > + NL80211_WLAN_PREFERRED_MAX = > > > + __NL80211_WLAN_PREFERRED_LAST - 1, > > > +}; > > > > Wouldn't a bitmap be easier? > > > since this is to distinguish between different btcoex priorities and > we  > are not going to do any manipulations on these parameters. > It is just used as flag attribute. But why the (parsing) complexity, when a single bitmap would do? johannes