All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH V6 1/4] ixgbe: Fix issues with EEPROM access
Date: Tue, 13 Dec 2016 15:56:14 -0800	[thread overview]
Message-ID: <1481673374.2406.13.camel@intel.com> (raw)
In-Reply-To: <148166945619.47119.11718919548789509606.stgit@mdrustad-wks.jf.intel.com>

On Tue, 2016-12-13 at 14:50 -0800, Mark D Rustad wrote:
> There are two problems with EEPROM access. One is that it needs to
> hold the semaphore until the entire response is read or else the
> response can be corrupted by other firmware accesses. The second
> problem is that acquiring and releasing the semaphore is slow, so
> it should be taken and released once when multiple EEPROM accesses
> will be done.
> 
> Both of these issues can be solved by adding a new function,
> ixgbe_hic_unlocked, to issue firmware commands that will assume
> that the caller has acquired the needed semaphore.
> 
> Signed-off-by: Mark Rustad <mark.d.rustad@intel.com>
> ---
> ?drivers/net/ethernet/intel/ixgbe/ixgbe_common.c |?? 97 +++++++++++++++
> --------
> ?drivers/net/ethernet/intel/ixgbe/ixgbe_common.h |??? 1?
> ?drivers/net/ethernet/intel/ixgbe/ixgbe_x550.c?? |?? 75 +++++++--------
> ---
> ?3 files changed, 91 insertions(+), 82 deletions(-)

I am unable to apply the first patch of the series:

?Applying .apply/V6-1-4-ixgbe-Fix-issues-with-EEPROM-access.patch ...
Checking for changes in the working directory ... done
Importing patch "V6-1-4-ixgbe-Fix-issues-with-EEPROM-access.patch" ...
error: patch failed: drivers/net/ethernet/intel/ixgbe/ixgbe_common.h:114
error: drivers/net/ethernet/intel/ixgbe/ixgbe_common.h: patch does not
apply
stg import: Diff does not apply cleanly

Looks like, v7 is needed to update the patches so they will actually apply
to my next-queue tree (please make sure you are using my dev-queue branch).
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.osuosl.org/pipermail/intel-wired-lan/attachments/20161213/1d0b75ed/attachment.asc>

  reply	other threads:[~2016-12-13 23:56 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-13 22:50 [Intel-wired-lan] [PATCH V6 0/4] ixgbe: Firmware-controlled PHY enablement Mark D Rustad
2016-12-13 22:50 ` [Intel-wired-lan] [PATCH V6 1/4] ixgbe: Fix issues with EEPROM access Mark D Rustad
2016-12-13 23:56   ` Jeff Kirsher [this message]
2016-12-13 22:51 ` [Intel-wired-lan] [PATCH V6 2/4] ixgbe: Remove unused firmware version functions and method Mark D Rustad
2016-12-13 22:51 ` [Intel-wired-lan] [PATCH V6 3/4] ixgbe: Implement firmware interface to access some PHYs Mark D Rustad
2016-12-13 22:51 ` [Intel-wired-lan] [PATCH V6 4/4] ixgbe: Implement support for firmware-controlled PHYs Mark D Rustad

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1481673374.2406.13.camel@intel.com \
    --to=jeffrey.t.kirsher@intel.com \
    --cc=intel-wired-lan@osuosl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.