From mboxrd@z Thu Jan 1 00:00:00 1970 From: Srinivas Pandruvada Subject: Re: Issue in applying patch [hid-sensor-hub: clear memory to avoid random data] Date: Wed, 14 Dec 2016 12:42:50 -0800 Message-ID: <1481748170.6973.3.camel@linux.intel.com> References: <1480546127-3539-1-git-send-email-linux@rasmusvillemoes.dk> <1481740037.3319.3.camel@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Return-path: Received: from mga14.intel.com ([192.55.52.115]:56128 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752366AbcLNUnw (ORCPT ); Wed, 14 Dec 2016 15:43:52 -0500 In-Reply-To: Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Jiri Kosina Cc: Benjamin Tissoires , linux-input@vger.kernel.org On Wed, 2016-12-14 at 21:33 +0100, Jiri Kosina wrote: > On Wed, 14 Dec 2016, Srinivas Pandruvada wrote: > > > As per the comment here, it seems that you applied v4 version of > patch. > >  > > https://patchwork.kernel.org/patch/9428715/ > >  > > But when I look at the upstream kernel, the very first version of > the > > patch was applied, which was wrong. > >  > > Basically the change should be in sensor_hub_get_feature() not in > > sensor_hub_set_feature(). > > Otherwise it breaks sensor functionality. > >  > > How should we handle this? > > Hi Srinivas, > > my whole queue is now merged by Linus, so any fixups should be > submitted  > as standalone patches on top of current Linus' tree; I'll push the > fix to  > Linus then for 4.10 still. > > Ideally we also put proper "Fixes:" tag, so that it gets picked up > by  > 4.9-stable once/if there is one. > > Thanks, and sorry for my brainfart; I'll check my archives to see > what  > went wrong. No problem at all. Thanks, Srinivas