From: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
To: Corentin Labbe <clabbe.montjoie@gmail.com>,
jikos@kernel.org, benjamin.tissoires@redhat.com,
linux-input@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HID: intel-ish-hid: Remove unneeded linux/miscdevice.h include
Date: Thu, 15 Dec 2016 08:20:38 -0800 [thread overview]
Message-ID: <1481818838.1934.2.camel@linux.intel.com> (raw)
In-Reply-To: <20161215152711.9069-1-clabbe.montjoie@gmail.com>
On Thu, 2016-12-15 at 16:27 +0100, Corentin Labbe wrote:
> hid/intel-ish-hid does not use any miscdevice so this patch remove
> this unnecessary inclusion.
>
> Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> ---
> drivers/hid/intel-ish-hid/ipc/pci-ish.c | 1 -
> drivers/hid/intel-ish-hid/ishtp/hbm.c | 1 -
> drivers/hid/intel-ish-hid/ishtp/init.c | 1 -
> 3 files changed, 3 deletions(-)
>
> diff --git a/drivers/hid/intel-ish-hid/ipc/pci-ish.c
> b/drivers/hid/intel-ish-hid/ipc/pci-ish.c
> index 20d647d..d20da39 100644
> --- a/drivers/hid/intel-ish-hid/ipc/pci-ish.c
> +++ b/drivers/hid/intel-ish-hid/ipc/pci-ish.c
> @@ -24,7 +24,6 @@
> #include <linux/sched.h>
> #include <linux/interrupt.h>
> #include <linux/workqueue.h>
> -#include <linux/miscdevice.h>
> #define CREATE_TRACE_POINTS
> #include <trace/events/intel_ish.h>
> #include "ishtp-dev.h"
> diff --git a/drivers/hid/intel-ish-hid/ishtp/hbm.c
> b/drivers/hid/intel-ish-hid/ishtp/hbm.c
> index 59460b6..b721360 100644
> --- a/drivers/hid/intel-ish-hid/ishtp/hbm.c
> +++ b/drivers/hid/intel-ish-hid/ishtp/hbm.c
> @@ -19,7 +19,6 @@
> #include <linux/sched.h>
> #include <linux/wait.h>
> #include <linux/spinlock.h>
> -#include <linux/miscdevice.h>
> #include "ishtp-dev.h"
> #include "hbm.h"
> #include "client.h"
> diff --git a/drivers/hid/intel-ish-hid/ishtp/init.c
> b/drivers/hid/intel-ish-hid/ishtp/init.c
> index ac36441..d27e035 100644
> --- a/drivers/hid/intel-ish-hid/ishtp/init.c
> +++ b/drivers/hid/intel-ish-hid/ishtp/init.c
> @@ -16,7 +16,6 @@
> #include <linux/export.h>
> #include <linux/slab.h>
> #include <linux/sched.h>
> -#include <linux/miscdevice.h>
> #include "ishtp-dev.h"
> #include "hbm.h"
> #include "client.h"
next prev parent reply other threads:[~2016-12-15 16:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-15 15:27 [PATCH] HID: intel-ish-hid: Remove unneeded linux/miscdevice.h include Corentin Labbe
2016-12-15 16:20 ` Srinivas Pandruvada [this message]
2016-12-19 10:17 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1481818838.1934.2.camel@linux.intel.com \
--to=srinivas.pandruvada@linux.intel.com \
--cc=benjamin.tissoires@redhat.com \
--cc=clabbe.montjoie@gmail.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.