From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v2] xen: sched: removal of redundant check in Credit Date: Fri, 16 Dec 2016 01:55:17 +0100 Message-ID: <1481849717.3445.362.camel@citrix.com> References: <1481825355.5484.4.camel@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1944426413618978466==" Return-path: In-Reply-To: <1481825355.5484.4.camel@gmail.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Praveen Kumar , "xen-devel@lists.xen.org" Cc: "george.dunlap@eu.citrix.com" List-Id: xen-devel@lists.xenproject.org --===============1944426413618978466== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="=-WETwVeSiAQ2+v+gpRCgG" --=-WETwVeSiAQ2+v+gpRCgG Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2016-12-15 at 23:39 +0530, Praveen Kumar wrote: > The patch gets rid of a redundant check in csched_vcpu_acct. In fact, > the function is only called from csched_tick, which already checks > that current is not the idle vcpu. The patch also adds an ASSERT to > the same effect, in order to make assumption ( i.e., no calling this > on idle vcpus) even more clear and as a guard for future mis-use. >=20 > Signed-off-by: Praveen Kumar >=20 This is all good and can have my: Acked-by: Dario Faggioli _HOWEVER_ when I tried to apply the patch directly from this email I get this: (Stripping trailing CRs from patch; use --binary to disable.) checking file xen/common/sched_credit.c patch: **** malformed patch at line 6: unsigned int cpu) Which I think means that the patch has been corrupted, most likely by the email program. This is a common issue, and although it is possible to paste patches in an email client and teach it not to mangle them, I would say: =C2=A01) it's a very boring thing to do, it does not scale, it's not =C2=A0 =C2=A0 practical when sending patch series and it's not reliable; =C2=A02) I've only done a couple of times at the beginning of my OS=C2=A0 =C2=A0 =C2=A0 contribution history, and would not be able to help on how to= make=C2=A0 =C2=A0 =C2=A0 that happen. For this reason, I encourage you to look at and learn alternative ways=C2= =A0 of submitting patches, like git-send-email. Personally, I use StGit for development, and it has its own sending patches machinery too. I think you should send a v3, by using one of these methods (or, in general, not in a mangled state). When doing that (and if you don't change anything), you can stick my 'Acked-by:' tag right below your own 'Signed-off-by:' Thanks and Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-WETwVeSiAQ2+v+gpRCgG Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJYUzt1AAoJEBZCeImluHPuWdUQAOkWWnyKgisSVAjLEAPd+aWi YMBi01lzTw4/4TP0D/lH8ydPp+cihRCr1ZufI5N0obaoJv6h6wV4nQtJ3Z5Kft+b ukStu0TFRBMbYkho+bd65uRUdcTj7UMJKu+gEDPoaYq15+mMHpQEa79fAEKnkiXw IRu43/0pp3oKJc7yEA9WhCyjarzPsWQjZmlKb+bP7B7WQnJiuedivJe48jKTOE9/ dNojvJUzNnX/6EfOkKAx/AypnpGAIGDdRvEIyyl41lAt8DX/6SSQZ0Iux/v0rS0y FInt9kkFSpxyYyyZhQObNqORNWi1GsQCw+2EY5oidKEJdGP6AY4+PRthdofDz89o PYtvkZav+0GZq1xW3nfMwtPrZl7Jv16VeRjnx3Zzyn3nuFp2oRVXQ0JWRLzu8f/x 2oGL//079bWOx8IPYmS7+57dSUokRrglx2Sc8bLNZHFfbUnHl5ddafjVglYpsWGv DXZzCvKIifyOtUjGpTg6Fc8CFv3dCAx8PfJw/59JzRLDf81DpNVeOfLx0KJMSc7v xsvZ7LkyEmdzr3f/J5I9T0fMpkmsMgOoS3/q5QKPYMpPnP/kXXlASINo5IlT8qMc 8WXfSJvTDP7ePIXsXXfT7+KbMHGYAMtujUwTeGymYbMIay2WeeDR3lPfQURpohri VrqGwOsBUgCzr0sIbFIA =NPrg -----END PGP SIGNATURE----- --=-WETwVeSiAQ2+v+gpRCgG-- --===============1944426413618978466== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v cmcveGVuLWRldmVsCg== --===============1944426413618978466==--