From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from s3.sipsolutions.net ([5.9.151.49] helo=sipsolutions.net) by bombadil.infradead.org with esmtps (Exim 4.85_2 #1 (Red Hat Linux)) id 1cHoxJ-00047g-1d for ath10k@lists.infradead.org; Fri, 16 Dec 2016 09:37:34 +0000 Message-ID: <1481881024.27953.14.camel@sipsolutions.net> Subject: Re: [PATCH 2/4] cfg80211: Add new NL80211_CMD_SET_BTCOEX_PRIORITY to support BTCOEX From: Johannes Berg Date: Fri, 16 Dec 2016 10:37:04 +0100 In-Reply-To: <134cc8e58ecb804b6dda0137c4c37be8@codeaurora.org> References: <1478610932-21954-1-git-send-email-c_traja@qti.qualcomm.com> <1478610932-21954-3-git-send-email-c_traja@qti.qualcomm.com> <1480949353.31788.27.camel@sipsolutions.net> <5e5e8971c96293a81e7cb37bcdfbd593@codeaurora.org> <1481645351.20412.34.camel@sipsolutions.net> <134cc8e58ecb804b6dda0137c4c37be8@codeaurora.org> Mime-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Tamizh chelvam Cc: c_traja@qti.qualcomm.com, linux-wireless@vger.kernel.org, ath10k@lists.infradead.org PiA+ID4gaXMgaXQgZmluZSB0byBoYXZlIGFzIFdJUEhZX0JUQ09FWF9CRV9QUkVGRVJSRUQgPwo+ ID4gCj4gPiBJdCdzIG5vdCByZWFsbHkgY2xlYXIgdG8gbWUgd2hhdCB5b3UgaW50ZW5kIHRvIGRv IHRoaXMgLSBpZiBpdCdzCj4gPiByZWFsbHkgc3VwcG9ydCBmbGFncyB0aGVuIHlvdSByZWFsbHkg c2hvdWxkIG5hbWUgdGhvc2UgYmV0dGVyLgo+ID4gCj4gCj4gVGhpcyBpcyBzdXBwb3J0IGZsYWdz IGFuZCBpdCB1c2VkIGJ5IHRoZSBkcml2ZXIgdG8gaW50aW1hdGUgZHJpdmVywqAKPiBzdXBwb3J0 ZWQgZnJhbWUgdHlwZSBmb3IgdGhlIEJUQ09FWCB0byBjZmcgbGlrZQo+ICJ3aXBoeV93b3dsYW5f c3VwcG9ydF9mbGFncyIgaW1wbGVtZW50YXRpb24uIFBsZWFzZSBzdWdnZXN0IGlmIHRoaXMKPiBp cyBvayA/IEkgd2lsbCBiZSB0aGFua2Z1bCBpZiB5b3UgY2FuIHN1Z2dlc3QgYcKgIGJldHRlciBv bmUgaWYgdGhpcwo+IGlzIG5vdCBvayAiV0lQSFlfQlRDT0VYX1NVUFBPUlRTX0JFIgoKV2VsbCwg SSBzZWUgYSBmZXcgdGhpbmdzIGhlcmU6CgoxKSBkb2VzIGl0IGV2ZW4gbWFrZSBzZW5zZSB0byBz cGxpdCBpdCBvdXQgcGVyIEFDPyB3b3VsZG4ndCBpdCBiZSB3ZWlyZAppZiB5b3Ugc3VwcG9ydGVk IHRoaXMgb25seSBmb3IgVk8gYW5kIEJLLCBhbmQgbm90IHRoZSBvdGhlcnMsIG9yCnNvbWV0aGlu ZyBsaWtlIHRoYXQ/CgoyKSBXb3VsZG4ndCBpdCBtYWtlIG1vcmUgc2Vuc2UgdG8gZGVmaW5lIHRo aXMgaW4gbmw4MDIxMSBhbmQganVzdCBwYXNzCnRoZSBiaXRtYXAgdGhyb3VnaCB0byB1c2Vyc3Bh Y2U/IFRoYXQgd291bGQgc2F2ZSBxdWl0ZSBhIGJpdCBvZiBuZXRsaW5rCm1hbmdsaW5nIGNvbXBs ZXhpdHkuCgozKSBJIHRoaW5rIHRoZSBuYW1pbmcgaXMgY29uZnVzaW5nIC0gIldJUEhZX0JUQ09F WF9TVVBQT1JUU19CRV9QUkVGIiBvcgpzbyBtaWdodCBiZSBtb3JlIGFwcHJvcHJpYXRlPwoKPiBE byB5b3UgbWVhbiB0byBzYXksIHNlbmRpbmcgYSB2YWx1ZSBmcm9tIHVzZXIgc3BhY2UgYW5kIHBh cnNlIHRoYXQKPiBpbsKgIHRoZSBkcml2ZXI/CgpJIHdhcyBtb3JlIHRoaW5raW5nIG9mIHRoZSBj YXBhYmlsaXR5IGFkdmVydGlzZW1lbnQsIGJ1dCB5ZWFoLCBib3RoCndheXMgc2VlbXMgcmVhc29u YWJsZS4KCmpvaGFubmVzCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fXwphdGgxMGsgbWFpbGluZyBsaXN0CmF0aDEwa0BsaXN0cy5pbmZyYWRlYWQub3JnCmh0 dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vYXRoMTBrCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from s3.sipsolutions.net ([5.9.151.49]:55330 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760122AbcLPJhJ (ORCPT ); Fri, 16 Dec 2016 04:37:09 -0500 Message-ID: <1481881024.27953.14.camel@sipsolutions.net> (sfid-20161216_103717_375905_C8CD7CFB) Subject: Re: [PATCH 2/4] cfg80211: Add new NL80211_CMD_SET_BTCOEX_PRIORITY to support BTCOEX From: Johannes Berg To: Tamizh chelvam Cc: c_traja@qti.qualcomm.com, linux-wireless@vger.kernel.org, ath10k@lists.infradead.org Date: Fri, 16 Dec 2016 10:37:04 +0100 In-Reply-To: <134cc8e58ecb804b6dda0137c4c37be8@codeaurora.org> References: <1478610932-21954-1-git-send-email-c_traja@qti.qualcomm.com> <1478610932-21954-3-git-send-email-c_traja@qti.qualcomm.com> <1480949353.31788.27.camel@sipsolutions.net> <5e5e8971c96293a81e7cb37bcdfbd593@codeaurora.org> <1481645351.20412.34.camel@sipsolutions.net> <134cc8e58ecb804b6dda0137c4c37be8@codeaurora.org> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: > > > is it fine to have as WIPHY_BTCOEX_BE_PREFERRED ? > > > > It's not really clear to me what you intend to do this - if it's > > really support flags then you really should name those better. > > > > This is support flags and it used by the driver to intimate driver  > supported frame type for the BTCOEX to cfg like > "wiphy_wowlan_support_flags" implementation. Please suggest if this > is ok ? I will be thankful if you can suggest a  better one if this > is not ok "WIPHY_BTCOEX_SUPPORTS_BE" Well, I see a few things here: 1) does it even make sense to split it out per AC? wouldn't it be weird if you supported this only for VO and BK, and not the others, or something like that? 2) Wouldn't it make more sense to define this in nl80211 and just pass the bitmap through to userspace? That would save quite a bit of netlink mangling complexity. 3) I think the naming is confusing - "WIPHY_BTCOEX_SUPPORTS_BE_PREF" or so might be more appropriate? > Do you mean to say, sending a value from user space and parse that > in  the driver? I was more thinking of the capability advertisement, but yeah, both ways seems reasonable. johannes