From: Joe Perches <joe@perches.com>
To: Tabrez khan <khan.tabrez21@gmail.com>,
andreas.dilger@intel.com, jsimmons@infradead.org
Cc: gregkh@linuxfoundation.org, lustre-devel@lists.lustre.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: [lustre-devel] [PATCH] staging : lustre : Remove braces from single-line body.
Date: Fri, 16 Dec 2016 08:05:53 -0800 [thread overview]
Message-ID: <1481904353.29291.87.camel@perches.com> (raw)
In-Reply-To: <1481898571-16842-1-git-send-email-khan.tabrez21@gmail.com>
On Fri, 2016-12-16 at 19:59 +0530, Tabrez khan wrote:
> Remove unnecessary braces {} for single while statement.
Your patch is fine Tabrez, but to the lustre folk:
> diff --git a/drivers/staging/lustre/lustre/obdclass/cl_io.c b/drivers/staging/lustre/lustre/obdclass/cl_io.c
[]
> @@ -1371,9 +1371,9 @@ int cl_sync_io_wait(const struct lu_env *env, struct cl_sync_io *anchor,
LASSERT(atomic_read(&anchor->csi_sync_nr) == 0);
/* wait until cl_sync_io_note() has done wakeup */
- while (unlikely(atomic_read(&anchor->csi_barrier) != 0)) {
+ while (unlikely(atomic_read(&anchor->csi_barrier) != 0))
cpu_relax();
- }
+
What if the wakeup never occurs/succeeds?
Should there be a timeout?
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: Tabrez khan <khan.tabrez21@gmail.com>,
andreas.dilger@intel.com, jsimmons@infradead.org
Cc: gregkh@linuxfoundation.org, lustre-devel@lists.lustre.org,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging : lustre : Remove braces from single-line body.
Date: Fri, 16 Dec 2016 08:05:53 -0800 [thread overview]
Message-ID: <1481904353.29291.87.camel@perches.com> (raw)
In-Reply-To: <1481898571-16842-1-git-send-email-khan.tabrez21@gmail.com>
On Fri, 2016-12-16 at 19:59 +0530, Tabrez khan wrote:
> Remove unnecessary braces {} for single while statement.
Your patch is fine Tabrez, but to the lustre folk:
> diff --git a/drivers/staging/lustre/lustre/obdclass/cl_io.c b/drivers/staging/lustre/lustre/obdclass/cl_io.c
[]
> @@ -1371,9 +1371,9 @@ int cl_sync_io_wait(const struct lu_env *env, struct cl_sync_io *anchor,
LASSERT(atomic_read(&anchor->csi_sync_nr) == 0);
/* wait until cl_sync_io_note() has done wakeup */
- while (unlikely(atomic_read(&anchor->csi_barrier) != 0)) {
+ while (unlikely(atomic_read(&anchor->csi_barrier) != 0))
cpu_relax();
- }
+
What if the wakeup never occurs/succeeds?
Should there be a timeout?
next prev parent reply other threads:[~2016-12-16 16:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-16 14:29 [lustre-devel] [PATCH] staging : lustre : Remove braces from single-line body Tabrez khan
2016-12-16 14:29 ` Tabrez khan
2016-12-16 16:05 ` Joe Perches [this message]
2016-12-16 16:05 ` Joe Perches
2016-12-16 17:23 ` [lustre-devel] " Xiong, Jinshan
2016-12-16 17:23 ` Xiong, Jinshan
-- strict thread matches above, loose matches on Subject: below --
2016-12-16 17:59 Tabrez khan
2016-12-16 18:43 ` Joe Perches
2016-12-16 18:53 ` Dan Carpenter
2016-12-16 19:19 ` Joe Perches
2016-12-28 14:10 Tabrez khan
2017-01-03 14:15 ` Greg KH
2016-12-29 20:02 [lustre-devel] [PATCH] staging:lustre:remove " Tabrez khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1481904353.29291.87.camel@perches.com \
--to=joe@perches.com \
--cc=andreas.dilger@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jsimmons@infradead.org \
--cc=khan.tabrez21@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lustre-devel@lists.lustre.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.