Re: [PATCH 03/14 V2] rtlwifi: rtl8821ae: Remove all instances of DBG_EMERG

[Joe Perches <joe@perches.com>]

On Thu, 2016-12-15 at 12:22 -0600, Larry Finger wrote:
> This is a step toward eliminating the RT_TRACE macros. Those calls that
> have DBG_EMERG as the level are always logged, and they represent error
> conditions, thus they are replaced with pr_err().

OK,

> diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/fw.c b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/fw.c
[]
> @@ -162,8 +161,8 @@ static int _rtl8821ae_fw_free_to_go(struct ieee80211_hw *hw)
>  		goto exit;
>  	}
>  
> -	RT_TRACE(rtlpriv, COMP_FW, DBG_EMERG,
> -		 "Checksum report OK ! REG_MCUFWDL:0x%08x .\n", value32);
> +	pr_err("Checksum report OK! REG_MCUFWDL:0x%08x\n",
> +	       value32);
>  
>  	value32 = rtl_read_dword(rtlpriv, REG_MCUFWDL);
>  	value32 |= MCUFWDL_RDY;
> @@ -186,9 +184,8 @@ static int _rtl8821ae_fw_free_to_go(struct ieee80211_hw *hw)
>  		udelay(FW_8821AE_POLLING_DELAY);
>  	} while (counter++ < FW_8821AE_POLLING_TIMEOUT_COUNT);
>  
> -	RT_TRACE(rtlpriv, COMP_ERR, DBG_EMERG,
> -		 "Polling FW ready fail!! REG_MCUFWDL:0x%08x .\n",
> -		 value32);
> +	pr_err("Polling FW ready fail!! REG_MCUFWDL:0x%08x .\n",
> +	       value32);

It's odd to fix / remove " .\n" above but here and
the wrapping comment on the first patch applies too.

I didn't look at the rest and I won't comment on
other uses in any further patches in the series.

Thanks,  Joe