From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dario Faggioli Subject: Re: [PATCH v3] xen: sched: removal of redundant check in Credit Date: Sat, 17 Dec 2016 02:46:28 +0100 Message-ID: <1481939188.3445.473.camel@citrix.com> References: <1481916226-19177-1-git-send-email-kpraveen.lkml@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============7498079612386421972==" Return-path: In-Reply-To: <1481916226-19177-1-git-send-email-kpraveen.lkml@gmail.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Praveen Kumar , xen-devel@lists.xen.org Cc: george.dunlap@eu.citrix.com List-Id: xen-devel@lists.xenproject.org --===============7498079612386421972== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="=-N56Mw9Javmd2RNYtk+HT" --=-N56Mw9Javmd2RNYtk+HT Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, 2016-12-17 at 00:53 +0530, Praveen Kumar wrote: > The patch gets rid of a redundant check in csched_vcpu_acct. In fact, > the function is only called from csched_tick, which already checks > that current is not the idle vcpu. The patch also adds an ASSERT to > the same effect, in order to make assumption ( i.e., no calling this > on idle vcpus) even more clear and as a guard for future mis-use. >=20 > Signed-off-by: Praveen Kumar > Acked-by: Dario Faggioli > Better than before. But still, if I: =C2=A0- save this mail as mbox =C2=A0- try to import it in git it fails. OTOH, if I: =C2=A0- save this mail as mbox =C2=A0- run dos2unix on the mbox file =C2=A0- try to import it in git it works! Which, since you're now using git-send-email, makes me think it may be your editor/OS which is at fault and inserts spurious stuff at line breaks (the classic CR vs. CR+LF thing). What editor on what OS are you using? Another possibility is that there is something wrong here at my hand. George, do you have (similar) issues when trying to apply this patch? Regards, Dario --=20 <> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) --=-N56Mw9Javmd2RNYtk+HT Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAABCAAGBQJYVJj1AAoJEBZCeImluHPuyhEQAKRaAIEXDDoIKpLO+nbznJXj XjI4X81vTMxCs6JCzamcHejYuZ9AItlByKFawOogsJe7Ik4PHMQGw9sq13MJvRon 0BLuJCRVte8/zKplJnl/cA0uxxOJI9em/hve8RtDzxbXHCe/KRe8TLEKB+GOnZ0r fSXLFXyzdjkBl4V1UhPll0IBLRL2bY5osOmAqiT1N8VRqhKPB6QltMMcUs79twz7 xaoX9JAH1RvUIJ4zXBf85GW34L4rGs9FiG5qD0Mnwl3GFaYGS38UNxRxO02dsdcb IBFCxY0vV0C/OE2Ghr+yCRwrEIKhqHKP/S+aF+9hP5yktHvl2pwPZQId5zIDQAkE slCCX1U8ZQhqghiVPqJJ2sDPtz0DNQeoE+vF8I9hNBOVugfoPOyEfBC6nqV0SzXX hR6Qbj7htkMUyfdHAdpifqT3n2T9pHnWQM7hICvtG9VO26XPcfaoDnmams+fbE8i k2kB2qu2pGARzqyaco/hAaY04Vidui2QdaVtuhS/eyPHsTU2QNWimBn9gh4oPC7a NpDVlo8/ItAp2MRZ/agWspd6gNQd3RD4XSqOOkS6KjLqFR7SAgA3fq3g+MOxk8Kq NfuGH8FRAsdEwnoqoQcA5oxZrHX9Ho43cNJ3eCU0oQ6P+yICuGpEzW4GSHd/C45P pT/FKIbPsxakab2zlQtN =4PY+ -----END PGP SIGNATURE----- --=-N56Mw9Javmd2RNYtk+HT-- --===============7498079612386421972== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v cmcveGVuLWRldmVsCg== --===============7498079612386421972==--