All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: "Михаил Кринкин" <krinkin.m.u@gmail.com>,
	kernel@kempniu.pl, linux-wireless@vger.kernel.org,
	davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: "rfkill: Add rfkill-any LED trigger" causes deadlock
Date: Mon, 19 Dec 2016 09:56:12 +0100	[thread overview]
Message-ID: <1482137772.31461.1.camel@sipsolutions.net> (raw)
In-Reply-To: <CACpa5=_chGuU3zVcVR3nkNySwz1cGAQTs39v+BjwcDNSvOqhTw@mail.gmail.com> (sfid-20161216_175504_934691_38742608)

Hi Mike,

Thanks for the report. I'm sorry I missed this in review - obviously we
can't call something that acquires the mutex from rfkill_set_sw_state()
which clearly states, in the documentation:

 * This function can be called in any context, even from within rfkill
 * callbacks.

I've reverted the change (and the follow-up fix) now.

Michał, if you want to resubmit with this fixed, please also make sure
you don't reintroduce the unused label warning and have the appropriate
#ifdef that Arnd had later added for your change.

Thanks,
johannes

  parent reply	other threads:[~2016-12-19  8:56 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20161216163707.GA2629@gmail.com>
2016-12-16 16:46 ` "rfkill: Add rfkill-any LED trigger" causes deadlock Михаил Кринкин
2016-12-16 17:09   ` Mike Krinkin
2016-12-16 17:09     ` Mike Krinkin
2016-12-19  8:56   ` Johannes Berg [this message]
2016-12-19 14:01     ` Michał Kępień
2016-12-20  7:47       ` Johannes Berg
2016-12-20  7:47         ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1482137772.31461.1.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=davem@davemloft.net \
    --cc=kernel@kempniu.pl \
    --cc=krinkin.m.u@gmail.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.