All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrea Bolognani <abologna@redhat.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: paulus@samba.org, sjitindarsingh@gmail.com, lvivier@redhat.com,
	thuth@redhat.com, mdroth@linux.vnet.ibm.com, qemu-ppc@nongnu.org,
	qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [Qemu-ppc] [PATCHv3 for-2.9 0/6] HPT resizing for pseries guests (qemu part)
Date: Tue, 20 Dec 2016 10:19:21 +0100	[thread overview]
Message-ID: <1482225561.3732.12.camel@redhat.com> (raw)
In-Reply-To: <20161219234717.GG23176@umbus.fritz.box>

On Tue, 2016-12-20 at 10:47 +1100, David Gibson wrote:
> > Do we want to expose a knob for controlling this
> > to the user at the libvirt level, or should we just enable
> > resize-hpt unconditionally whenever we detect that the QEMU
> > binary supports it?
> 
> I'm not sure if we need a knob.  I think in general enabling for
> pseries-2.9 and later machine types is correct.  The difficulty is
> that for HV guests, we can only enable it if the host kernel also has
> support.  Explicitly setting "resize-hpt=enable" means qemu will not
> start if the kernel doesn't support it.

I thought that would be the case for resize-hpt=required,
not resized-hpt=enabled.

> My inclination would be to enable unconditionally for pseries-2.9 and
> later machine types.

So I guess the question is, will users want to enable this
manually for older machine types, or is it reasonable to
expect them to simply switch to pseries-2.9 if they want
the feature?

Moreover, do you foresee any situation in which users
might reasonably want to turn the feature off even though
the entire stack (host kernel, QEMU, guest kernel)
understands it?

-- 
Andrea Bolognani / Red Hat / Virtualization

       reply	other threads:[~2016-12-20  9:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20161215061128.30792-1-david@gibson.dropbear.id.au>
     [not found] ` <1482160529.3732.2.camel@redhat.com>
     [not found]   ` <20161219234717.GG23176@umbus.fritz.box>
2016-12-20  9:19     ` Andrea Bolognani [this message]
2016-12-21  4:52       ` [Qemu-devel] [Qemu-ppc] [PATCHv3 for-2.9 0/6] HPT resizing for pseries guests (qemu part) David Gibson
2016-12-21  8:38         ` Andrea Bolognani
2016-12-21 22:43           ` David Gibson
2016-12-22  8:36             ` Andrea Bolognani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1482225561.3732.12.camel@redhat.com \
    --to=abologna@redhat.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=lvivier@redhat.com \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=paulus@samba.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=sjitindarsingh@gmail.com \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.