All of lore.kernel.org
 help / color / mirror / Atom feed
From: Liam Girdwood <liam.r.girdwood@linux.intel.com>
To: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Cc: "tiwai@suse.de" <tiwai@suse.de>,
	"Lin, Mengdong" <mengdong.lin@intel.com>,
	"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
	"mengdong.lin" <mengdong.lin@linux.intel.com>
Subject: Re: [PATCH][alsa-lib] topology: fix unused-const-variable warning
Date: Fri, 23 Dec 2016 15:23:46 +0000	[thread overview]
Message-ID: <1482506626.24233.71.camel@loki> (raw)
In-Reply-To: <fd274637-f92f-b4aa-0f48-13e844ce9721@sakamocchi.jp>

On Sat, 2016-12-24 at 00:08 +0900, Takashi Sakamoto wrote:
> On 2016年12月23日 23:48, Lin, Mengdong wrote:
> >> -----Original Message-----
> >> From: alsa-devel-bounces@alsa-project.org [mailto:alsa-devel-
> >> bounces@alsa-project.org] On Behalf Of Liam Girdwood
> >> Sent: Friday, December 23, 2016 4:49 PM
> >>
> >> This looks fine by me, Mengdong is this still unused or is it needed by a
> >> future patch ?
> >
> > Hi Liam,
> >
> > This "widget_control_map" is still unused now.
> >
> > Could you remember why we define this map in the early phase?
> > I guess previously we want to distinguish stand-alone controls from controls embedded in widgets. But now we process them in the same way, both in user space and kernel.
> >
> > So I feel we can remove this structure.
> 
> Additionally, would you check this post to fix some warnings which you 
> added into alsa-lib, please.
> [alsa-devel] [PATCH][alsa-lib] topology: fix sign-compare warning 
> introduced to set_link_hw_config() and tplg_add_link_object()
> http://mailman.alsa-project.org/pipermail/alsa-devel/2016-December/115896.html
> 
> 

Both look good to me. Apologies that I missed them.

You may want to resend them both with my Ack (maybe wait for until after
Christmas though).

Thanks

Liam

> Thanks
> 
> Takashi Sakamoto


_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

  reply	other threads:[~2016-12-23 15:24 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-29 15:44 [PATCH][alsa-lib] topology: fix unused-const-variable warning Takashi Sakamoto
2016-12-17  0:39 ` Takashi Sakamoto
2016-12-23  8:49   ` Liam Girdwood
2016-12-23 14:48     ` Lin, Mengdong
2016-12-23 15:08       ` Takashi Sakamoto
2016-12-23 15:23         ` Liam Girdwood [this message]
2016-12-23 15:34           ` Takashi Sakamoto
2016-12-27  9:57             ` Lin, Mengdong
2017-01-02 14:22             ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1482506626.24233.71.camel@loki \
    --to=liam.r.girdwood@linux.intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=mengdong.lin@intel.com \
    --cc=mengdong.lin@linux.intel.com \
    --cc=o-takashi@sakamocchi.jp \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.