From: Joe Perches <joe@perches.com>
To: Rahul Krishnan <mrahul.krishnan@gmail.com>, bhelgaas@google.com
Cc: mpe@ellerman.id.au, mika.westerberg@linux.intel.com,
gwshan@linux.vnet.ibm.com, mayurkumar.patel@intel.com,
keith.busch@intel.com, julia.lawall@lip6.fr,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] pci: hotplug: This patch removes unnecessary return statement using spatch tool
Date: Fri, 23 Dec 2016 23:49:40 -0800 [thread overview]
Message-ID: <1482565780.1928.1.camel@perches.com> (raw)
In-Reply-To: <20161224073307.GA18826@rahul>
On Sat, 2016-12-24 at 13:03 +0530, Rahul Krishnan wrote:
> This patch removes unnecessary return statement using spatch tool
[]
> diff --git a/drivers/pci/hotplug/rpadlpar_core.c b/drivers/pci/hotplug/rpadlpar_core.c
[]
> @@ -463,8 +463,7 @@ int __init rpadlpar_io_init(void)
> return -EPERM;
> }
>
> - rc = dlpar_sysfs_init();
> - return rc;
> + return dlpar_sysfs_init();
> }
>
> void rpadlpar_io_exit(void)
If you are going to submit these types
of patches, please make sure you compile
test them before sending so that you can
look at new warnings.
Now rc is unused and its declaration
should be removed.
prev parent reply other threads:[~2016-12-24 7:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-24 7:33 [PATCH] pci: hotplug: This patch removes unnecessary return statement using spatch tool Rahul Krishnan
2016-12-24 7:49 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1482565780.1928.1.camel@perches.com \
--to=joe@perches.com \
--cc=bhelgaas@google.com \
--cc=gwshan@linux.vnet.ibm.com \
--cc=julia.lawall@lip6.fr \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mayurkumar.patel@intel.com \
--cc=mika.westerberg@linux.intel.com \
--cc=mpe@ellerman.id.au \
--cc=mrahul.krishnan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.