From: Rik van Riel <riel@redhat.com>
To: Frederic Weisbecker <fweisbec@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
James Hartsock <hartsjc@redhat.com>,
Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH] nohz: Fix collision between tick and other hrtimers
Date: Sun, 25 Dec 2016 21:56:57 -0500 [thread overview]
Message-ID: <1482721017.11006.83.camel@redhat.com> (raw)
In-Reply-To: <1482596100-16494-1-git-send-email-fweisbec@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 642 bytes --]
On Sat, 2016-12-24 at 17:15 +0100, Frederic Weisbecker wrote:
> When the tick is stopped and an interrupt occurs afterward, we check
> on
> that interrupt exit if the next tick needs to be rescheduled. If it
> doesn't need any update, we don't want to do anything.
>
> In order to check if the tick needs an update, we compare it against
> the
> clockevent device deadline. Now that's a problem because the
> clockevent
> device is at a lower level than the tick itself if it is implemented
> on top of hrtimer.
Ohhhhh, good find. That is one subtle bug.
Acked-by: Rik van Riel <riel@redhat.com>
--
All Rights Reversed.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-12-26 2:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-24 16:15 [PATCH] nohz: Fix collision between tick and other hrtimers Frederic Weisbecker
2016-12-26 2:56 ` Rik van Riel [this message]
2016-12-26 16:40 ` Frederic Weisbecker
2016-12-26 23:44 ` Wanpeng Li
2016-12-29 16:42 ` Thomas Gleixner
2016-12-29 16:53 ` Frederic Weisbecker
-- strict thread matches above, loose matches on Subject: below --
2017-02-10 15:27 Lucas Stach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1482721017.11006.83.camel@redhat.com \
--to=riel@redhat.com \
--cc=fweisbec@gmail.com \
--cc=hartsjc@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.