All of lore.kernel.org
 help / color / mirror / Atom feed
From: Szymon Janc <szymon.janc@codecoup.pl>
To: Juha Kuikka <juha.kuikka@synapse.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 3/3] sixaxis: Set created devices trusted by default
Date: Wed, 28 Dec 2016 17:07:12 +0100	[thread overview]
Message-ID: <148295789.8zPOI8aDb3@ix> (raw)
In-Reply-To: <1482384054-59718-4-git-send-email-juha.kuikka@synapse.com>

Hi Juha,

On Wednesday, 21 December 2016 21:20:54 CET Juha Kuikka wrote:
> If user has enabled the sixaxis plugin and plugs a controller in,
> it can be assumed they also want the controllers to be able to connect
> automatically.
> ---
>  plugins/sixaxis.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/plugins/sixaxis.c b/plugins/sixaxis.c
> index 1fb2091..ba96b54 100644
> --- a/plugins/sixaxis.c
> +++ b/plugins/sixaxis.c
> @@ -349,6 +349,7 @@ static bool setup_device(int fd, int index, struct
> btd_adapter *adapter) btd_device_set_pnpid(device, devices[index].source,
> devices[index].vid, devices[index].pid, devices[index].version);
>  	btd_device_set_temporary(device, false);
> +	btd_device_set_trusted(device, true);
> 
>  	return true;
>  }

This was already NACKed in the past for security reasons (mostly due to 
possibility of fake device being trusted).


-- 
pozdrawiam
Szymon Janc

  reply	other threads:[~2016-12-28 16:07 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-22  5:20 [PATCH 0/3] Dualshock4 controller enhancements Juha Kuikka
2016-12-22  5:20 ` [PATCH 1/3] Add new DS4 controller PID into special case handler Juha Kuikka
2016-12-28 16:06   ` Szymon Janc
2016-12-22  5:20 ` [PATCH 2/3] sixaxis: Add support for pairing DS4 over USB Juha Kuikka
2016-12-22 10:24   ` Antonio Ospite
2016-12-22 17:29     ` Juha Kuikka
2016-12-28 16:14   ` Szymon Janc
2016-12-22  5:20 ` [PATCH 3/3] sixaxis: Set created devices trusted by default Juha Kuikka
2016-12-28 16:07   ` Szymon Janc [this message]
2016-12-28 16:25     ` Bastien Nocera

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=148295789.8zPOI8aDb3@ix \
    --to=szymon.janc@codecoup.pl \
    --cc=juha.kuikka@synapse.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.