All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bart Van Assche <Bart.VanAssche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
To: "maxg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org"
	<maxg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>,
	"bvanassche-HInyCGIudOg@public.gmane.org"
	<bvanassche-HInyCGIudOg@public.gmane.org>,
	"linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
	<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org"
	<dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: "israelr-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org"
	<israelr-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Subject: Re: [PATCH 0/2 v2] srp/srpt - some useful patches
Date: Mon, 2 Jan 2017 09:02:32 +0000	[thread overview]
Message-ID: <1483347736.3592.10.camel@sandisk.com> (raw)
In-Reply-To: <1483280232-13826-1-git-send-email-maxg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 835 bytes --]

On Sun, 2017-01-01 at 16:17 +0200, Max Gurtovoy wrote:
> No bug fixes, but few improvements that might help.

Hello Max,

These patches are not useful to anyone so please drop these patches. More in
detail:
- Linux kernel patches should either be useful to Linux users or make the job
  of kernel maintainers easier. Your patches realize neither of these goals.
- You write that using kmalloc() / kfree() may increase memory fragmentation
  compared to stack allocation. I do not agree with this. And even if your
  claim would be correct, this shouldn't be fixed by modifying the SRP
  initiator and target drivers but this should be fixed by modifying the slab
  allocators.

Bart.

N‹§²æìr¸›yúèšØb²X¬¶Ç§vØ^–)Þº{.nÇ+‰·¥Š{±­ÙšŠ{ayº\x1dʇڙë,j\a­¢f£¢·hš‹»öì\x17/oSc¾™Ú³9˜uÀ¦æå‰È&jw¨®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿïêäz¹Þ–Šàþf£¢·hšˆ§~ˆmš

  parent reply	other threads:[~2017-01-02  9:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-01 14:17 [PATCH 0/2 v2] srp/srpt - some useful patches Max Gurtovoy
     [not found] ` <1483280232-13826-1-git-send-email-maxg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2017-01-01 14:17   ` [PATCH 1/2 v2] IB/srp: allocate ib_qp_attr on the stack Max Gurtovoy
2017-01-01 14:17   ` [PATCH 2/2 v2] IB/srpt: " Max Gurtovoy
2017-01-02  9:02   ` Bart Van Assche [this message]
     [not found]     ` <1483347736.3592.10.camel-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
2017-01-02 13:14       ` [PATCH 0/2 v2] srp/srpt - some useful patches Max Gurtovoy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1483347736.3592.10.camel@sandisk.com \
    --to=bart.vanassche-xdaiopvojttbdgjk7y7tuq@public.gmane.org \
    --cc=bvanassche-HInyCGIudOg@public.gmane.org \
    --cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
    --cc=israelr-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=maxg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.