From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from s3.sipsolutions.net ([5.9.151.49] helo=sipsolutions.net) by bombadil.infradead.org with esmtps (Exim 4.85_2 #1 (Red Hat Linux)) id 1cO0B6-0004wV-6z for ath10k@lists.infradead.org; Mon, 02 Jan 2017 10:49:21 +0000 Message-ID: <1483354130.4596.5.camel@sipsolutions.net> Subject: Re: [PATCH 2/4] cfg80211: Add new NL80211_CMD_SET_BTCOEX_PRIORITY to support BTCOEX From: Johannes Berg Date: Mon, 02 Jan 2017 11:48:50 +0100 In-Reply-To: References: <1478610932-21954-1-git-send-email-c_traja@qti.qualcomm.com> <1478610932-21954-3-git-send-email-c_traja@qti.qualcomm.com> <1480949353.31788.27.camel@sipsolutions.net> <5e5e8971c96293a81e7cb37bcdfbd593@codeaurora.org> <1481645351.20412.34.camel@sipsolutions.net> <134cc8e58ecb804b6dda0137c4c37be8@codeaurora.org> <1481881024.27953.14.camel@sipsolutions.net> Mime-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "ath10k" Errors-To: ath10k-bounces+kvalo=adurom.com@lists.infradead.org To: Tamizh chelvam Cc: c_traja@qti.qualcomm.com, linux-wireless@vger.kernel.org, ath10k@lists.infradead.org Cj4gPiAxKSBkb2VzIGl0IGV2ZW4gbWFrZSBzZW5zZSB0byBzcGxpdCBpdCBvdXQgcGVyIEFDPyB3 b3VsZG4ndCBpdCBiZQo+ID4gd2VpcmQKPiA+IGlmIHlvdSBzdXBwb3J0ZWQgdGhpcyBvbmx5IGZv ciBWTyBhbmQgQkssIGFuZCBub3QgdGhlIG90aGVycywgb3IKPiA+IHNvbWV0aGluZyBsaWtlIHRo YXQ/Cj4gPiAKPiAKPiBJdCBoYXMgc3VwcG9ydCBmb3IgQkUsIFZJLCBtYW5hZ2VtZW50IGFuZCBi ZWFjb24gZnJhbWVzIGFsc28uCj4gT3IgZG8geW91IG1lYW50IHRvIHNheSBsaWtlIHN1cHBvcnQg b25seSBmb3IgVk8gYW5kIEJLPwoKSSBtZWFuIC0gZG9lcyBpdCBtYWtlIHNlbnNlIGZvciBhIHBp ZWNlIG9mIGhhcmR3YXJlIHRvIHN1cHBvcnQgb25seQpWTy9CSywgd2l0aG91dCB0aGUgb3RoZXJz PyBJIGRvbid0IHJlYWxseSBzZWUgaG93IHRoYXQgd291bGQgbWFrZQpzZW5zZSwgYnV0IG1heWJl IEknbSBtaXNzaW5nIHNvbWV0aGluZz8KCklPVyAtIHdoeSBoYXZlIGFsbCB0aGVzZSBiaXRzIHJh dGhlciB0aGFuIGp1c3Qgb25lPwoKPiA+IDIpIFdvdWxkbid0IGl0IG1ha2UgbW9yZSBzZW5zZSB0 byBkZWZpbmUgdGhpcyBpbiBubDgwMjExIGFuZCBqdXN0Cj4gPiBwYXNzIHRoZSBiaXRtYXAgdGhy b3VnaCB0byB1c2Vyc3BhY2U/IFRoYXQgd291bGQgc2F2ZSBxdWl0ZSBhIGJpdAo+ID4gb2YgbmV0 bGluayBtYW5nbGluZyBjb21wbGV4aXR5Lgo+ID4gCj4gCj4gUGxlYXNlIGxldCBtZSBrbm93IGlm IHRoZSBiZWxvdyBkZXNpZ24vdGhvdWdodCBpcyBmaW5lIHRvIHlvdS4KPiAKPiBpdyBwaHlYIHNl dCBidGNvZXhfcHJpb3JpdHkgPFt2aSwgdm8sIGJlLCBiaywgbWdtdCwgYmVhY29uXT4KClRoYXQg c2VlbXMgZmluZSwgYnV0IEkgZG9uJ3Qgc2VlIGhvdyB0aGUgaXcgY29tbWFuZCBsaW5lIGlzIHJl bGV2YW50IHRvCnRoZSBxdWVzdGlvbiBvZiB3aGV0aGVyIHdlIHBhc3MgZmxhZyBhdHRyaWJ1dGVz IG9yIGEgYml0bWFwPz8KCj4gQnkgdGhpcyBjb21tYW5kIHVzZXIgc2hvdWxkIGdpdmUgb25lIG9y IG1vcmUgdGhhbiBvbmUgZnJhbWUgdHlwZXMKPiBmb3LCoAo+IHRoaXMgYnRjb2V4IHByaW9yaXR5 LAo+IHdlIHdpbGwgcGFyc2UgdGhhdCBpbiAiaXciIGFuZCBzZW5kIGFzIGEgc2luZ2xlIGJpdG1h cChsZXNzIHRoYW4KPiAweDY0KcKgIHRvIHRoZSBkcml2ZXI/CgpSaWdodCwgYW5kIGFsc28gdG8g bmw4MDIxMS4gV2h5IG5vdD8KCmpvaGFubmVzCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fXwphdGgxMGsgbWFpbGluZyBsaXN0CmF0aDEwa0BsaXN0cy5pbmZy YWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vYXRo MTBrCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from s3.sipsolutions.net ([5.9.151.49]:37118 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751208AbdABKsz (ORCPT ); Mon, 2 Jan 2017 05:48:55 -0500 Message-ID: <1483354130.4596.5.camel@sipsolutions.net> (sfid-20170102_114858_400325_D219FCD7) Subject: Re: [PATCH 2/4] cfg80211: Add new NL80211_CMD_SET_BTCOEX_PRIORITY to support BTCOEX From: Johannes Berg To: Tamizh chelvam Cc: c_traja@qti.qualcomm.com, linux-wireless@vger.kernel.org, ath10k@lists.infradead.org Date: Mon, 02 Jan 2017 11:48:50 +0100 In-Reply-To: References: <1478610932-21954-1-git-send-email-c_traja@qti.qualcomm.com> <1478610932-21954-3-git-send-email-c_traja@qti.qualcomm.com> <1480949353.31788.27.camel@sipsolutions.net> <5e5e8971c96293a81e7cb37bcdfbd593@codeaurora.org> <1481645351.20412.34.camel@sipsolutions.net> <134cc8e58ecb804b6dda0137c4c37be8@codeaurora.org> <1481881024.27953.14.camel@sipsolutions.net> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: > > 1) does it even make sense to split it out per AC? wouldn't it be > > weird > > if you supported this only for VO and BK, and not the others, or > > something like that? > > > > It has support for BE, VI, management and beacon frames also. > Or do you meant to say like support only for VO and BK? I mean - does it make sense for a piece of hardware to support only VO/BK, without the others? I don't really see how that would make sense, but maybe I'm missing something? IOW - why have all these bits rather than just one? > > 2) Wouldn't it make more sense to define this in nl80211 and just > > pass the bitmap through to userspace? That would save quite a bit > > of netlink mangling complexity. > > > > Please let me know if the below design/thought is fine to you. > > iw phyX set btcoex_priority <[vi, vo, be, bk, mgmt, beacon]> That seems fine, but I don't see how the iw command line is relevant to the question of whether we pass flag attributes or a bitmap?? > By this command user should give one or more than one frame types > for  > this btcoex priority, > we will parse that in "iw" and send as a single bitmap(less than > 0x64)  to the driver? Right, and also to nl80211. Why not? johannes