All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: "Marc-André Lureau" <mlureau@redhat.com>
Cc: Li Qiang <liq3ea@gmail.com>,
	marcandre lureau <marcandre.lureau@redhat.com>,
	qemu-devel@nongnu.org, liqiang6-s@360.cn
Subject: Re: [Qemu-devel] [PATCH] virtio-gpu: fix memory leak in resource attach backing
Date: Tue, 03 Jan 2017 10:41:44 +0100	[thread overview]
Message-ID: <1483436504.24493.5.camel@redhat.com> (raw)
In-Reply-To: <1767808401.7524716.1483023445359.JavaMail.zimbra@redhat.com>

> > +    if (res->iov) {
> > +        cmd->error = VIRTIO_GPU_RESP_ERR_UNSPEC;
> > +        return;
> > +    }
> > +
> 
> I think I would rather return an error in the library for this case.

-ENOLIBRARY ;)

This is the 2d mode code, so virglrenderer isn't involved at all.

Added patch to the queue (and the 3d one too).

thanks,
  Gerd

      parent reply	other threads:[~2017-01-03  9:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-29  9:28 [Qemu-devel] [PATCH] virtio-gpu: fix memory leak in resource attach backing Li Qiang
2016-12-29 14:57 ` Marc-André Lureau
2016-12-30  6:13   ` Li Qiang
2017-01-03  9:41   ` Gerd Hoffmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1483436504.24493.5.camel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=liq3ea@gmail.com \
    --cc=liqiang6-s@360.cn \
    --cc=marcandre.lureau@redhat.com \
    --cc=mlureau@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.