Re: [Qemu-devel] [PATCH] vnc: track LED state separately

[Gerd Hoffmann <kraxel@redhat.com>]

On Fr, 2016-12-16 at 10:00 +0100, Pierre Ossman wrote:
> On 15/12/16 17:41, Gerd Hoffmann wrote:
> >>
> >> -    caps = ledstate & QEMU_CAPS_LOCK_LED ? 1 : 0;
> >> -    num  = ledstate & QEMU_NUM_LOCK_LED  ? 1 : 0;
> >> -    scr  = ledstate & QEMU_SCROLL_LOCK_LED ? 1 : 0;
> >> +    if (ledstate != vd->ledstate)
> >> +        return;
> >
> > Hmm?  Shouldn't that be (ledstate == vd->ledstate)?
> >
> 
> Right, sorry. Brain fart. :)

/me wonders how you've tested the patch ...

> Can you fix that up before commit or do you want a new patch?

Tried, but checkpatch found some more issues:

=== checkpatch complains ===
ERROR: braces {} are necessary for all arms of this statement
#71: FILE: ui/vnc.c:1691:
+    if (ledstate != vd->ledstate)
[...]

ERROR: braces {} are necessary for all arms of this statement
#106: FILE: ui/vnc.c:3159:
+    if (vd->lock_key_sync)
[...]

ERROR: braces {} are necessary for all arms of this statement
#115: FILE: ui/vnc.c:3728:
+    if (lock_key_sync)
[...]

total: 3 errors, 0 warnings, 125 lines checked

Please fix and resend.

thanks,
  Gerd

> 
> Regards