From: Scott Wood <oss-fOR+EgIDQEHk1uMJSBkQmQ@public.gmane.org>
To: Jia Hongtao <hongtao.jia-3arQi8VN3Tc@public.gmane.org>,
rui.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
edubezval-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
yuantian.tang-3arQi8VN3Tc@public.gmane.org,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org
Cc: linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 1/3] dt-bindings: Update QorIQ TMU thermal bindings
Date: Wed, 04 Jan 2017 04:37:54 -0600 [thread overview]
Message-ID: <1483526274.17813.1.camel@buserror.net> (raw)
In-Reply-To: <1483520271-3838-2-git-send-email-hongtao.jia-3arQi8VN3Tc@public.gmane.org>
On Wed, 2017-01-04 at 16:57 +0800, Jia Hongtao wrote:
> For different types of SoC the sensor id and endianness may vary.
> "#thermal-sensor-cells" is used to provide sensor id information.
> "little-endian" property is to tell the endianness of TMU.
>
> Signed-off-by: Jia Hongtao <hongtao.jia-3arQi8VN3Tc@public.gmane.org>
> Acked-by: Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
> ---
> Documentation/devicetree/bindings/thermal/qoriq-thermal.txt | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/thermal/qoriq-thermal.txt
> b/Documentation/devicetree/bindings/thermal/qoriq-thermal.txt
> index 66223d5..20ca4ef 100644
> --- a/Documentation/devicetree/bindings/thermal/qoriq-thermal.txt
> +++ b/Documentation/devicetree/bindings/thermal/qoriq-thermal.txt
> @@ -17,6 +17,12 @@ Required properties:
> calibration data, as specified by the SoC reference manual.
> The first cell of each pair is the value to be written to TTCFGR,
> and the second is the value to be written to TSCFGR.
> +- #thermal-sensor-cells : Must be 1. The sensor specifier is the monitoring
> + site ID, and represents the "n" in TRITSRn and TRATSRn.
I assume the driver will continue to work with existing device trees where
this information is absent? If so, ACK for the whole series.
-Scott
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Scott Wood <oss@buserror.net>
To: Jia Hongtao <hongtao.jia@nxp.com>,
rui.zhang@intel.com, edubezval@gmail.com, yuantian.tang@nxp.com,
robh+dt@kernel.org
Cc: linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: Update QorIQ TMU thermal bindings
Date: Wed, 04 Jan 2017 04:37:54 -0600 [thread overview]
Message-ID: <1483526274.17813.1.camel@buserror.net> (raw)
In-Reply-To: <1483520271-3838-2-git-send-email-hongtao.jia@nxp.com>
On Wed, 2017-01-04 at 16:57 +0800, Jia Hongtao wrote:
> For different types of SoC the sensor id and endianness may vary.
> "#thermal-sensor-cells" is used to provide sensor id information.
> "little-endian" property is to tell the endianness of TMU.
>
> Signed-off-by: Jia Hongtao <hongtao.jia@nxp.com>
> Acked-by: Rob Herring <robh@kernel.org>
> ---
> Documentation/devicetree/bindings/thermal/qoriq-thermal.txt | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/thermal/qoriq-thermal.txt
> b/Documentation/devicetree/bindings/thermal/qoriq-thermal.txt
> index 66223d5..20ca4ef 100644
> --- a/Documentation/devicetree/bindings/thermal/qoriq-thermal.txt
> +++ b/Documentation/devicetree/bindings/thermal/qoriq-thermal.txt
> @@ -17,6 +17,12 @@ Required properties:
> calibration data, as specified by the SoC reference manual.
> The first cell of each pair is the value to be written to TTCFGR,
> and the second is the value to be written to TSCFGR.
> +- #thermal-sensor-cells : Must be 1. The sensor specifier is the monitoring
> + site ID, and represents the "n" in TRITSRn and TRATSRn.
I assume the driver will continue to work with existing device trees where
this information is absent? If so, ACK for the whole series.
-Scott
next prev parent reply other threads:[~2017-01-04 10:37 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-04 8:57 [PATCH 0/3] QorIQ TMU bindings and device tree update Jia Hongtao
2017-01-04 8:57 ` Jia Hongtao
2017-01-04 8:57 ` [PATCH 1/3] dt-bindings: Update QorIQ TMU thermal bindings Jia Hongtao
2017-01-04 8:57 ` Jia Hongtao
[not found] ` <1483520271-3838-2-git-send-email-hongtao.jia-3arQi8VN3Tc@public.gmane.org>
2017-01-04 10:37 ` Scott Wood [this message]
2017-01-04 10:37 ` Scott Wood
2017-01-05 2:28 ` Troy Jia
2017-01-06 6:56 ` Y.T. Tang
2017-01-04 8:57 ` [PATCH 2/3] powerpc/mpc85xx: Update TMU device tree node for T1040/T1042 Jia Hongtao
2017-01-04 8:57 ` Jia Hongtao
2017-01-04 8:57 ` [PATCH 3/3] powerpc/mpc85xx: Update TMU device tree node for T1023/T1024 Jia Hongtao
2017-01-04 8:57 ` Jia Hongtao
2017-01-04 9:19 ` [PATCH 0/3] QorIQ TMU bindings and device tree update Y.T. Tang
2017-01-04 9:19 ` Y.T. Tang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1483526274.17813.1.camel@buserror.net \
--to=oss-for+egidqehk1umjsbkqmq@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=edubezval-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=hongtao.jia-3arQi8VN3Tc@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=rui.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
--cc=yuantian.tang-3arQi8VN3Tc@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.