From: Pablo Neira Ayuso <pablo@netfilter.org>
To: netfilter-devel@vger.kernel.org
Cc: davem@davemloft.net, netdev@vger.kernel.org
Subject: [PATCH 6/6] bridge: netfilter: Fix dropping packets that moving through bridge interface
Date: Thu, 5 Jan 2017 12:19:53 +0100 [thread overview]
Message-ID: <1483615193-2931-7-git-send-email-pablo@netfilter.org> (raw)
In-Reply-To: <1483615193-2931-1-git-send-email-pablo@netfilter.org>
From: Artur Molchanov <arturmolchanov@gmail.com>
Problem:
br_nf_pre_routing_finish() calls itself instead of
br_nf_pre_routing_finish_bridge(). Due to this bug reverse path filter drops
packets that go through bridge interface.
User impact:
Local docker containers with bridge network can not communicate with each
other.
Fixes: c5136b15ea36 ("netfilter: bridge: add and use br_nf_hook_thresh")
Signed-off-by: Artur Molchanov <artur.molchanov@synesis.ru>
Acked-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
---
net/bridge/br_netfilter_hooks.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/bridge/br_netfilter_hooks.c b/net/bridge/br_netfilter_hooks.c
index b12501a77f18..135cc8ab813c 100644
--- a/net/bridge/br_netfilter_hooks.c
+++ b/net/bridge/br_netfilter_hooks.c
@@ -399,7 +399,7 @@ static int br_nf_pre_routing_finish(struct net *net, struct sock *sk, struct sk_
br_nf_hook_thresh(NF_BR_PRE_ROUTING,
net, sk, skb, skb->dev,
NULL,
- br_nf_pre_routing_finish);
+ br_nf_pre_routing_finish_bridge);
return 0;
}
ether_addr_copy(eth_hdr(skb)->h_dest, dev->dev_addr);
--
2.1.4
next prev parent reply other threads:[~2017-01-05 11:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-05 11:19 [PATCH 0/6] Netfilter fixes for net Pablo Neira Ayuso
2017-01-05 11:19 ` [PATCH 1/6] netfilter: nft_quota: reset quota after dump Pablo Neira Ayuso
2017-01-05 11:19 ` [PATCH 2/6] netfilter: nft_queue: use raw_smp_processor_id() Pablo Neira Ayuso
2017-01-05 11:19 ` [PATCH 3/6] netfilter: nf_tables: fix oob access Pablo Neira Ayuso
2017-01-05 11:19 ` [PATCH 4/6] netfilter: nft_payload: mangle ckecksum if NFT_PAYLOAD_L4CSUM_PSEUDOHDR is set Pablo Neira Ayuso
2017-01-05 11:19 ` [PATCH 5/6] netfilter: ipt_CLUSTERIP: check duplicate config when initializing Pablo Neira Ayuso
2017-01-05 11:19 ` Pablo Neira Ayuso [this message]
2017-01-05 16:52 ` [PATCH 0/6] Netfilter fixes for net David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1483615193-2931-7-git-send-email-pablo@netfilter.org \
--to=pablo@netfilter.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.