From: nickcooper-zhangtonghao <nic@opencloud.tech>
To: dev@dpdk.org
Cc: nickcooper-zhangtonghao <nic@opencloud.tech>
Subject: [PATCH v2 5/5] vmxnet3: Avoid segfault caused by vmxnet3_dev_tx_queue_setup.
Date: Thu, 5 Jan 2017 04:01:49 -0800 [thread overview]
Message-ID: <1483617709-7088-5-git-send-email-nic@opencloud.tech> (raw)
In-Reply-To: <1483617709-7088-1-git-send-email-nic@opencloud.tech>
We should allocate Tx ring for max possible mumber of hardware descriptors.
If we config Tx queue with 2048 Tx queue size, and 4096 soon,
there will be segment fault.
Signed-off-by: nickcooper-zhangtonghao <nic@opencloud.tech>
---
drivers/net/vmxnet3/vmxnet3_rxtx.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/net/vmxnet3/vmxnet3_rxtx.c b/drivers/net/vmxnet3/vmxnet3_rxtx.c
index f00b3b9..5f35a2e 100644
--- a/drivers/net/vmxnet3/vmxnet3_rxtx.c
+++ b/drivers/net/vmxnet3/vmxnet3_rxtx.c
@@ -874,9 +874,10 @@
comp_ring->next2proc = 0;
comp_ring->gen = VMXNET3_INIT_GEN;
- size = sizeof(struct Vmxnet3_TxDesc) * ring->size;
- size += sizeof(struct Vmxnet3_TxCompDesc) * comp_ring->size;
- size += sizeof(struct Vmxnet3_TxDataDesc) * data_ring->size;
+ /* Allocate Tx ring for max possible number of hardware descriptors. */
+ size = sizeof(struct Vmxnet3_TxDesc) * VMXNET3_TX_RING_MAX_SIZE;
+ size += sizeof(struct Vmxnet3_TxCompDesc) * VMXNET3_TX_RING_MAX_SIZE;
+ size += sizeof(struct Vmxnet3_TxDataDesc) * VMXNET3_TX_RING_MAX_SIZE;
mz = ring_dma_zone_reserve(dev, "txdesc", queue_idx, size, socket_id);
if (mz == NULL) {
--
1.8.3.1
next prev parent reply other threads:[~2017-01-05 12:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-05 12:01 [PATCH v2 1/5] eal: Set numa node value for system which not support NUMA nickcooper-zhangtonghao
2017-01-05 12:01 ` [PATCH v2 2/5] vmxnet3: Avoid memory leak in vmxnet3_dev_rx_queue_setup nickcooper-zhangtonghao
2017-01-05 12:01 ` [PATCH v2 3/5] vmxnet3: Avoid segfault caused by vmxnet3_dev_rx_queue_setup nickcooper-zhangtonghao
2017-01-05 12:01 ` [PATCH v2 4/5] vmxnet3: Avoid memory leak in vmxnet3_dev_tx_queue_setup nickcooper-zhangtonghao
2017-01-05 12:01 ` nickcooper-zhangtonghao [this message]
2017-01-05 14:23 ` [PATCH v2 1/5] eal: Set numa node value for system which not support NUMA Ferruh Yigit
2017-01-06 0:01 ` Yong Wang
2017-01-09 2:06 ` nickcooper-zhangtonghao
2017-01-09 2:20 ` nickcooper-zhangtonghao
2017-01-05 16:17 ` Stephen Hemminger
2017-01-05 16:26 ` Stephen Hemminger
2017-01-09 2:14 ` nickcooper-zhangtonghao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1483617709-7088-5-git-send-email-nic@opencloud.tech \
--to=nic@opencloud.tech \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.