All of lore.kernel.org
 help / color / mirror / Atom feed
From: Teresa Remmet <t.remmet@phytec.de>
To: Brian Norris <briannorris@chromium.org>,
	Tony Lindgren <tony@atomide.com>
Cc: "Mark Rutland" <mark.rutland@arm.com>,
	devicetree@vger.kernel.org,
	"Brian Norris" <computersforpeace@gmail.com>,
	"Rob Herring" <robh+dt@kernel.org>,
	linux-mtd@lists.infradead.org,
	"Benoît Cousson" <bcousson@baylibre.com>,
	linux-omap@vger.kernel.org, "Adam Ford" <aford173@gmail.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/6] ARM: dts: am335x-phycore-som: Update NAND partition table
Date: Fri, 06 Jan 2017 10:27:29 +0100	[thread overview]
Message-ID: <1483694849.3634.6.camel@phytec.de> (raw)
In-Reply-To: <20170105175619.GA56877@google.com>

Hello Brian,

Am Donnerstag, den 05.01.2017, 09:56 -0800 schrieb Brian Norris:
> On Thu, Jan 05, 2017 at 09:18:45AM -0800, Tony Lindgren wrote:
> > 
> > * Tony Lindgren <tony@atomide.com> [170105 07:37]:
> > > 
> > > * Teresa Remmet <t.remmet@phytec.de> [170105 06:57]:
> > > > 
> > > > To improve NAND safety we updated the partition layout.
> > > > Added barebox backup partition and removed kernel and oftree
> > > > partition. They are kept in ubi now.
> > > What about the users with earlier partition tables?
> > > 
> > > Please read about "flag day" changes, typically they are not
> > > acceptable.
> > Adding Brian and Adam to Cc. Can you guys come up with some
> > solution on this?
> I don't have much context for this thread, and no I don't plan to
> solve
> your problems for you. But I can provide tips!
> 
> > 
> > I'm suggesting we leave the kernel nodes empty and let u-boot
> > populate them, so maybe you guys can discuss this on the related
> > lists.
> That's an option. I've worked with platforms that did something like
> this, and that's really one of the only ways you can handle putting
> partition information in the device tree. You're really hamstringing
> yourself when you put all the partition information in the device
> tree.
> And it's just dumb once that gets codified in the kernel source tree.
> 

In our case the bootloader does pass the partition table to the kernel.
So it gets overwritten anyway. This was just more for backup, 
if someone uses a different bootloader. But I'm fine with removing the
nand partition table completely from the kernel device tree.
Same with the SPI nor partition table.

I will send patches for this.

Regards,
Teresa

> The best solution would be to try to migrate away from static device
> tree representations of partition info entirely. UBI volumes are best
> where possible. If not, then some other kind of on-flash data
> structures
> (along the lines of a GPT) with a corresponding MTD partition parser
> is
> an OK alternative. Unfortunately, there isn't any good standard
> format
> for this on MTD, so it's typically all custom -- and so people use
> the
> easiest approach: device tree. And it's even more difficult with
> NAND,
> which has reliability problems, especially with static data (e.g.,
> read
> disturb).
> 
> Anyway, the parser solution is helpful only if one can properly fix
> the
> "flag day" first. And it requires a little bit more work to be
> generally
> useful; I posted some work for this over a year ago, but bikeshedding
> brought it down.
> 
> > 
> > The rest of the series looks fine to me so applying it into
> > omap-for-v4.11/dt.
> Brian
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Teresa Remmet <t.remmet@phytec.de>
To: Brian Norris <briannorris@chromium.org>,
	Tony Lindgren <tony@atomide.com>
Cc: "Mark Rutland" <mark.rutland@arm.com>,
	devicetree@vger.kernel.org, linux-omap@vger.kernel.org,
	"Rob Herring" <robh+dt@kernel.org>,
	linux-mtd@lists.infradead.org,
	"Benoît Cousson" <bcousson@baylibre.com>,
	"Brian Norris" <computersforpeace@gmail.com>,
	"Adam Ford" <aford173@gmail.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/6] ARM: dts: am335x-phycore-som: Update NAND partition table
Date: Fri, 06 Jan 2017 10:27:29 +0100	[thread overview]
Message-ID: <1483694849.3634.6.camel@phytec.de> (raw)
In-Reply-To: <20170105175619.GA56877@google.com>

Hello Brian,

Am Donnerstag, den 05.01.2017, 09:56 -0800 schrieb Brian Norris:
> On Thu, Jan 05, 2017 at 09:18:45AM -0800, Tony Lindgren wrote:
> > 
> > * Tony Lindgren <tony@atomide.com> [170105 07:37]:
> > > 
> > > * Teresa Remmet <t.remmet@phytec.de> [170105 06:57]:
> > > > 
> > > > To improve NAND safety we updated the partition layout.
> > > > Added barebox backup partition and removed kernel and oftree
> > > > partition. They are kept in ubi now.
> > > What about the users with earlier partition tables?
> > > 
> > > Please read about "flag day" changes, typically they are not
> > > acceptable.
> > Adding Brian and Adam to Cc. Can you guys come up with some
> > solution on this?
> I don't have much context for this thread, and no I don't plan to
> solve
> your problems for you. But I can provide tips!
> 
> > 
> > I'm suggesting we leave the kernel nodes empty and let u-boot
> > populate them, so maybe you guys can discuss this on the related
> > lists.
> That's an option. I've worked with platforms that did something like
> this, and that's really one of the only ways you can handle putting
> partition information in the device tree. You're really hamstringing
> yourself when you put all the partition information in the device
> tree.
> And it's just dumb once that gets codified in the kernel source tree.
> 

In our case the bootloader does pass the partition table to the kernel.
So it gets overwritten anyway. This was just more for backup, 
if someone uses a different bootloader. But I'm fine with removing the
nand partition table completely from the kernel device tree.
Same with the SPI nor partition table.

I will send patches for this.

Regards,
Teresa

> The best solution would be to try to migrate away from static device
> tree representations of partition info entirely. UBI volumes are best
> where possible. If not, then some other kind of on-flash data
> structures
> (along the lines of a GPT) with a corresponding MTD partition parser
> is
> an OK alternative. Unfortunately, there isn't any good standard
> format
> for this on MTD, so it's typically all custom -- and so people use
> the
> easiest approach: device tree. And it's even more difficult with
> NAND,
> which has reliability problems, especially with static data (e.g.,
> read
> disturb).
> 
> Anyway, the parser solution is helpful only if one can properly fix
> the
> "flag day" first. And it requires a little bit more work to be
> generally
> useful; I posted some work for this over a year ago, but bikeshedding
> brought it down.
> 
> > 
> > The rest of the series looks fine to me so applying it into
> > omap-for-v4.11/dt.
> Brian
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: t.remmet@phytec.de (Teresa Remmet)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/6] ARM: dts: am335x-phycore-som: Update NAND partition table
Date: Fri, 06 Jan 2017 10:27:29 +0100	[thread overview]
Message-ID: <1483694849.3634.6.camel@phytec.de> (raw)
In-Reply-To: <20170105175619.GA56877@google.com>

Hello Brian,

Am Donnerstag, den 05.01.2017, 09:56 -0800 schrieb Brian Norris:
> On Thu, Jan 05, 2017 at 09:18:45AM -0800, Tony Lindgren wrote:
> > 
> > * Tony Lindgren <tony@atomide.com> [170105 07:37]:
> > > 
> > > * Teresa Remmet <t.remmet@phytec.de> [170105 06:57]:
> > > > 
> > > > To improve NAND safety we updated the partition layout.
> > > > Added barebox backup partition and removed kernel and oftree
> > > > partition. They are kept in ubi now.
> > > What about the users with earlier partition tables?
> > > 
> > > Please read about "flag day" changes, typically they are not
> > > acceptable.
> > Adding Brian and Adam to Cc. Can you guys come up with some
> > solution on this?
> I don't have much context for this thread, and no I don't plan to
> solve
> your problems for you. But I can provide tips!
> 
> > 
> > I'm suggesting we leave the kernel nodes empty and let u-boot
> > populate them, so maybe you guys can discuss this on the related
> > lists.
> That's an option. I've worked with platforms that did something like
> this, and that's really one of the only ways you can handle putting
> partition information in the device tree. You're really hamstringing
> yourself when you put all the partition information in the device
> tree.
> And it's just dumb once that gets codified in the kernel source tree.
> 

In our case the bootloader does pass the partition table to the kernel.
So it gets overwritten anyway. This was just more for backup,?
if someone uses a different bootloader. But I'm fine with removing the
nand partition table completely from the kernel device tree.
Same with the SPI nor partition table.

I will send patches for this.

Regards,
Teresa

> The best solution would be to try to migrate away from static device
> tree representations of partition info entirely. UBI volumes are best
> where possible. If not, then some other kind of on-flash data
> structures
> (along the lines of a GPT) with a corresponding MTD partition parser
> is
> an OK alternative. Unfortunately, there isn't any good standard
> format
> for this on MTD, so it's typically all custom -- and so people use
> the
> easiest approach: device tree. And it's even more difficult with
> NAND,
> which has reliability problems, especially with static data (e.g.,
> read
> disturb).
> 
> Anyway, the parser solution is helpful only if one can properly fix
> the
> "flag day" first. And it requires a little bit more work to be
> generally
> useful; I posted some work for this over a year ago, but bikeshedding
> brought it down.
> 
> > 
> > The rest of the series looks fine to me so applying it into
> > omap-for-v4.11/dt.
> Brian
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2017-01-06  9:27 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-05 14:50 [PATCH 0/6] ARM: dts: phyBOARD-WEGA-AM335x updates Teresa Remmet
2017-01-05 14:50 ` Teresa Remmet
2017-01-05 14:50 ` [PATCH 2/6] ARM: dts: am335x-phycore-som: Update compatible string for spi nor Teresa Remmet
2017-01-05 14:50   ` Teresa Remmet
2017-01-05 14:50 ` [PATCH 3/6] ARM: dts: am335x-phycore-som: Add i2c temp sensor Teresa Remmet
2017-01-05 14:50   ` Teresa Remmet
     [not found] ` <1483627851-17996-1-git-send-email-t.remmet-guT5V/WYfQezQB+pC5nmwQ@public.gmane.org>
2017-01-05 14:50   ` [PATCH 1/6] ARM: dts: am335x-phycore-som: Update NAND partition table Teresa Remmet
2017-01-05 14:50     ` Teresa Remmet
     [not found]     ` <1483627851-17996-2-git-send-email-t.remmet-guT5V/WYfQezQB+pC5nmwQ@public.gmane.org>
2017-01-05 15:36       ` Tony Lindgren
2017-01-05 15:36         ` Tony Lindgren
2017-01-05 17:18         ` Tony Lindgren
2017-01-05 17:18           ` Tony Lindgren
2017-01-05 17:56           ` Brian Norris
2017-01-05 17:56             ` Brian Norris
2017-01-05 17:56             ` Brian Norris
2017-01-06  9:27             ` Teresa Remmet [this message]
2017-01-06  9:27               ` Teresa Remmet
2017-01-06  9:27               ` Teresa Remmet
2017-01-06 16:02               ` Tony Lindgren
2017-01-06 16:02                 ` Tony Lindgren
2017-01-06 16:02                 ` Tony Lindgren
2017-01-06 16:05                 ` Adam Ford
2017-01-06 16:05                   ` Adam Ford
2017-01-06 16:05                   ` Adam Ford
2017-01-06 16:14                   ` Tony Lindgren
2017-01-06 16:14                     ` Tony Lindgren
2017-01-06 16:14                     ` Tony Lindgren
2017-01-06 18:20                     ` Brian Norris
2017-01-06 18:20                       ` Brian Norris
2017-01-06 18:20                       ` Brian Norris
2017-01-06 18:43                       ` Tony Lindgren
2017-01-06 18:43                         ` Tony Lindgren
2017-01-06 18:43                         ` Tony Lindgren
2017-01-06 17:39             ` Ladislav Michl
2017-01-06 17:39               ` Ladislav Michl
2017-01-06 17:39               ` Ladislav Michl
2017-01-05 14:50   ` [PATCH 4/6] ARM: dts: am335x-wega: Set USB0 mode to otg Teresa Remmet
2017-01-05 14:50     ` Teresa Remmet
2017-01-05 14:50 ` [PATCH 5/6] ARM: dts: am335x-phycore-som: Update ethernet phy node Teresa Remmet
2017-01-05 14:50   ` Teresa Remmet
2017-01-05 14:50 ` [PATCH 6/6] ARM: dts: am335x-wega: " Teresa Remmet
2017-01-05 14:50   ` Teresa Remmet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1483694849.3634.6.camel@phytec.de \
    --to=t.remmet@phytec.de \
    --cc=aford173@gmail.com \
    --cc=bcousson@baylibre.com \
    --cc=briannorris@chromium.org \
    --cc=computersforpeace@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.