All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: "Michał Kępień" <kernel@kempniu.pl>
Cc: "David S . Miller" <davem@davemloft.net>,
	"Михаил Кринкин" <krinkin.m.u@gmail.com>,
	linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] rfkill: Add rfkill-any LED trigger
Date: Mon, 09 Jan 2017 11:39:50 +0100	[thread overview]
Message-ID: <1483958390.17582.16.camel@sipsolutions.net> (raw)
In-Reply-To: <20170106192027.GA756@kmp-mobile.hq.kempniu.pl> (sfid-20170106_202031_655798_4350A20F)


> > Looks better, but
> > 
> > > +static struct work_struct rfkill_any_work;
> > 
> > At least on module exit you need to cancel this work.
> 
> It is cancelled in rfkill_any_led_trigger_unregister().  It seemed
> fitting to do it this way as rfkill_any_work is initialized in
> rfkill_any_led_trigger_register().  And if CONFIG_RFKILL_LEDS=n,
> rfkill_any_work is neither initialized nor scheduled, so we should be
> good as well.  Am I missing something?

No, I just missed that, sorry.

Applied the patch now.

johannes

      reply	other threads:[~2017-01-09 10:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-06  6:07 [PATCH v4] rfkill: Add rfkill-any LED trigger Michał Kępień
2017-01-06 12:22 ` Johannes Berg
2017-01-06 19:20   ` Michał Kępień
2017-01-06 19:20     ` Michał Kępień
2017-01-09 10:39     ` Johannes Berg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1483958390.17582.16.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=davem@davemloft.net \
    --cc=kernel@kempniu.pl \
    --cc=krinkin.m.u@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.