Re: [Qemu-devel] [PATCH 0/2] virtio-gpu: fix issues with VM load code

[Gerd Hoffmann <kraxel@redhat.com>]

On Mo, 2017-01-09 at 13:38 +0000, Peter Maydell wrote:
> These patches fix a couple of issues with the VM load code
> which I noticed while investigating a coverity warning.
> 
> The first patch fixes a problem with the accounting for
> host pixmap memory usage -- we didn't recalculate the
> current usage following a VM migration, but instead
> started again at zero, which means that if you keep
> bumping the VM from host to host you can sidestep the
> host_maxmem limit.
> 
> The second patch fixes the coverity warning (that if we
> fail in the "creating resources" loop in the load function
> we will leak memory and so on). The leak isn't very
> serious, because if we fail the inbound migration then
> the whole QEMU process is pretty useless for anything,
> but it's easy enough to fix "correctly", ie so that a
> subsequent system reset will put the device back into
> a sane state.
> 
> Peter Maydell (2):
>   virtio-gpu: Recalculate VirtIOGPU::hostmem on VM load
>   virtio-gpu: Fix memory leak in virtio_gpu_load()
> 
>  hw/display/virtio-gpu.c | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
> 
Added to vga queue.

thanks,
  Gerd