From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-BN3-obe.outbound.protection.outlook.com (mail-bn3nam01on071d.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe41::71d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 3BD6281B14 for ; Tue, 10 Jan 2017 15:54:57 -0800 (PST) From: "Kani, Toshimitsu" Subject: Re: [PATCH v4] DAX: enable iostat for read/write Date: Tue, 10 Jan 2017 23:54:54 +0000 Message-ID: <1484095838.2029.1.camel@hpe.com> References: <20170111001122.10826-1-toshi.kani@hpe.com> In-Reply-To: Content-Language: en-US Content-ID: <99363862D683E84CB399E152FAD0F3AA@NAMPRD84.PROD.OUTLOOK.COM> MIME-Version: 1.0 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: "dan.j.williams@intel.com" Cc: "linux-nvdimm@lists.01.org" , "david@fromorbit.com" , "linux-kernel@vger.kernel.org" , "viro@zeniv.linux.org.uk" , "linux-fsdevel@vger.kernel.org" , "akpm@linux-foundation.org" List-ID: T24gVHVlLCAyMDE3LTAxLTEwIGF0IDE1OjQxIC0wODAwLCBEYW4gV2lsbGlhbXMgd3JvdGU6DQo+ IE9uIFR1ZSwgSmFuIDEwLCAyMDE3IGF0IDQ6MTEgUE0sIFRvc2hpIEthbmkgPHRvc2hpLmthbmlA aHBlLmNvbT4NCj4gd3JvdGU6DQogOg0KPiA+IA0KPiA+ICvCoMKgwqDCoMKgwqDCoGlmIChibGtf cXVldWVfaW9fc3RhdChkaXNrLT5xdWV1ZSkpIHsNCj4gPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgaW50IHNlYyA9IGlvdl9pdGVyX2NvdW50KGl0ZXIpID4+IDk7DQo+ID4gKw0KPiA+ ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqBzdGFydCA9IGppZmZpZXM7DQo+ID4gK8Kg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoGdlbmVyaWNfc3RhcnRfaW9fYWNjdChpb3ZfaXRl cl9ydyhpdGVyKSwNCj4gPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAoIXNlYykgPyAxIDogc2VjLCAmZGlz ay0NCj4gPiA+cGFydDApOw0KPiA+ICvCoMKgwqDCoMKgwqDCoH0NCj4gPiArDQo+ID4gwqDCoMKg wqDCoMKgwqDCoHdoaWxlIChpb3ZfaXRlcl9jb3VudChpdGVyKSkgew0KPiA+IMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgcmV0ID0gaW9tYXBfYXBwbHkoaW5vZGUsIHBvcywgaW92X2l0 ZXJfY291bnQoaXRlciksDQo+ID4gZmxhZ3MsIG9wcywNCj4gPiDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgaXRlciwgZGF4X2lv bWFwX2FjdG9yKTsNCj4gPiBAQCAtMTA3Myw2ICsxMDgzLDkgQEAgZGF4X2lvbWFwX3J3KHN0cnVj dCBraW9jYiAqaW9jYiwgc3RydWN0DQo+ID4gaW92X2l0ZXIgKml0ZXIsDQo+ID4gwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqBkb25lICs9IHJldDsNCj4gPiDCoMKgwqDCoMKgwqDCoMKg fQ0KPiA+IA0KPiA+ICvCoMKgwqDCoMKgwqDCoGlmIChzdGFydCkNCj4gPiArwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgZ2VuZXJpY19lbmRfaW9fYWNjdChpb3ZfaXRlcl9ydyhpdGVyKSwg JmRpc2stDQo+ID4gPnBhcnQwLCBzdGFydCk7DQo+ID4gKw0KPiANCj4gSSB0aGluayB3ZSBjYW4g YWZmb3JkIHRvIGFkZCBhIHNlcGFyYXRlIGZsYWcgdGhhdCBpbmRpY2F0ZXMgd2hldGhlcg0KPiB3 ZSBjYWxsZWQgZ2VuZXJpY19zdGFydF9pb19hY2N0KCkuIEp1c3QgaW4gY2FzZSAnc3RhcnQnIGlz ICcwJyBhZnRlcg0KPiAnamlmZmllcycgcm9sbHMgb3Zlci4NCg0KR29vZCBwb2ludC4gSSB3aWxs IGFkZCBhIGZsYWcgdG8gYWNjb3VudCBzdWNoIGEgY2FzZS4NCg0KVGhhbmtzLA0KLVRvc2hpDQpf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpMaW51eC1udmRp bW0gbWFpbGluZyBsaXN0CkxpbnV4LW52ZGltbUBsaXN0cy4wMS5vcmcKaHR0cHM6Ly9saXN0cy4w MS5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1udmRpbW0K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-bn3nam01on0125.outbound.protection.outlook.com ([104.47.33.125]:47680 "EHLO NAM01-BN3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752158AbdAJXy5 (ORCPT ); Tue, 10 Jan 2017 18:54:57 -0500 From: "Kani, Toshimitsu" To: "dan.j.williams@intel.com" CC: "viro@zeniv.linux.org.uk" , "david@fromorbit.com" , "linux-nvdimm@lists.01.org" , "ross.zwisler@linux.intel.com" , "akpm@linux-foundation.org" , "linux-fsdevel@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v4] DAX: enable iostat for read/write Date: Tue, 10 Jan 2017 23:54:54 +0000 Message-ID: <1484095838.2029.1.camel@hpe.com> References: <20170111001122.10826-1-toshi.kani@hpe.com> In-Reply-To: Content-Language: en-US Content-Type: text/plain; charset="utf-8" Content-ID: <99363862D683E84CB399E152FAD0F3AA@NAMPRD84.PROD.OUTLOOK.COM> Content-Transfer-Encoding: base64 MIME-Version: 1.0 Sender: linux-fsdevel-owner@vger.kernel.org List-ID: T24gVHVlLCAyMDE3LTAxLTEwIGF0IDE1OjQxIC0wODAwLCBEYW4gV2lsbGlhbXMgd3JvdGU6DQo+ IE9uIFR1ZSwgSmFuIDEwLCAyMDE3IGF0IDQ6MTEgUE0sIFRvc2hpIEthbmkgPHRvc2hpLmthbmlA aHBlLmNvbT4NCj4gd3JvdGU6DQogOg0KPiA+IA0KPiA+ICvCoMKgwqDCoMKgwqDCoGlmIChibGtf cXVldWVfaW9fc3RhdChkaXNrLT5xdWV1ZSkpIHsNCj4gPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgaW50IHNlYyA9IGlvdl9pdGVyX2NvdW50KGl0ZXIpID4+IDk7DQo+ID4gKw0KPiA+ ICvCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqBzdGFydCA9IGppZmZpZXM7DQo+ID4gK8Kg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoGdlbmVyaWNfc3RhcnRfaW9fYWNjdChpb3ZfaXRl cl9ydyhpdGVyKSwNCj4gPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAoIXNlYykgPyAxIDogc2VjLCAmZGlz ay0NCj4gPiA+cGFydDApOw0KPiA+ICvCoMKgwqDCoMKgwqDCoH0NCj4gPiArDQo+ID4gwqDCoMKg wqDCoMKgwqDCoHdoaWxlIChpb3ZfaXRlcl9jb3VudChpdGVyKSkgew0KPiA+IMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgcmV0ID0gaW9tYXBfYXBwbHkoaW5vZGUsIHBvcywgaW92X2l0 ZXJfY291bnQoaXRlciksDQo+ID4gZmxhZ3MsIG9wcywNCj4gPiDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgaXRlciwgZGF4X2lv bWFwX2FjdG9yKTsNCj4gPiBAQCAtMTA3Myw2ICsxMDgzLDkgQEAgZGF4X2lvbWFwX3J3KHN0cnVj dCBraW9jYiAqaW9jYiwgc3RydWN0DQo+ID4gaW92X2l0ZXIgKml0ZXIsDQo+ID4gwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqBkb25lICs9IHJldDsNCj4gPiDCoMKgwqDCoMKgwqDCoMKg fQ0KPiA+IA0KPiA+ICvCoMKgwqDCoMKgwqDCoGlmIChzdGFydCkNCj4gPiArwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgZ2VuZXJpY19lbmRfaW9fYWNjdChpb3ZfaXRlcl9ydyhpdGVyKSwg JmRpc2stDQo+ID4gPnBhcnQwLCBzdGFydCk7DQo+ID4gKw0KPiANCj4gSSB0aGluayB3ZSBjYW4g YWZmb3JkIHRvIGFkZCBhIHNlcGFyYXRlIGZsYWcgdGhhdCBpbmRpY2F0ZXMgd2hldGhlcg0KPiB3 ZSBjYWxsZWQgZ2VuZXJpY19zdGFydF9pb19hY2N0KCkuIEp1c3QgaW4gY2FzZSAnc3RhcnQnIGlz ICcwJyBhZnRlcg0KPiAnamlmZmllcycgcm9sbHMgb3Zlci4NCg0KR29vZCBwb2ludC4gSSB3aWxs IGFkZCBhIGZsYWcgdG8gYWNjb3VudCBzdWNoIGEgY2FzZS4NCg0KVGhhbmtzLA0KLVRvc2hpDQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758803AbdAJXy7 (ORCPT ); Tue, 10 Jan 2017 18:54:59 -0500 Received: from mail-bn3nam01on0125.outbound.protection.outlook.com ([104.47.33.125]:47680 "EHLO NAM01-BN3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752158AbdAJXy5 (ORCPT ); Tue, 10 Jan 2017 18:54:57 -0500 From: "Kani, Toshimitsu" To: "dan.j.williams@intel.com" CC: "viro@zeniv.linux.org.uk" , "david@fromorbit.com" , "linux-nvdimm@lists.01.org" , "ross.zwisler@linux.intel.com" , "akpm@linux-foundation.org" , "linux-fsdevel@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v4] DAX: enable iostat for read/write Thread-Topic: [PATCH v4] DAX: enable iostat for read/write Thread-Index: AQHSa5d/ro3wS0lNGEiFAt9SbjNTx6EyXvuAgAATSQA= Date: Tue, 10 Jan 2017 23:54:54 +0000 Message-ID: <1484095838.2029.1.camel@hpe.com> References: <20170111001122.10826-1-toshi.kani@hpe.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=toshi.kani@hpe.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [15.219.163.9] x-ms-office365-filtering-correlation-id: 1287d7cb-3c54-4d61-2505-08d439b41394 x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:CS1PR84MB0294; x-microsoft-exchange-diagnostics: 1;CS1PR84MB0294;7:YUtwFzQz+mbLubCXoMfoG2F5qQNiIodwVoPmOR5B3C16wfxAY+24SkAJDRp3Tkxj04o9lyifDhlVdsoL2OK5zczsVQ2211WsGL3bynaKUCzWdIEyEesa4nMiS5a2+K2H2jZDpEvk6RXkV8G44/vJC5oXNU/aMds9aOF+oQgROe/eFZUF5fNQUfpcNLB1l/8JK2Uv5tEF5nwv10VUFdxChORRL3bUsSjZaoWSA/NhXTe5UwId9z68tj3EBsZnfNdYtwErp6KOZA1qzbv5DTqpotHZ5REKZgRur3lQdMJkReglUEKPhv3qXK/syA/VgxgIJFzsc8ccrpexYZUE6uulb/JflxQUPEUcB5xQ5S9tZgGpgEHYF6y0FZ+EPUMMYuiUN99ePrQwaRKEgHUjuGyTw6JRYIAAKpYVs2qNnuGHJzYFtPcttf8jIkF9yTY2uWyo5g+fUyxgCGiZr0VZgheSdQ== x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(227479698468861); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6055026)(6041248)(20161123562025)(20161123555025)(20161123564025)(20161123560025)(6072148);SRVR:CS1PR84MB0294;BCL:0;PCL:0;RULEID:;SRVR:CS1PR84MB0294; x-forefront-prvs: 01834E39B7 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(7916002)(39450400003)(39840400002)(39850400002)(39410400002)(39860400002)(24454002)(377454003)(199003)(189002)(377424004)(189998001)(5660300001)(68736007)(101416001)(8936002)(2950100002)(6512007)(38730400001)(81166006)(305945005)(7736002)(2351001)(106116001)(66066001)(105586002)(3660700001)(229853002)(5640700003)(92566002)(6436002)(122556002)(6916009)(2900100001)(106356001)(103116003)(6506006)(3280700002)(97736004)(54906002)(2906002)(4326007)(77096006)(86362001)(81156014)(110136003)(33646002)(8676002)(3846002)(2501003)(102836003)(76176999)(50986999)(6116002)(36756003)(54356999)(6486002);DIR:OUT;SFP:1102;SCL:1;SRVR:CS1PR84MB0294;H:CS1PR84MB0294.NAMPRD84.PROD.OUTLOOK.COM;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: <99363862D683E84CB399E152FAD0F3AA@NAMPRD84.PROD.OUTLOOK.COM> MIME-Version: 1.0 X-OriginatorOrg: hpe.com X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jan 2017 23:54:54.9603 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-Transport-CrossTenantHeadersStamped: CS1PR84MB0294 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id v0ANt49k027816 On Tue, 2017-01-10 at 15:41 -0800, Dan Williams wrote: > On Tue, Jan 10, 2017 at 4:11 PM, Toshi Kani > wrote: : > > > > +       if (blk_queue_io_stat(disk->queue)) { > > +               int sec = iov_iter_count(iter) >> 9; > > + > > +               start = jiffies; > > +               generic_start_io_acct(iov_iter_rw(iter), > > +                                     (!sec) ? 1 : sec, &disk- > > >part0); > > +       } > > + > >         while (iov_iter_count(iter)) { > >                 ret = iomap_apply(inode, pos, iov_iter_count(iter), > > flags, ops, > >                                 iter, dax_iomap_actor); > > @@ -1073,6 +1083,9 @@ dax_iomap_rw(struct kiocb *iocb, struct > > iov_iter *iter, > >                 done += ret; > >         } > > > > +       if (start) > > +               generic_end_io_acct(iov_iter_rw(iter), &disk- > > >part0, start); > > + > > I think we can afford to add a separate flag that indicates whether > we called generic_start_io_acct(). Just in case 'start' is '0' after > 'jiffies' rolls over. Good point. I will add a flag to account such a case. Thanks, -Toshi