From: Johannes Berg <johannes@sipsolutions.net>
To: "Malinen, Jouni" <jouni@qca.qualcomm.com>,
Arend Van Spriel <arend.vanspriel@broadcom.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"Kushwaha, Purushottam" <pkushwah@qti.qualcomm.com>
Subject: Re: [PATCH 3/3] cfg80211: Specify the reason for connect timeout
Date: Wed, 11 Jan 2017 14:26:06 +0100 [thread overview]
Message-ID: <1484141166.29931.8.camel@sipsolutions.net> (raw)
In-Reply-To: <20170111131335.GB27748@jouni.qca.qualcomm.com>
On Wed, 2017-01-11 at 13:13 +0000, Malinen, Jouni wrote:
>
> > > @@ -172,6 +174,7 @@ static int cfg80211_conn_do_work(struct
> > > wireless_dev *wdev)
> > > case CFG80211_CONN_AUTH_FAILED:
> > > + *treason = NL80211_TIMEOUT_AUTH;
> >
> > ... but it seems AUTH failure always is a timeout?
>
> The CFG80211_CONN_AUTH_FAILED case is currently used only in
> cfg80211_sme_auth_timeout() which is indeed always a timeout.
Might be worth simply renaming it, since you have the reason there
unconditionally?
johannes
next prev parent reply other threads:[~2017-01-11 13:26 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-09 17:53 [PATCH v3 1/3] cfg80211: Add support to sched scan to report better BSSs Jouni Malinen
2017-01-09 17:53 ` [PATCH v2 2/3] cfg80211: Add support to randomize TA of Public Action frames Jouni Malinen
2017-01-11 13:25 ` Johannes Berg
2017-01-09 17:53 ` [PATCH 3/3] cfg80211: Specify the reason for connect timeout Jouni Malinen
2017-01-09 20:24 ` Arend Van Spriel
2017-01-11 13:13 ` Malinen, Jouni
2017-01-11 13:26 ` Johannes Berg [this message]
2017-01-12 14:01 ` Malinen, Jouni
2017-01-11 13:31 ` Johannes Berg
2017-01-12 13:58 ` Malinen, Jouni
2017-01-12 14:06 ` Johannes Berg
2017-01-12 14:29 ` Malinen, Jouni
2017-01-12 14:32 ` Johannes Berg
2017-01-12 15:03 ` Malinen, Jouni
2017-01-09 20:07 ` [PATCH v3 1/3] cfg80211: Add support to sched scan to report better BSSs Arend Van Spriel
2017-01-11 7:48 ` Vamsi, Krishna
2017-01-11 13:22 ` Johannes Berg
2017-01-12 13:50 ` Vamsi, Krishna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1484141166.29931.8.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=arend.vanspriel@broadcom.com \
--cc=jouni@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=pkushwah@qti.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.