From: Johannes Berg <johannes@sipsolutions.net>
To: Cedric Izoard <Cedric.Izoard@ceva-dsp.com>,
Masashi Honma <masashi.honma@gmail.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: [REGRESSION, bisect] mesh: SAE connection causes kernel crash
Date: Wed, 11 Jan 2017 14:34:20 +0100 [thread overview]
Message-ID: <1484141660.29931.11.camel@sipsolutions.net> (raw)
In-Reply-To: <2b0df84e78434d11af1089e82485704b@ceva-dsp.com>
> When calling drv_tx() the headroom is not big enough for the driver.
Ok.
> >
> > Maybe we're adding something else to this skb?
> >
> > I can't find anything in the ath9k_htc driver that's adding more
> > than
> > 23 bytes (it's advertising 24) but clearly the last 8 bytes here
> > are
> > failing:
> >
> > > [ 83.200346] skbuff: skb_under_panic: text:ffffffffa034c028
> > > len:154
> > > put:8 head:ffff880213422e00 data:ffff880213422dfa tail:0x94
> > > end:0xc0
> > > dev:<NULL>
> >
> > Maybe mac80211 is putting something else? It'd have to be
>
> yes mac80211 is adding the security header.
> headroom asked to skb_copy_expand should also take sdata-
> >encrypt_headroom into account.
I suspected that, since it was about the only place that was adding
anything, but I couldn't test it :)
Can you send a patch?
johannes
next prev parent reply other threads:[~2017-01-11 13:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-10 23:35 [REGRESSION, bisect] mesh: SAE connection causes kernel crash Masashi Honma
2017-01-11 8:02 ` Johannes Berg
2017-01-11 8:50 ` Masashi Honma
2017-01-11 9:00 ` Johannes Berg
2017-01-11 9:38 ` Masashi Honma
2017-01-11 10:00 ` Johannes Berg
2017-01-11 10:36 ` Masashi Honma
2017-01-11 11:01 ` Johannes Berg
2017-01-11 11:10 ` Masashi Honma
2017-01-11 11:35 ` Cedric Izoard
2017-01-11 12:05 ` Johannes Berg
2017-01-11 13:22 ` Cedric Izoard
2017-01-11 13:34 ` Johannes Berg [this message]
2017-01-11 13:41 ` Cedric Izoard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1484141660.29931.11.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=Cedric.Izoard@ceva-dsp.com \
--cc=linux-wireless@vger.kernel.org \
--cc=masashi.honma@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.