All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Linus Walleij <linus.walleij@linaro.org>,
	Alexander Stein <alexander.stein@systec-electronic.com>
Cc: Alexandre Courbot <gnurou@gmail.com>,
	"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
	Mika Westerberg <mika.westerberg@linux.intel.com>
Subject: Re: [PATCH v2 3/3] gpiolib: Convert fwnode_get_named_gpiod() to configure GPIO
Date: Wed, 11 Jan 2017 16:14:57 +0200	[thread overview]
Message-ID: <1484144097.2133.60.camel@linux.intel.com> (raw)
In-Reply-To: <1484141740.2133.57.camel@linux.intel.com>

On Wed, 2017-01-11 at 15:35 +0200, Andy Shevchenko wrote:
> On Wed, 2017-01-11 at 13:21 +0100, Linus Walleij wrote:
> > On Mon, Jan 9, 2017 at 3:02 PM, Andy Shevchenko
> > <andriy.shevchenko@linux.intel.com> wrote:

> > This is overall fine. However I have another patch in the works from
> > Alexander Stein to pass down the label to the core properly, can you
> > look
> > at this patch too, so we don't have to mess around too much?
> > http://marc.info/?l=linux-gpio&m=148179211709228&w=2
> > 
> > Which patch should we base on which patch? Or can they be
> > combined into one?

> > That patch has been held back awaiting ACKs and already
> > has an ACK from Jacek so I would merge it first. Could you
> > rebase this patch on top of Alexander's patch?
> > 
> 
> At the first glance looks okay to just merge it. 
> Means I don't see it might affect functionality of what I'm trying to
> do.
> 
> So, please, go ahead and thanks for pointing out. I will prepare mine
> on
> top of it.

Alas, it doesn't apply clearly. gpio_keys_polled.c has been changed a
lot from that time. So, would you like to fix it yourself?

Since mine is applied clearly I may do other way around, rebase and fix
that patch on top of mine.
How does it sound?

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

  reply	other threads:[~2017-01-11 14:15 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-09 14:02 [PATCH v2 0/3] Unify gpiod_get*() API Andy Shevchenko
2017-01-09 14:02 ` [PATCH v2 1/3] gpiolib: Switch to for_each_set_bit() Andy Shevchenko
2017-01-11 11:11   ` Linus Walleij
2017-01-09 14:02 ` [PATCH v2 2/3] gpiolib: Update documentation of struct acpi_gpio_info Andy Shevchenko
2017-01-11 11:11   ` Linus Walleij
2017-01-11 11:42     ` Andy Shevchenko
2017-01-09 14:02 ` [PATCH v2 3/3] gpiolib: Convert fwnode_get_named_gpiod() to configure GPIO Andy Shevchenko
2017-01-11 12:21   ` Linus Walleij
2017-01-11 13:35     ` Andy Shevchenko
2017-01-11 14:14       ` Andy Shevchenko [this message]
2017-01-12  7:27         ` Alexander Stein
2017-01-12 12:15           ` Andy Shevchenko
2017-01-12 12:51             ` Alexander Stein
2017-01-12 14:27               ` Andy Shevchenko
2017-01-17 15:05   ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1484144097.2133.60.camel@linux.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=alexander.stein@systec-electronic.com \
    --cc=gnurou@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.