All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
	Mika Westerberg <mika.westerberg@linux.intel.com>,
	Jarkko Nikula <jarkko.nikula@linux.intel.com>
Subject: Re: [PATCH v1 1/1] pinctrl: intel: Set pin direction properly
Date: Wed, 11 Jan 2017 16:21:26 +0200	[thread overview]
Message-ID: <1484144486.2133.62.camel@linux.intel.com> (raw)
In-Reply-To: <CACRpkdY8fUR6-WE9TE9V3AxsWWjKs-gwQbUG5Afoe9fmYUnkmQ@mail.gmail.com>

On Wed, 2017-01-11 at 13:50 +0100, Linus Walleij wrote:
> On Mon, Jan 2, 2017 at 1:07 PM, Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> 
> > There are two bits in the PADCFG0 register to configure direction,
> > one per
> > TX/RX buffers.
> > 
> > For now we wrongly assume that the GPIO is always requested before
> > it is being
> > used, which is not true when the GPIO is used through irqchip. In
> > this case the
> > GPIO is never requested and we never enable RX buffer for it.
> > 
> > Fix this by setting both bits accordingly.
> > 
> > Reported-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> 
> I applied this patch for fixes on top of Mika's pad offset
> fix.
> 
> Hope this is right... There is some noise in the thread but
> AFAICT there are more fixes coming.

Yes, it's self-sufficient and needed independently of the rest.
Thanks!

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

      reply	other threads:[~2017-01-11 14:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-02 12:07 [PATCH v1 1/1] pinctrl: intel: Set pin direction properly Andy Shevchenko
2017-01-09 14:29 ` Jarkko Nikula
2017-01-09 14:45   ` Andy Shevchenko
2017-01-09 15:12     ` Jarkko Nikula
2017-01-09 15:41       ` Andy Shevchenko
2017-01-11 12:50 ` Linus Walleij
2017-01-11 14:21   ` Andy Shevchenko [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1484144486.2133.62.camel@linux.intel.com \
    --to=andriy.shevchenko@linux.intel.com \
    --cc=jarkko.nikula@linux.intel.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.