From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-CY1-obe.outbound.protection.outlook.com (mail-cys01nam02on070a.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe45::70a]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D17D681B87 for ; Wed, 11 Jan 2017 08:29:23 -0800 (PST) From: "Kani, Toshimitsu" Subject: Re: [PATCH v4] DAX: enable iostat for read/write Date: Wed, 11 Jan 2017 16:29:21 +0000 Message-ID: <1484155504.2029.3.camel@hpe.com> References: <20170111001122.10826-1-toshi.kani@hpe.com> <1484109363.12006.19.camel@perches.com> In-Reply-To: <1484109363.12006.19.camel@perches.com> Content-Language: en-US Content-ID: <47FAF610C1BCFD4EB01438815B7AD868@NAMPRD84.PROD.OUTLOOK.COM> MIME-Version: 1.0 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: linux-nvdimm-bounces@lists.01.org Sender: "Linux-nvdimm" To: "joe@perches.com" , "dan.j.williams@intel.com" , "akpm@linux-foundation.org" Cc: "linux-nvdimm@lists.01.org" , "viro@zenihttp.domain.invalid" , "david@fromorbit.com" , "linux-kernel@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" List-ID: T24gVHVlLCAyMDE3LTAxLTEwIGF0IDIwOjM2IC0wODAwLCBKb2UgUGVyY2hlcyB3cm90ZToNCj4g PiANCk9uIFR1ZSwgMjAxNy0wMS0xMCBhdCAxNzoxMSAtMDcwMCwgVG9zaGkgS2FuaSB3cm90ZToN Cj4gPiBEQVggSU8gcGF0aCBkb2VzIG5vdCBzdXBwb3J0IGlvc3RhdCwgYnV0IGl0cyBtZXRhZGF0 YSBJTyBwYXRoIGRvZXMuDQo+ID4gVGhlcmVmb3JlLCBpb3N0YXQgc2hvd3MgbWV0YWRhdGEgSU8g c3RhdGlzdGljcyBvbmx5LCB3aGljaCBoYXMgYmVlbg0KPiA+IGNvbmZ1c2luZyB0byB1c2Vycy4N Cj4gDQo+IFtdDQo+ID4gZGlmZiAtLWdpdCBhL2ZzL2RheC5jIGIvZnMvZGF4LmMNCj4gDQo+IFtd DQo+ID4gQEAgLTEwNTgsMTIgKzEwNTgsMjIgQEAgZGF4X2lvbWFwX3J3KHN0cnVjdCBraW9jYiAq aW9jYiwgc3RydWN0DQo+ID4gaW92X2l0ZXIgKml0ZXIsDQo+IA0KPiBbXQ0KPiA+ICsJaWYgKGJs a19xdWV1ZV9pb19zdGF0KGRpc2stPnF1ZXVlKSkgew0KPiA+ICsJCWludCBzZWMgPSBpb3ZfaXRl cl9jb3VudChpdGVyKSA+PiA5Ow0KPiA+ICsNCj4gPiArCQlzdGFydCA9IGppZmZpZXM7DQo+ID4g KwkJZ2VuZXJpY19zdGFydF9pb19hY2N0KGlvdl9pdGVyX3J3KGl0ZXIpLA0KPiA+ICsJCQkJwqDC oMKgwqDCoMKgKCFzZWMpID8gMSA6IHNlYywgJmRpc2stDQo+ID4gPnBhcnQwKTsNCj4gPiArCX0N Cj4gDQo+IFRoZXJlIGlzIGEgc2lnbmVkL3Vuc2lnbmVkIGNvbnZlcnNpb24gb2Ygc2VjDQo+IEl0 IG1heSBiZSBiZXR0ZXIgdG8gdXNlIHNvbWV0aGluZyBsaWtlOg0KPiANCj4gCQlzaXplX3Qgc2Vj wqDCoD0gaW92X2l0ZXJfY291bnQoaXRlcikgPj4gOTsNCj4gCQlbLi4uXQ0KPiAJCWdlbmVyaWNf c3RhcnRfaW9fYWNjdChpb3ZfaXRlcl9ydyhpdGVyKSwNCj4gCQkJCcKgwqDCoMKgwqDCoG1pbl90 KHVuc2lnbmVkIGxvbmcsIDEsIHNlYyksDQo+IAkJCQnCoMKgwqDCoMKgwqAmZGlzay0+cGFydDAp Ow0KDQpHb29kIGNhdGNoLiBJIHdpbGwgY2hhbmdlIGFzIHlvdSBzdWdnZXN0ZWQsIGFuZCB1c2Ug J3NlY3Rvcl90JyBmb3INCidzZWMnLiANCg0KVGhhbmtzLA0KLVRvc2hpCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkxpbnV4LW52ZGltbSBtYWlsaW5nIGxp c3QKTGludXgtbnZkaW1tQGxpc3RzLjAxLm9yZwpodHRwczovL2xpc3RzLjAxLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2xpbnV4LW52ZGltbQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: "Kani, Toshimitsu" To: "joe@perches.com" , "dan.j.williams@intel.com" , "akpm@linux-foundation.org" CC: "viro@zenihttp.domain.invalid" , "ross.zwisler@linux.intel.com" , "david@fromorbit.com" , "linux-nvdimm@lists.01.org" , "linux-kernel@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" Subject: Re: [PATCH v4] DAX: enable iostat for read/write Date: Wed, 11 Jan 2017 16:29:21 +0000 Message-ID: <1484155504.2029.3.camel@hpe.com> References: <20170111001122.10826-1-toshi.kani@hpe.com> <1484109363.12006.19.camel@perches.com> In-Reply-To: <1484109363.12006.19.camel@perches.com> Content-Language: en-US Content-Type: text/plain; charset="utf-8" Content-ID: <47FAF610C1BCFD4EB01438815B7AD868@NAMPRD84.PROD.OUTLOOK.COM> Content-Transfer-Encoding: base64 MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: T24gVHVlLCAyMDE3LTAxLTEwIGF0IDIwOjM2IC0wODAwLCBKb2UgUGVyY2hlcyB3cm90ZToNCj4g PiANCk9uIFR1ZSwgMjAxNy0wMS0xMCBhdCAxNzoxMSAtMDcwMCwgVG9zaGkgS2FuaSB3cm90ZToN Cj4gPiBEQVggSU8gcGF0aCBkb2VzIG5vdCBzdXBwb3J0IGlvc3RhdCwgYnV0IGl0cyBtZXRhZGF0 YSBJTyBwYXRoIGRvZXMuDQo+ID4gVGhlcmVmb3JlLCBpb3N0YXQgc2hvd3MgbWV0YWRhdGEgSU8g c3RhdGlzdGljcyBvbmx5LCB3aGljaCBoYXMgYmVlbg0KPiA+IGNvbmZ1c2luZyB0byB1c2Vycy4N Cj4gDQo+IFtdDQo+ID4gZGlmZiAtLWdpdCBhL2ZzL2RheC5jIGIvZnMvZGF4LmMNCj4gDQo+IFtd DQo+ID4gQEAgLTEwNTgsMTIgKzEwNTgsMjIgQEAgZGF4X2lvbWFwX3J3KHN0cnVjdCBraW9jYiAq aW9jYiwgc3RydWN0DQo+ID4gaW92X2l0ZXIgKml0ZXIsDQo+IA0KPiBbXQ0KPiA+ICsJaWYgKGJs a19xdWV1ZV9pb19zdGF0KGRpc2stPnF1ZXVlKSkgew0KPiA+ICsJCWludCBzZWMgPSBpb3ZfaXRl cl9jb3VudChpdGVyKSA+PiA5Ow0KPiA+ICsNCj4gPiArCQlzdGFydCA9IGppZmZpZXM7DQo+ID4g KwkJZ2VuZXJpY19zdGFydF9pb19hY2N0KGlvdl9pdGVyX3J3KGl0ZXIpLA0KPiA+ICsJCQkJwqDC oMKgwqDCoMKgKCFzZWMpID8gMSA6IHNlYywgJmRpc2stDQo+ID4gPnBhcnQwKTsNCj4gPiArCX0N Cj4gDQo+IFRoZXJlIGlzIGEgc2lnbmVkL3Vuc2lnbmVkIGNvbnZlcnNpb24gb2Ygc2VjDQo+IEl0 IG1heSBiZSBiZXR0ZXIgdG8gdXNlIHNvbWV0aGluZyBsaWtlOg0KPiANCj4gCQlzaXplX3Qgc2Vj wqDCoD0gaW92X2l0ZXJfY291bnQoaXRlcikgPj4gOTsNCj4gCQlbLi4uXQ0KPiAJCWdlbmVyaWNf c3RhcnRfaW9fYWNjdChpb3ZfaXRlcl9ydyhpdGVyKSwNCj4gCQkJCcKgwqDCoMKgwqDCoG1pbl90 KHVuc2lnbmVkIGxvbmcsIDEsIHNlYyksDQo+IAkJCQnCoMKgwqDCoMKgwqAmZGlzay0+cGFydDAp Ow0KDQpHb29kIGNhdGNoLiBJIHdpbGwgY2hhbmdlIGFzIHlvdSBzdWdnZXN0ZWQsIGFuZCB1c2Ug J3NlY3Rvcl90JyBmb3INCidzZWMnLiANCg0KVGhhbmtzLA0KLVRvc2hp From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030698AbdAKQ33 (ORCPT ); Wed, 11 Jan 2017 11:29:29 -0500 Received: from mail-cys01nam02on0121.outbound.protection.outlook.com ([104.47.37.121]:17178 "EHLO NAM02-CY1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1030654AbdAKQ3Y (ORCPT ); Wed, 11 Jan 2017 11:29:24 -0500 From: "Kani, Toshimitsu" To: "joe@perches.com" , "dan.j.williams@intel.com" , "akpm@linux-foundation.org" CC: "viro@zenihttp.domain.invalid" , "ross.zwisler@linux.intel.com" , "david@fromorbit.com" , "linux-nvdimm@lists.01.org" , "linux-kernel@vger.kernel.org" , "linux-fsdevel@vger.kernel.org" Subject: Re: [PATCH v4] DAX: enable iostat for read/write Thread-Topic: [PATCH v4] DAX: enable iostat for read/write Thread-Index: AQHSa5d/ro3wS0lNGEiFAt9SbjNTx6EysT+AgADW3AA= Date: Wed, 11 Jan 2017 16:29:21 +0000 Message-ID: <1484155504.2029.3.camel@hpe.com> References: <20170111001122.10826-1-toshi.kani@hpe.com> <1484109363.12006.19.camel@perches.com> In-Reply-To: <1484109363.12006.19.camel@perches.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=toshi.kani@hpe.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [15.219.163.9] x-ms-office365-filtering-correlation-id: 9e8dc5f7-7782-4512-820d-08d43a3effcf x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:CS1PR84MB0293; x-microsoft-exchange-diagnostics: 1;CS1PR84MB0293;7:fIleuY6hn/77iGSN2XKZaJ4JlsU+HFJLLVOyN1guYUMMeqVi7hVAHpQm5wZ7Pvw1xgnudTeGvfVJEu9o2htH70AN/O68XP5O4j/dAGEzWFh4GAYmn7OKPTX/IhLD5gXIFlKLSIzXlIzlY2lPE85Kk17/47C7PINSbn97JjBjzbw6976GMY9TaUBQUH/APxBoSczz9gW75P3fWZDm+yjCCkwPLw84oiyEZMBU2oxVB/GsA341rwzVe3A/Q3rajNCllU79wpjfFLQsqq7xUNSc0Nhz25OH6Zrd30wpLV0PU9eH8OZ+Et38TIt8urDJ4/1Semj65VRDCYmZdHJuZYW+p1szNHEoN3X/gxF5Vdv6XL3nL/+Ek4ob/rH1iHb/qmOalC4qJqKMPjSzX85MRP5eRQopNqGTDzJrx2aiwOlQ3yqaiLAU9gyqH+Tf8/mHs4aF87SyB/CHz3CpayqkkkWt0Q== x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6055026)(6041248)(20161123562025)(20161123555025)(20161123564025)(20161123560025)(6072148);SRVR:CS1PR84MB0293;BCL:0;PCL:0;RULEID:;SRVR:CS1PR84MB0293; x-forefront-prvs: 01842C458A x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(7916002)(39860400002)(39840400002)(39850400002)(39410400002)(39450400003)(24454002)(189002)(377424004)(199003)(6436002)(6506006)(92566002)(8936002)(2950100002)(38730400001)(105586002)(54356999)(77096006)(122556002)(3660700001)(76176999)(8676002)(81156014)(81166006)(97736004)(2906002)(2501003)(6486002)(50986999)(5660300001)(68736007)(4326007)(6512007)(66066001)(2900100001)(33646002)(101416001)(106356001)(6116002)(2201001)(305945005)(229853002)(102836003)(106116001)(103116003)(3846002)(7736002)(3280700002)(189998001)(86362001)(5001770100001)(36756003);DIR:OUT;SFP:1102;SCL:1;SRVR:CS1PR84MB0293;H:CS1PR84MB0294.NAMPRD84.PROD.OUTLOOK.COM;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" Content-ID: <47FAF610C1BCFD4EB01438815B7AD868@NAMPRD84.PROD.OUTLOOK.COM> MIME-Version: 1.0 X-OriginatorOrg: hpe.com X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Jan 2017 16:29:21.8293 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc X-MS-Exchange-Transport-CrossTenantHeadersStamped: CS1PR84MB0293 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id v0BGTXoS010715 On Tue, 2017-01-10 at 20:36 -0800, Joe Perches wrote: > > On Tue, 2017-01-10 at 17:11 -0700, Toshi Kani wrote: > > DAX IO path does not support iostat, but its metadata IO path does. > > Therefore, iostat shows metadata IO statistics only, which has been > > confusing to users. > > [] > > diff --git a/fs/dax.c b/fs/dax.c > > [] > > @@ -1058,12 +1058,22 @@ dax_iomap_rw(struct kiocb *iocb, struct > > iov_iter *iter, > > [] > > + if (blk_queue_io_stat(disk->queue)) { > > + int sec = iov_iter_count(iter) >> 9; > > + > > + start = jiffies; > > + generic_start_io_acct(iov_iter_rw(iter), > > +       (!sec) ? 1 : sec, &disk- > > >part0); > > + } > > There is a signed/unsigned conversion of sec > It may be better to use something like: > > size_t sec  = iov_iter_count(iter) >> 9; > [...] > generic_start_io_acct(iov_iter_rw(iter), >       min_t(unsigned long, 1, sec), >       &disk->part0); Good catch. I will change as you suggested, and use 'sector_t' for 'sec'. Thanks, -Toshi