All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: Stefan Weil <stefan.weil@weilnetz.de>
Cc: qemu-devel@nongnu.org, Samuel Thibault <samuel.thibault@ens-lyon.org>
Subject: Re: [Qemu-devel] [PULL v2 05/11] sdl2: set window ID
Date: Thu, 12 Jan 2017 16:56:49 +0100	[thread overview]
Message-ID: <1484236609.5151.16.camel@redhat.com> (raw)
In-Reply-To: <a277b56c-3bb9-dcb1-eafc-0844cd77b8eb@weilnetz.de>

On Do, 2017-01-12 at 16:10 +0100, Stefan Weil wrote:
> This commit breaks builds for Windows. See below for details.

> Windows does not use X11. gcc fails:
> 
>   CC      ui/sdl2.o
> /qemu/ui/sdl2.c: In function ‘sdl_display_init’:
> /qemu/ui/sdl2.c:821:54: error: ‘union <anonymous>’ has no member named ‘x11’
>              qemu_console_set_window_id(con, info.info.x11.window);

Oops.  Any chance you can look into this?  sdl1 builds, and IIRC it has
#ifdefs to support qemu_console_set_window_id on windows too, which can
possibly ported over to sdl2 ...

thanks,
  Gerd

  reply	other threads:[~2017-01-12 15:56 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-09 13:09 [Qemu-devel] [PULL v2 00/11] ui patch queue Gerd Hoffmann
2017-01-09 13:09 ` [Qemu-devel] [PULL v2 01/11] ui/gtk: fix crash at startup when no console is available Gerd Hoffmann
2017-01-09 13:09 ` [Qemu-devel] [PULL v2 02/11] ui: use evdev keymap when running under wayland Gerd Hoffmann
2017-01-16  9:31   ` Daniel P. Berrange
2017-01-09 13:09 ` [Qemu-devel] [PULL v2 03/11] console: add API to get underlying gui window ID Gerd Hoffmann
2017-01-09 13:09 ` [Qemu-devel] [PULL v2 04/11] console: move window ID code from baum to sdl Gerd Hoffmann
2017-01-09 13:09 ` [Qemu-devel] [PULL v2 05/11] sdl2: set window ID Gerd Hoffmann
2017-01-12 15:10   ` Stefan Weil
2017-01-12 15:56     ` Gerd Hoffmann [this message]
2017-01-12 17:05       ` Samuel Thibault
2017-01-12 19:07         ` Stefan Weil
2017-01-09 13:09 ` [Qemu-devel] [PULL v2 06/11] egl-helpers: Change file licensing to LGPLv2 Gerd Hoffmann
2017-01-09 13:09 ` [Qemu-devel] [PULL v2 07/11] gtk: avoid oob array access Gerd Hoffmann
2017-01-09 13:09 ` [Qemu-devel] [PULL v2 08/11] ui: drop unused MOUSE_EVENT_WHEEL{UP, DN} defines Gerd Hoffmann
2017-01-09 13:09 ` [Qemu-devel] [PULL v2 09/11] ui/vnc: Fix problem with sending too many bytes as server name Gerd Hoffmann
2017-01-09 13:09 ` [Qemu-devel] [PULL v2 10/11] curses: Fix compiler warnings (Mingw-w64 redefinition of macro KEY_EVENT) Gerd Hoffmann
2017-01-09 13:09 ` [Qemu-devel] [PULL v2 11/11] ps2: Fix lost scancodes by recent changes Gerd Hoffmann
2017-01-09 13:49 ` [Qemu-devel] [PULL v2 00/11] ui patch queue Peter Maydell
2017-01-10  7:18   ` Gerd Hoffmann
2017-01-10 17:32     ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1484236609.5151.16.camel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=samuel.thibault@ens-lyon.org \
    --cc=stefan.weil@weilnetz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.