From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lyude Paul Subject: Re: [PATCH] drm/probe-helpers: Drop locking from poll_enable Date: Thu, 12 Jan 2017 13:08:47 -0500 Message-ID: <1484244527.7089.0.camel@redhat.com> References: <20170110142910.29922-1-daniel.vetter@ffwll.ch> <20170111090117.5134-1-daniel.vetter@ffwll.ch> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20170111090117.5134-1-daniel.vetter@ffwll.ch> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Daniel Vetter , DRI Development Cc: Daniel Vetter , Intel Graphics Development List-Id: dri-devel@lists.freedesktop.org Rml4ZXMgbG9ja2luZyBpc3N1ZXMgSSd2ZSB3aXRuZXNzZWQgb24gdGhlIFc1NDEuCgpUZXN0ZWQt Ynk6IEx5dWRlIDxseXVkZUByZWRoYXQuY29tPgpSZXZpZXdlZC1ieTogTHl1ZGUgPGx5dWRlQHJl ZGhhdC5jb20+CgpPbiBXZWQsIDIwMTctMDEtMTEgYXQgMTA6MDEgKzAxMDAsIERhbmllbCBWZXR0 ZXIgd3JvdGU6Cj4gSXQgd2FzIG9ubHkgbmVlZGVkIHRvIHByb3RlY3QgdGhlIGNvbm5lY3Rvcl9s aXN0IHdhbGtpbmcsIHNlZQo+IAo+IGNvbW1pdCA4YzRjY2M0YWI2ZjY0ZTg1OWQ0ZmY4ZDdjMDJj MmVkMmU5NTZlMDdmCj4gQXV0aG9yOiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGZmd2xs LmNoPgo+IERhdGU6wqDCoMKgVGh1IEp1bCA5IDIzOjQ0OjI2IDIwMTUgKzAyMDAKPiAKPiDCoMKg wqDCoGRybS9wcm9iZS1oZWxwZXI6IEdyYWIgbW9kZV9jb25maWcubXV0ZXggaW4gcG9sbF9pbml0 L2VuYWJsZQo+IAo+IFVuZm9ydHVuYXRlbHkgdGhlIGNvbW1pdCBtZXNzYWdlIG9mIHRoYXQgcGF0 Y2ggZmFpbHMgdG8gbWVudGlvbiB0aGF0Cj4gdGhlIG5ldyBsb2NraW5nIGNoZWNrIHdhcyBmb3Ig dGhlIGNvbm5lY3Rvcl9saXN0Lgo+IAo+IEJ1dCB0aGF0IHJlcXVpcmVtZW50IGRpc2FwcGVhcmVk IGluCj4gCj4gY29tbWl0IGMzNmEzMjU0Zjc4NTdmMWFkOWJhZGJlMzU3OGNjYzkyYmU1NDFhOGUK PiBBdXRob3I6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJAZmZ3bGwuY2g+Cj4gRGF0ZTrC oMKgwqBUaHUgRGVjIDE1IDE2OjU4OjQzIDIwMTYgKzAxMDAKPiAKPiDCoMKgwqDCoGRybTogQ29u dmVydCBhbGwgaGVscGVycyB0byBkcm1fY29ubmVjdG9yX2xpc3RfaXRlcgo+IAo+IGFuZCBzbyB3 ZSBjYW4gZHJvcCB0aGlzIGFnYWluLgo+IAo+IFRoaXMgZml4ZXMgYSBsb2NraW5nIGludmVyc2lv biBvbiBub3V2ZWF1LCB3aGVyZSB0aGUgcnBtIGNvZGUgbmVlZHMKPiB0bwo+IHJlLWVuYWJsZS4g QnV0IGluIG90aGVyIHBsYWNlcyB0aGUgcnBtX2dldCgpIGNhbGxzIGFyZSBuZXN0ZWQgd2l0aGlu Cj4gdGhlIGJpZyBtb2Rlc2V0IGxvY2tzLgo+IAo+IFdoaWxlIGF0IGl0LCBhbHNvIGltcHJvdmUg dGhlIGtlcm5lbGRvYyBmb3IgdGhlc2UgdHdvIGZ1bmN0aW9ucyBhCj4gbm90Y2guCj4gCj4gdjI6 IFVwZGF0ZSB0aGUga2VybmVsZG9jIGV2ZW4gbW9yZSB0byBleHBsYWluIHRoYXQgdGhlc2UgZnVu Y3Rpb25zCj4gY2FuJ3QgYmUgY2FsbGVkIGNvbmN1cnJlbnRseSwgb3IgYmFkIHRoaW5ncyBoYXBw ZW4gKENocmlzKS4KPiAKPiBDYzogRGF2ZSBBaXJsaWUgPGFpcmxpZWRAZ21haWwuY29tPgo+IFJl dmlld2VkLWJ5OiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiBDYzog Q2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4gU2lnbmVkLW9mZi1ieTog RGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBpbnRlbC5jb20+Cj4gLS0tCj4gwqBkcml2ZXJz L2dwdS9kcm0vZHJtX3Byb2JlX2hlbHBlci5jwqDCoMKgfCA1MSArKysrKysrKysrKysrKy0tLS0t LS0tLS0KPiAtLS0tLS0tLS0tLS0KPiDCoGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2hvdHBs dWcuYyB8wqDCoDQgKy0tCj4gwqBpbmNsdWRlL2RybS9kcm1fY3J0Y19oZWxwZXIuaMKgwqDCoMKg wqDCoMKgwqB8wqDCoDEgLQo+IMKgMyBmaWxlcyBjaGFuZ2VkLCAyMiBpbnNlcnRpb25zKCspLCAz NCBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2RybV9wcm9i ZV9oZWxwZXIuYwo+IGIvZHJpdmVycy9ncHUvZHJtL2RybV9wcm9iZV9oZWxwZXIuYwo+IGluZGV4 IDIwZjQ4ZDFlMjc4NS4uOTMzODE0NTRiZGY3IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2Ry bS9kcm1fcHJvYmVfaGVscGVyLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX3Byb2JlX2hl bHBlci5jCj4gQEAgLTExNSwyNSArMTE1LDI4IEBAIHN0YXRpYyBpbnQKPiBkcm1faGVscGVyX3By b2JlX2FkZF9jbWRsaW5lX21vZGUoc3RydWN0IGRybV9jb25uZWN0b3IgKmNvbm5lY3RvcikKPiDC oAo+IMKgI2RlZmluZSBEUk1fT1VUUFVUX1BPTExfUEVSSU9EICgxMCpIWikKPiDCoC8qKgo+IC0g KiBkcm1fa21zX2hlbHBlcl9wb2xsX2VuYWJsZV9sb2NrZWQgLSByZS1lbmFibGUgb3V0cHV0IHBv bGxpbmcuCj4gKyAqIGRybV9rbXNfaGVscGVyX3BvbGxfZW5hYmxlIC0gcmUtZW5hYmxlIG91dHB1 dCBwb2xsaW5nLgo+IMKgICogQGRldjogZHJtX2RldmljZQo+IMKgICoKPiAtICogVGhpcyBmdW5j dGlvbiByZS1lbmFibGVzIHRoZSBvdXRwdXQgcG9sbGluZyB3b3JrIHdpdGhvdXQKPiAtICogbG9j a2luZyB0aGUgbW9kZV9jb25maWcgbXV0ZXguCj4gKyAqIFRoaXMgZnVuY3Rpb24gcmUtZW5hYmxl cyB0aGUgb3V0cHV0IHBvbGxpbmcgd29yaywgYWZ0ZXIgaXQgaGFzCj4gYmVlbgo+ICsgKiB0ZW1w b3JhcmlseSBkaXNhYmxlZCB1c2luZyBkcm1fa21zX2hlbHBlcl9wb2xsX2Rpc2FibGUoKSwgZm9y Cj4gZXhhbXBsZSBvdmVyCj4gKyAqIHN1c3BlbmQvcmVzdW1lLgo+IMKgICoKPiAtICogVGhpcyBp cyBsaWtlIGRybV9rbXNfaGVscGVyX3BvbGxfZW5hYmxlKCkgaG93ZXZlciBpdCBpcyB0byBiZQo+ IC0gKiBjYWxsZWQgZnJvbSBhIGNvbnRleHQgd2hlcmUgdGhlIG1vZGVfY29uZmlnIG11dGV4IGlz IGxvY2tlZAo+IC0gKiBhbHJlYWR5Lgo+ICsgKiBEcml2ZXJzIGNhbiBjYWxsIHRoaXMgaGVscGVy IGZyb20gdGhlaXIgZGV2aWNlIHJlc3VtZQo+IGltcGxlbWVudGF0aW9uLiBJdCBpcwo+ICsgKiBh biBlcnJvciB0byBjYWxsIHRoaXMgd2hlbiB0aGUgb3V0cHV0IHBvbGxpbmcgc3VwcG9ydCBoYXMg bm90IHlldAo+IGJlZW4gc2V0Cj4gKyAqIHVwLgo+ICsgKgo+ICsgKiBOb3RlIHRoYXQgY2FsbHMg dG8gZW5hYmxlIGFuZCBkaXNhYmxlIHBvbGxpbmcgbXVzdCBiZSBzdHJpY3RseQo+IG9yZGVyZWQs IHdoaWNoCj4gKyAqIGlzIGF1dG9tYXRpY2FsbHkgdGhlIGNhc2Ugd2hlbiB0aGV5J3JlIG9ubHkg Y2FsbCBmcm9tCj4gc3VzcGVuZC9yZXN1bWUKPiArICogY2FsbGJhY2tzLgo+IMKgICovCj4gLXZv aWQgZHJtX2ttc19oZWxwZXJfcG9sbF9lbmFibGVfbG9ja2VkKHN0cnVjdCBkcm1fZGV2aWNlICpk ZXYpCj4gK3ZvaWQgZHJtX2ttc19oZWxwZXJfcG9sbF9lbmFibGUoc3RydWN0IGRybV9kZXZpY2Ug KmRldikKPiDCoHsKPiDCoAlib29sIHBvbGwgPSBmYWxzZTsKPiDCoAlzdHJ1Y3QgZHJtX2Nvbm5l Y3RvciAqY29ubmVjdG9yOwo+IMKgCXN0cnVjdCBkcm1fY29ubmVjdG9yX2xpc3RfaXRlciBjb25u X2l0ZXI7Cj4gwqAJdW5zaWduZWQgbG9uZyBkZWxheSA9IERSTV9PVVRQVVRfUE9MTF9QRVJJT0Q7 Cj4gwqAKPiAtCVdBUk5fT04oIW11dGV4X2lzX2xvY2tlZCgmZGV2LT5tb2RlX2NvbmZpZy5tdXRl eCkpOwo+IC0KPiDCoAlpZiAoIWRldi0+bW9kZV9jb25maWcucG9sbF9lbmFibGVkIHx8ICFkcm1f a21zX2hlbHBlcl9wb2xsKQo+IMKgCQlyZXR1cm47Cj4gwqAKPiBAQCAtMTYzLDcgKzE2Niw3IEBA IHZvaWQgZHJtX2ttc19oZWxwZXJfcG9sbF9lbmFibGVfbG9ja2VkKHN0cnVjdAo+IGRybV9kZXZp Y2UgKmRldikKPiDCoAlpZiAocG9sbCkKPiDCoAkJc2NoZWR1bGVfZGVsYXllZF93b3JrKCZkZXYt Cj4gPm1vZGVfY29uZmlnLm91dHB1dF9wb2xsX3dvcmssIGRlbGF5KTsKPiDCoH0KPiAtRVhQT1JU X1NZTUJPTChkcm1fa21zX2hlbHBlcl9wb2xsX2VuYWJsZV9sb2NrZWQpOwo+ICtFWFBPUlRfU1lN Qk9MKGRybV9rbXNfaGVscGVyX3BvbGxfZW5hYmxlKTsKPiDCoAo+IMKgc3RhdGljIGVudW0gZHJt X2Nvbm5lY3Rvcl9zdGF0dXMKPiDCoGRybV9jb25uZWN0b3JfZGV0ZWN0KHN0cnVjdCBkcm1fY29u bmVjdG9yICpjb25uZWN0b3IsIGJvb2wgZm9yY2UpCj4gQEAgLTI5MCw3ICsyOTMsNyBAQCBpbnQK PiBkcm1faGVscGVyX3Byb2JlX3NpbmdsZV9jb25uZWN0b3JfbW9kZXMoc3RydWN0IGRybV9jb25u ZWN0b3IKPiAqY29ubmVjdG9yLAo+IMKgCj4gwqAJLyogUmUtZW5hYmxlIHBvbGxpbmcgaW4gY2Fz ZSB0aGUgZ2xvYmFsIHBvbGwgY29uZmlnIGNoYW5nZWQuCj4gKi8KPiDCoAlpZiAoZHJtX2ttc19o ZWxwZXJfcG9sbCAhPSBkZXYtPm1vZGVfY29uZmlnLnBvbGxfcnVubmluZykKPiAtCQlkcm1fa21z X2hlbHBlcl9wb2xsX2VuYWJsZV9sb2NrZWQoZGV2KTsKPiArCQlkcm1fa21zX2hlbHBlcl9wb2xs X2VuYWJsZShkZXYpOwo+IMKgCj4gwqAJZGV2LT5tb2RlX2NvbmZpZy5wb2xsX3J1bm5pbmcgPSBk cm1fa21zX2hlbHBlcl9wb2xsOwo+IMKgCj4gQEAgLTQ4NCw4ICs0ODcsMTIgQEAgc3RhdGljIHZv aWQgb3V0cHV0X3BvbGxfZXhlY3V0ZShzdHJ1Y3QKPiB3b3JrX3N0cnVjdCAqd29yaykKPiDCoCAq IFRoaXMgZnVuY3Rpb24gZGlzYWJsZXMgdGhlIG91dHB1dCBwb2xsaW5nIHdvcmsuCj4gwqAgKgo+ IMKgICogRHJpdmVycyBjYW4gY2FsbCB0aGlzIGhlbHBlciBmcm9tIHRoZWlyIGRldmljZSBzdXNw ZW5kCj4gaW1wbGVtZW50YXRpb24uIEl0IGlzCj4gLSAqIG5vdCBhbiBlcnJvciB0byBjYWxsIHRo aXMgZXZlbiB3aGVuIG91dHB1dCBwb2xsaW5nIGlzbid0IGVuYWJsZWQKPiBvciBhcmxyZWFkeQo+ IC0gKiBkaXNhYmxlZC4KPiArICogbm90IGFuIGVycm9yIHRvIGNhbGwgdGhpcyBldmVuIHdoZW4g b3V0cHV0IHBvbGxpbmcgaXNuJ3QgZW5hYmxlZAo+IG9yIGFscmVhZHkKPiArICogZGlzYWJsZWQu IFBvbGxpbmcgaXMgcmUtZW5hYmxlZCBieSBjYWxsaW5nCj4gZHJtX2ttc19oZWxwZXJfcG9sbF9l bmFibGUoKS4KPiArICoKPiArICogTm90ZSB0aGF0IGNhbGxzIHRvIGVuYWJsZSBhbmQgZGlzYWJs ZSBwb2xsaW5nIG11c3QgYmUgc3RyaWN0bHkKPiBvcmRlcmVkLCB3aGljaAo+ICsgKiBpcyBhdXRv bWF0aWNhbGx5IHRoZSBjYXNlIHdoZW4gdGhleSdyZSBvbmx5IGNhbGwgZnJvbQo+IHN1c3BlbmQv cmVzdW1lCj4gKyAqIGNhbGxiYWNrcy4KPiDCoCAqLwo+IMKgdm9pZCBkcm1fa21zX2hlbHBlcl9w b2xsX2Rpc2FibGUoc3RydWN0IGRybV9kZXZpY2UgKmRldikKPiDCoHsKPiBAQCAtNDk2LDI0ICs1 MDMsNiBAQCB2b2lkIGRybV9rbXNfaGVscGVyX3BvbGxfZGlzYWJsZShzdHJ1Y3QKPiBkcm1fZGV2 aWNlICpkZXYpCj4gwqBFWFBPUlRfU1lNQk9MKGRybV9rbXNfaGVscGVyX3BvbGxfZGlzYWJsZSk7 Cj4gwqAKPiDCoC8qKgo+IC0gKiBkcm1fa21zX2hlbHBlcl9wb2xsX2VuYWJsZSAtIHJlLWVuYWJs ZSBvdXRwdXQgcG9sbGluZy4KPiAtICogQGRldjogZHJtX2RldmljZQo+IC0gKgo+IC0gKiBUaGlz IGZ1bmN0aW9uIHJlLWVuYWJsZXMgdGhlIG91dHB1dCBwb2xsaW5nIHdvcmsuCj4gLSAqCj4gLSAq IERyaXZlcnMgY2FuIGNhbGwgdGhpcyBoZWxwZXIgZnJvbSB0aGVpciBkZXZpY2UgcmVzdW1lCj4g aW1wbGVtZW50YXRpb24uIEl0IGlzCj4gLSAqIGFuIGVycm9yIHRvIGNhbGwgdGhpcyB3aGVuIHRo ZSBvdXRwdXQgcG9sbGluZyBzdXBwb3J0IGhhcyBub3QgeWV0Cj4gYmVlbiBzZXQKPiAtICogdXAu Cj4gLSAqLwo+IC12b2lkIGRybV9rbXNfaGVscGVyX3BvbGxfZW5hYmxlKHN0cnVjdCBkcm1fZGV2 aWNlICpkZXYpCj4gLXsKPiAtCW11dGV4X2xvY2soJmRldi0+bW9kZV9jb25maWcubXV0ZXgpOwo+ IC0JZHJtX2ttc19oZWxwZXJfcG9sbF9lbmFibGVfbG9ja2VkKGRldik7Cj4gLQltdXRleF91bmxv Y2soJmRldi0+bW9kZV9jb25maWcubXV0ZXgpOwo+IC19Cj4gLUVYUE9SVF9TWU1CT0woZHJtX2tt c19oZWxwZXJfcG9sbF9lbmFibGUpOwo+IC0KPiAtLyoqCj4gwqAgKiBkcm1fa21zX2hlbHBlcl9w b2xsX2luaXQgLSBpbml0aWFsaXplIGFuZCBlbmFibGUgb3V0cHV0IHBvbGxpbmcKPiDCoCAqIEBk ZXY6IGRybV9kZXZpY2UKPiDCoCAqCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1 L2ludGVsX2hvdHBsdWcuYwo+IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfaG90cGx1Zy5j Cj4gaW5kZXggMmRkYzllNTg0MmVjLi41MTIyZDRiZmI3MGUgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfaG90cGx1Zy5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfaG90cGx1Zy5jCj4gQEAgLTE4Miw3ICsxODIsNyBAQCBzdGF0aWMgdm9pZCBpbnRl bF9ocGRfaXJxX3N0b3JtX2Rpc2FibGUoc3RydWN0Cj4gZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3By aXYpCj4gwqAKPiDCoAkvKiBFbmFibGUgcG9sbGluZyBhbmQgcXVldWUgaG90cGx1ZyByZS1lbmFi bGluZy4gKi8KPiDCoAlpZiAoaHBkX2Rpc2FibGVkKSB7Cj4gLQkJZHJtX2ttc19oZWxwZXJfcG9s bF9lbmFibGVfbG9ja2VkKGRldik7Cj4gKwkJZHJtX2ttc19oZWxwZXJfcG9sbF9lbmFibGUoZGV2 KTsKPiDCoAkJbW9kX2RlbGF5ZWRfd29yayhzeXN0ZW1fd3EsICZkZXZfcHJpdi0KPiA+aG90cGx1 Zy5yZWVuYWJsZV93b3JrLAo+IMKgCQkJCcKgbXNlY3NfdG9famlmZmllcyhIUERfU1RPUk1fUkVF TkFCTEUKPiBfREVMQVkpKTsKPiDCoAl9Cj4gQEAgLTUxOSw3ICs1MTksNyBAQCBzdGF0aWMgdm9p ZCBpOTE1X2hwZF9wb2xsX2luaXRfd29yayhzdHJ1Y3QKPiB3b3JrX3N0cnVjdCAqd29yaykKPiDC oAlkcm1fY29ubmVjdG9yX2xpc3RfaXRlcl9wdXQoJmNvbm5faXRlcik7Cj4gwqAKPiDCoAlpZiAo ZW5hYmxlZCkKPiAtCQlkcm1fa21zX2hlbHBlcl9wb2xsX2VuYWJsZV9sb2NrZWQoZGV2KTsKPiAr CQlkcm1fa21zX2hlbHBlcl9wb2xsX2VuYWJsZShkZXYpOwo+IMKgCj4gwqAJbXV0ZXhfdW5sb2Nr KCZkZXYtPm1vZGVfY29uZmlnLm11dGV4KTsKPiDCoAo+IGRpZmYgLS1naXQgYS9pbmNsdWRlL2Ry bS9kcm1fY3J0Y19oZWxwZXIuaAo+IGIvaW5jbHVkZS9kcm0vZHJtX2NydGNfaGVscGVyLmgKPiBp bmRleCA5ODJjMjk5ZTQzNWEuLmQwMjZmNTAxN2MzMyAxMDA2NDQKPiAtLS0gYS9pbmNsdWRlL2Ry bS9kcm1fY3J0Y19oZWxwZXIuaAo+ICsrKyBiL2luY2x1ZGUvZHJtL2RybV9jcnRjX2hlbHBlci5o Cj4gQEAgLTczLDYgKzczLDUgQEAgZXh0ZXJuIHZvaWQgZHJtX2ttc19oZWxwZXJfaG90cGx1Z19l dmVudChzdHJ1Y3QKPiBkcm1fZGV2aWNlICpkZXYpOwo+IMKgCj4gwqBleHRlcm4gdm9pZCBkcm1f a21zX2hlbHBlcl9wb2xsX2Rpc2FibGUoc3RydWN0IGRybV9kZXZpY2UgKmRldik7Cj4gwqBleHRl cm4gdm9pZCBkcm1fa21zX2hlbHBlcl9wb2xsX2VuYWJsZShzdHJ1Y3QgZHJtX2RldmljZSAqZGV2 KTsKPiAtZXh0ZXJuIHZvaWQgZHJtX2ttc19oZWxwZXJfcG9sbF9lbmFibGVfbG9ja2VkKHN0cnVj dCBkcm1fZGV2aWNlCj4gKmRldik7Cj4gwqAKPiDCoCNlbmRpZgpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVs LWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcv bWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK